From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 61736-done@debbugs.gnu.org, "Daniel Martín" <mardani29@yahoo.es>
Subject: bug#61736: Fix typos in docstrings in c-ts-common.el
Date: Fri, 24 Feb 2023 20:50:48 -0800 [thread overview]
Message-ID: <CAECA17D-48E3-41A1-B443-3B0100D752E6@gmail.com> (raw)
In-Reply-To: <m1a614qoc5.fsf@yahoo.es>
Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Thu, 23 Feb 2023 18:32:58 +0100
>> From: Daniel Martín via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>
>> I've attached a patch to fix a couple of typos in c-ts-common.el.
>
> Thanks.
>
>> (defun c-ts-common-statement-offset (node parent &rest _)
>> - "This anchor is used for children of a statement inside a block.
>> + "Return an offset for children of a statement inside a block.
>
> Is the new text really accurate? The rest of the doc string doesn'
> mention "offset" even once, and without explaining what kind of
> "offset" is this, the first sentence could mislead and confuse.
>
> So I think this part of the patch "needs more work".
>
> I installed the first part, thanks.
The second part is valid. I applied it with some minor change, thanks!
Yuan
prev parent reply other threads:[~2023-02-25 4:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m1a614qoc5.fsf.ref@yahoo.es>
2023-02-23 17:32 ` bug#61736: Fix typos in docstrings in c-ts-common.el Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-23 17:52 ` Eli Zaretskii
2023-02-25 4:50 ` Yuan Fu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAECA17D-48E3-41A1-B443-3B0100D752E6@gmail.com \
--to=casouri@gmail.com \
--cc=61736-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=mardani29@yahoo.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).