unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#66983: 29.1; sql-sqlite prompt-cont-regexp incompatible since sqlite 3.41.0
@ 2023-11-07 10:20 Gustav Broberg
  2023-11-10  9:41 ` bug#66983: [PATCH] sql.el: Let sqlite's prompt-cont-regexp accept new dynamic prompt Gustav Broberg
  0 siblings, 1 reply; 7+ messages in thread
From: Gustav Broberg @ 2023-11-07 10:20 UTC (permalink / raw)
  To: 66983

[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]

The continuation prompt regexp for sql.el's sqlite product is hard coded as
"   ...> ":
http://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/progmodes/sql.el?id=a1abb6a85e6605c256595b8d7b885018e5421c28#n497

But since SQLite version 3.41.0 this prompt is no longer static but dynamic
and contains information about current context (unclosed string,
parentheses, etc.):
https://www.sqlite.org/releaselog/3_41_0.html

For example, sending a multi-line query with an unclosed string like:

  SELECT 1
  AS "two lines
  ";

will give an output like:

  SQLite version 3.44.0 2023-11-01 11:23:50
  Enter ".help" for usage hints.
  sqlite>
  "  ...> ┌───────────┐
  │ two lines │
  ├───────────┤
  │ 1         │
  └───────────┘
  Run Time: real 0.000 user 0.000118 sys 0.000076

because the continuation prompt is '"  ...> '.

Setting a custom sqlite continuation prompt regexp to match the dynamic
prompt
fixes this:

  (sql-set-product-feature 'sqlite :prompt-cont-regexp "^...\\.\\.\\.> ")

I suggest updating the regexp in sql.el to this (or some more specific)
regexp.

Thanks!
-- 
Gustav

[-- Attachment #2: Type: text/html, Size: 1606 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-12-15 10:05 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-07 10:20 bug#66983: 29.1; sql-sqlite prompt-cont-regexp incompatible since sqlite 3.41.0 Gustav Broberg
2023-11-10  9:41 ` bug#66983: [PATCH] sql.el: Let sqlite's prompt-cont-regexp accept new dynamic prompt Gustav Broberg
2023-11-10 12:06   ` Eli Zaretskii
2023-11-25  9:26     ` Eli Zaretskii
2023-12-15  1:28       ` Stefan Kangas
2023-12-15  8:39         ` Eli Zaretskii
2023-12-15 10:05         ` Gustav Broberg

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).