From: Laurence Warne <laurencewarne@gmail.com>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: 59272@debbugs.gnu.org, Visuwesh <visuweshm@gmail.com>,
Juri Linkov <juri@linkov.net>
Subject: bug#59272: [PATCH] Make Memory Human Readable in proced Buffers
Date: Wed, 16 Nov 2022 08:56:42 +0000 [thread overview]
Message-ID: <CAE2oLqgcCeVhF=zuXXW8mXTs5EuC-xpD6KbeK=_iBKj2HE41jQ@mail.gmail.com> (raw)
In-Reply-To: <CAE2oLqgudxCPkL0-D5OHv8BMcW=dv53NWsfdddw_RM+ACzAQUw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 164 bytes --]
Alright, I've had a look at sysdep.c, and it looks like bytes are divided
by 1024 to convert to kilobytes.
I've attached an updated patch using Juri's suggestion.
[-- Attachment #1.2: Type: text/html, Size: 253 bytes --]
[-- Attachment #2: 0001-Make-vsize-and-rss-human-readable-in-proced-buffers.patch --]
[-- Type: text/x-patch, Size: 1778 bytes --]
From 9ef79917565bfd36dc67c124d3656376ea48d48b Mon Sep 17 00:00:00 2001
From: Laurence Warne <laurencewarne@gmail.com>
Date: Sun, 13 Nov 2022 19:53:17 +0000
Subject: [PATCH] Make vsize and rss human readable in proced buffers
* lisp/proced.el (proced-format-memory): new function
(proced-grammar-alist): use proced-format-memory to format vsize and rss
---
lisp/proced.el | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lisp/proced.el b/lisp/proced.el
index a774f2dd1e..a6f1a71778 100644
--- a/lisp/proced.el
+++ b/lisp/proced.el
@@ -140,8 +140,8 @@ proced-grammar-alist
(nice "Ni" "%3d" 3 proced-< t (nice pid) (t t nil))
(thcount "THCount" "%d" right proced-< t (thcount pid) (nil t t))
(start "Start" proced-format-start 6 proced-time-lessp nil (start pid) (t t nil))
- (vsize "VSize" "%d" right proced-< t (vsize pid) (nil t t))
- (rss "RSS" "%d" right proced-< t (rss pid) (nil t t))
+ (vsize "VSize" proced-format-memory right proced-< t (vsize pid) (nil t t))
+ (rss "RSS" proced-format-memory right proced-< t (rss pid) (nil t t))
(etime "ETime" proced-format-time right proced-time-lessp t (etime pid) (nil t t))
(pcpu "%CPU" "%.1f" right proced-< t (pcpu pid) (nil t t))
(pmem "%Mem" "%.1f" right proced-< t (pmem pid) (nil t t))
@@ -1425,6 +1425,10 @@ proced-format-args
Replace newline characters by \"^J\" (two characters)."
(string-replace "\n" "^J" args))
+(defun proced-format-memory (kilobytes)
+ "Format KILOBYTES in a human readable format."
+ (funcall byte-count-to-string-function (* 1024 kilobytes)))
+
(defun proced-format (process-alist format)
"Display PROCESS-ALIST using FORMAT."
(if (symbolp format)
--
2.30.2
next prev parent reply other threads:[~2022-11-16 8:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 10:19 bug#59272: [PATCH] Make Memory Human Readable in proced Buffers Laurence Warne
2022-11-15 3:28 ` Visuwesh
2022-11-15 3:40 ` Stefan Kangas
2022-11-15 8:06 ` Juri Linkov
2022-11-15 8:59 ` Stefan Kangas
2022-11-15 9:51 ` Laurence Warne
2022-11-16 8:56 ` Laurence Warne [this message]
2022-11-17 9:55 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE2oLqgcCeVhF=zuXXW8mXTs5EuC-xpD6KbeK=_iBKj2HE41jQ@mail.gmail.com' \
--to=laurencewarne@gmail.com \
--cc=59272@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=stefankangas@gmail.com \
--cc=visuweshm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).