From: Stefan Kangas <stefan@marxist.se>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 27581@debbugs.gnu.org, npostavs@users.sourceforge.net
Subject: bug#27581: 26.0.50; Error while compiling new Org code
Date: Mon, 10 Aug 2020 10:09:36 -0700 [thread overview]
Message-ID: <CADwFkmny4uECtn9PcpC3g2XDLSOsshpWfMg6=_qU+Gk0KLQvEg@mail.gmail.com> (raw)
In-Reply-To: <jwv60f7zodw.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Tue, 04 Jul 2017 21:04:17 -0400")
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>> I think I hit this, and doing 'make autoloads' fixed it.
>
> Duh, indeed, so the `declare-function` should be removed.
> Remains my question about the use of eval-after-load.
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
> So it's triggered during the evaluation of org-compat.el's after-load:
>
> (eval-after-load 'org
> '(progn
> (org-link-set-parameters "file+emacs") ;since Org 9.0
> (org-link-set-parameters "file+sys"))) ;since Org 9.0
>
> There's a (declare-function org-element-update-syntax ...) in org.el but
> it looks like org-element is not loaded in this case.
>
> Not sure which is the right fix, but I do wonder why have this
> eval-after-load in org-compat.el instead of simply moving the code to
> org.el: eval-after-load is normally only used when we need to add code
> to a file that's not under our control.
I can't find that eval-after-load in org-compat.el, so I guess this has
been fixed in the three years since this was reported.
I guess this should be closed then?
Best regards,
Stefan Kangas
next prev parent reply other threads:[~2020-08-10 17:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 0:58 bug#27581: 26.0.50; Error while compiling new Org code Stefan Monnier
2017-07-05 1:03 ` npostavs
2017-07-05 1:04 ` Stefan Monnier
2017-07-05 1:13 ` Stefan Monnier
2017-07-05 20:06 ` Glenn Morris
2017-07-05 23:19 ` Stefan Monnier
2020-08-10 17:09 ` Stefan Kangas [this message]
2020-10-01 11:59 ` Stefan Kangas
2017-07-05 20:04 ` Glenn Morris
2017-07-05 20:09 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmny4uECtn9PcpC3g2XDLSOsshpWfMg6=_qU+Gk0KLQvEg@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=27581@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).