From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#41852: 27.0.50; text-scale commands don't scale header of tabulated-list-mode Date: Sat, 31 Oct 2020 00:31:45 +0000 Message-ID: References: <955fe4fe-a64d-b7c6-fe31-7efd810f97a5@ims.co.at> <83mu553e0x.fsf@gnu.org> <953c6df9-59b4-8b57-0be3-600d147fe9c7@ims.co.at> <83y2k2pabb.fsf@gnu.org> <83wnzmnioj.fsf@gnu.org> <83lfg1nfv1.fsf@gnu.org> <83d01dnegn.fsf@gnu.org> <2ae49edc-098f-9ace-595d-9e29bf3d2c8b@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6905"; mail-complaints-to="usenet@ciao.gmane.io" Cc: thomas.hisch@ims.co.at, 41852@debbugs.gnu.org To: martin rudalics , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 31 01:32:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYeoX-0001g2-Er for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Oct 2020 01:32:13 +0100 Original-Received: from localhost ([::1]:45936 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYeoW-0000RX-4c for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 20:32:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYeoN-0000RJ-ET for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 20:32:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48654) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYeoL-0003xY-U6 for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 20:32:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYeoL-0006ba-Q1 for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 20:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Oct 2020 00:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41852 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41852-submit@debbugs.gnu.org id=B41852.160410431425369 (code B ref 41852); Sat, 31 Oct 2020 00:32:01 +0000 Original-Received: (at 41852) by debbugs.gnu.org; 31 Oct 2020 00:31:54 +0000 Original-Received: from localhost ([127.0.0.1]:60200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYeoD-0006b6-MF for submit@debbugs.gnu.org; Fri, 30 Oct 2020 20:31:53 -0400 Original-Received: from mail-ed1-f42.google.com ([209.85.208.42]:44163) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYeoC-0006at-5V for 41852@debbugs.gnu.org; Fri, 30 Oct 2020 20:31:52 -0400 Original-Received: by mail-ed1-f42.google.com with SMTP id w1so7315247edv.11 for <41852@debbugs.gnu.org>; Fri, 30 Oct 2020 17:31:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=dIaDjEPDBPSg+CdgzIVLGcz9OzmnYJG7fFX9GGYmsAg=; b=Mj99HhZMe0KPJwUU5qyck79G/Y/pY6WSDyIvny702DR5r2NGV2Vzyi2eGKn2sE02e6 ULrplt85J50vJTORVuNMDkOr1y1kDPPGPFa7n+0fZmrNpNiuWkT/euCPXx+EpO0mayw2 2YSfijDKyvNSqtWA5/vboQH/gYAnconDoEt/I759ltRN87NLOrcwvakMpwC109wfmmPe dbq8vnFsvFrS74V/E1UcD3evtsawx3qHdJ7xmMabNJNRYdkENWriAkgf7t9Y8Nh7Zc/K Ux4X+rSrSvy8JPKcSP55WEO505qDnoXBZlRb9O6GjsbqVuHiKy54R3Q2uVZ/l+kIQe0v X+lA== X-Gm-Message-State: AOAM5313aLWR5WQi9DWVwqqEgVmfB4nQtcs2x91/Ot4/ees6q/qIZd6H yhH5Y/LlY6V3YGhej81Ud0H1dGQXYTmtbSohyrQ= X-Google-Smtp-Source: ABdhPJxwV3jswwYTj3OImAtG2fZO+r6gtLvmsq71plzTwzExU9GayWLrRJWfuAlNH5519qiXMI+Ndex1cryKqMvVhKY= X-Received: by 2002:aa7:d888:: with SMTP id u8mr4299974edq.210.1604104306421; Fri, 30 Oct 2020 17:31:46 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 31 Oct 2020 00:31:45 +0000 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192224 Archived-At: martin rudalics writes: > > When the new buffer local variable 'text-scale-remap-header-line-face' > > is non-nil, 'text-scale-adjust' will also change the font size of the > > 'header-line' face in the current buffer. > > I'd say "will also scale the text in the mode line when displaying that > buffer". It doesn't scale the text in the mode line, though. > > This will also affect any > > face that inherits from it. > > But if I assign the header line face or some face inheriting from it to > some buffer text (not that I recommend doing that), that text will be > scaled regardless of the value of 'text-scale-remap-header-line-face'. > Right? Yes. But that seems (in my testing) to be the case for any face I tested that doesn't have an absolute value for :height. So I'm not sure that it needs to be specifically mentioned in NEWS. > Here too I would say something like "the buffer text is scaled". The > default face itself is not scaled by face remapping. The remapping is > applied by the display engine whenever the buffer is displayed after all > faces have been merged. But maybe that is clear to everyone and you > should simply ignore what I wrote. I'm not sure it is clear to everyone (it cleared some stuff up for me), but I worry that this might be too detailed for NEWS. The interesting bits is probably not exactly how it works, but rather what its visible effects are. > We might have a problem when these two are set in separate steps. Yes, if the variable is set after scaling, it does not take effect until another scaling operation is done. Adding this seems to fix that: (add-variable-watcher 'text-scale-remap-header-line-face #'text-scale--refresh) (defun text-scale--refresh (symbol newval operation where) (when (and (eq symbol 'text-scale-remap-header-line-face) (eq operation 'set) text-scale-mode) (with-current-buffer where (let ((text-scale-remap-header-line-face newval)) (text-scale-mode 1)))))