From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#52200: 29.0.50; image-dired-cmd-create-standard-thumbnail-options Date: Wed, 8 Dec 2021 18:01:50 -0800 Message-ID: References: <87o861k3x9.fsf@a16n.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19840"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 52200@debbugs.gnu.org To: Peter =?UTF-8?Q?M=C3=BCnster?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 09 03:02:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mv8lG-0004wV-RU for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Dec 2021 03:02:18 +0100 Original-Received: from localhost ([::1]:37790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mv8lE-0005PS-LF for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Dec 2021 21:02:16 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mv8l2-0005P6-H6 for bug-gnu-emacs@gnu.org; Wed, 08 Dec 2021 21:02:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58660) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mv8l0-0000zL-Gh for bug-gnu-emacs@gnu.org; Wed, 08 Dec 2021 21:02:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mv8l0-0003qd-Cv for bug-gnu-emacs@gnu.org; Wed, 08 Dec 2021 21:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Dec 2021 02:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52200 X-GNU-PR-Package: emacs Original-Received: via spool by 52200-submit@debbugs.gnu.org id=B52200.163901531814782 (code B ref 52200); Thu, 09 Dec 2021 02:02:02 +0000 Original-Received: (at 52200) by debbugs.gnu.org; 9 Dec 2021 02:01:58 +0000 Original-Received: from localhost ([127.0.0.1]:41973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mv8kw-0003qM-J5 for submit@debbugs.gnu.org; Wed, 08 Dec 2021 21:01:58 -0500 Original-Received: from mail-pg1-f178.google.com ([209.85.215.178]:38858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mv8ku-0003q7-K6 for 52200@debbugs.gnu.org; Wed, 08 Dec 2021 21:01:57 -0500 Original-Received: by mail-pg1-f178.google.com with SMTP id s137so3701907pgs.5 for <52200@debbugs.gnu.org>; Wed, 08 Dec 2021 18:01:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc :content-transfer-encoding; bh=hx5FWoh6n6lcio0yf2uidLCh1iDFAgKeed0vml538ec=; b=akCKo2K6j3ZqpXNBneQ5KPWQrTFRqDy5fxeNCOXqDBvio3qFBBVYDlsBnCJCxNVEqe //hfzH0m970W8jHgwN2CqvnCO6qgGBV//r7E2Fx5SSxjSxMRtFq11VjiWnoCqrhFd6I+ 6hS1NA7TDWkPh13xpCuL/HhG8eTCEJMqMCG7O8DH30wBJEayNVHyFGa5pLzik3dHevXh 8j6flKHaysba0YSqlTupvp/LFp47TxjcnFnmGV/5RXGyelKuZv1kjgx61I+Givjx9pRl X1ZU8Q7u6Y3ffLMmB/QqeQhdid0epSrv3iVonZgZbULIO8AerYVKzcxrNBvHn3gLm9hV 00nQ== X-Gm-Message-State: AOAM53255O07OCrM/HMDf1ma60jJ2QviFyjBCGijiQmLwSpcf7khnsed fsOjidApPkzJqXNKJKq5M1PF5Osxy9aF1v52clntF2JJ X-Google-Smtp-Source: ABdhPJwUnkXS5ZDyebNyyl9E09qanONwBziWQZDyN5cunvYcZ5LkuQ4Slls7XKMxcbBczBUTqNu1sjAESsqir6hL/5E= X-Received: by 2002:aa7:8283:0:b0:49f:a0d0:abcf with SMTP id s3-20020aa78283000000b0049fa0d0abcfmr9081575pfm.70.1639015310656; Wed, 08 Dec 2021 18:01:50 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 8 Dec 2021 18:01:50 -0800 In-Reply-To: <87o861k3x9.fsf@a16n.net> ("Peter =?UTF-8?Q?M=C3=BCnster?="'s message of "Tue, 30 Nov 2021 17:24:02 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221973 Archived-At: Peter M=C3=BCnster writes: > I'm a bit confused about > image-dired-cmd-create-standard-thumbnail-options: > > - It seems, that it's not used with pngcrush or pngnq, so this test is > perhaps useless: > (unless (or image-dired-cmd-pngcrush-program > image-dired-cmd-pngnq-program) ... I think the intention is that we shouldn't insert those text fields twice. See the removed code in commit 36b9973dec65 and also `image-dired-cmd-pngcrush-options'. Perhaps we could make this unconditional, but then what should we do about `image-dired-cmd-pngcrush-options'? Should the options be removed from there? > - If gm is used, then the "convert" command should be added. Yes, I think you are right.