unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 47047@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
Subject: bug#47047: 28.0.50; 'help-key-binding' face's background sub-optimal
Date: Sat, 13 Mar 2021 13:25:10 -0600	[thread overview]
Message-ID: <CADwFkmnqG9bidTJcpFt2M78UEqTipiiVdNqsuK7kmaWZaaxxVA@mail.gmail.com> (raw)
In-Reply-To: <CADwFkmkzUK3wfyYLY6tCJFWMNSL2o8EkC1JQnfab1W7RSQdb+w@mail.gmail.com> (Stefan Kangas's message of "Sat, 13 Mar 2021 13:01:23 -0600")

Stefan Kangas <stefan@marxist.se> writes:

> It is of course impossible to find a default background colour that will
> work with any colour.  The default was designed to work well with our
> default white background.

I tested with all our bundled themes, and the only theme in which the
default looked out of place to me was wombat.el and light-blue-theme.el.

I have updated wombat.el with a new face definition that seems more in
line with the rest of that theme.  If anyone wants to tweak it even
further, please feel free.

Unfortunately, I don't understand what style light-blue-theme.el is
trying to achieve, so I left it alone.  Perhaps Drew will have some idea
what, if anything, should be done in that case.





  reply	other threads:[~2021-03-13 19:25 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 13:40 bug#47047: 28.0.50; 'help-key-binding' face's background sub-optimal Eli Zaretskii
2021-03-10 19:59 ` Juri Linkov
2021-03-10 20:06   ` Eli Zaretskii
2021-03-13 19:01     ` Stefan Kangas
2021-03-13 19:25       ` Stefan Kangas [this message]
2021-03-14  3:00         ` bug#47047: [External] : " Drew Adams
2021-03-14  3:39           ` Stefan Kangas
2021-09-28 17:46           ` Stefan Kangas
2021-09-28 20:26             ` bug#47047: [External] : " Drew Adams
2021-09-28 20:54               ` Stefan Kangas
2021-09-28 22:13                 ` Drew Adams
2021-09-29 15:57             ` Lars Ingebrigtsen
2021-09-29 16:52               ` Stefan Kangas
2021-09-29 16:56                 ` Lars Ingebrigtsen
2021-09-29 17:24                   ` Stefan Kangas
2021-09-30  6:22                     ` Lars Ingebrigtsen
2021-10-03  0:24                       ` Stefan Kangas
2021-10-03  9:05                         ` Lars Ingebrigtsen
2021-09-29 17:34               ` bug#47047: [External] : " Drew Adams
2021-09-29 19:18                 ` Stefan Kangas
2021-09-29 19:50                   ` Drew Adams
2021-09-29 21:17                     ` Stefan Kangas
2021-09-29 22:21                       ` Drew Adams
2021-09-29 23:21                         ` Stefan Kangas
2021-09-30  1:59                           ` Drew Adams
2021-09-28 17:31         ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmnqG9bidTJcpFt2M78UEqTipiiVdNqsuK7kmaWZaaxxVA@mail.gmail.com \
    --to=stefan@marxist.se \
    --cc=47047@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).