unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: john muhl <jm@pub.pink>, Eshel Yaron <me@eshelyaron.com>
Cc: 66466-done@debbugs.gnu.org
Subject: bug#66466: [PATCH] Support lua-ts-mode in align.el
Date: Sat, 21 Oct 2023 03:27:19 -0700	[thread overview]
Message-ID: <CADwFkmnoot3nZSuayELR+xTa43JL+6QQjHJLnX+7x0BLSRtgAg@mail.gmail.com> (raw)
In-Reply-To: <87wmvnx5fi.fsf@pub.pink>

Version: 30.1

john muhl <jm@pub.pink> writes:

>> Also, I noticed that we already have several similar rules for aligning
>> assignments and comments in `align-rules-list`.  Do none of them work
>> for Lua?
>
> The toml-assignment rule works well enough. I added the Lua modes there
> now.
>
>> If so, I wonder what specifics of Lua's syntax make the existing rules
>> inapplicable.
>
> For comments I only see the open-comment and c++-comment rules.
> open-comment doesn’t match trailing line comments. Extending c++-comment
> in the obvious way (Lua uses "--" for comment start) causes trouble with
> c++ code like:
>
>   int x = 5; // declare
>   x--; // decrement
>
> Lua shares comment syntax with at least Ada, Haskell, SQL and VHDL so I
> changed the name of the rule to double-dash-comment and added the Lua
> modes there.

Thanks, installed on master.

[1: a838bcb23c6]: 2023-10-21 12:25:25 +0200
  Support lua-ts-mode in align.el
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=a838bcb23c60fe5bd29a1013a8c75796420ee461





  reply	other threads:[~2023-10-21 10:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11 16:57 bug#66466: [PATCH] Support lua-ts-mode in align.el john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-12  7:35 ` Stefan Kangas
2023-10-12  8:36   ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-12 11:20     ` Stefan Kangas
2023-10-14  2:19     ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-21 10:27       ` Stefan Kangas [this message]
2023-10-13  3:13   ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-15 14:25     ` Stefan Kangas
2023-10-15 14:59       ` Philip Kaludercic
2023-10-15 15:18         ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmnoot3nZSuayELR+xTa43JL+6QQjHJLnX+7x0BLSRtgAg@mail.gmail.com \
    --to=stefankangas@gmail.com \
    --cc=66466-done@debbugs.gnu.org \
    --cc=jm@pub.pink \
    --cc=me@eshelyaron.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).