From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#74983: [PATCH] Use `keymap-set' instead of `define-key' in emacs lisp intro Date: Fri, 20 Dec 2024 04:35:30 -0500 Message-ID: References: <20241219223632.37894-1-hong@topbug.net> <86pllmkfcm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22277"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74983@debbugs.gnu.org To: Eli Zaretskii , Hong Xu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 20 10:37:33 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tOZRt-0005b0-JI for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Dec 2024 10:37:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOZRR-0002Az-Db; Fri, 20 Dec 2024 04:37:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOZRO-0002An-UB for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2024 04:37:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOZRO-0000Ab-EJ for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2024 04:37:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:MIME-Version:References:In-Reply-To:From:To:Subject; bh=xOGCLSDwkP2rhQVLG5magfnz+rKHyixKA9Nfc4Pe4LI=; b=e7S6Avt5d6O4ehO+gLOrV+geYRl7XDj9rptsUfAgYu1XBPRT6mCjMu8HQWeHM60IUwNa0owGA3rlmSmwXgBMiB5W7/n6aeQUAWHkt8iJDyxjc2DZqAhXavzsx9Rp2BzbmB4ec0wTfie96xz+Ge88Jdp/MqQUtHLl2rylF7yhUTw3/qHXSh1vD5WjXYnNKpAsfjz+SqnvNzVIntcLKV/XjhmrT51gwbcpKfJZgYpQpvNuXWHrtlP9inkySOoREalhGjNu+x57GhV/NiWflb9c2gaiqZ+2YAJ88lWvdjeFQ7Jc/44BqiS19zJgwP051y18+plafAm8OyI13P1OEJ8xvQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tOZRO-0006O9-2o for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2024 04:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Dec 2024 09:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74983 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74983-submit@debbugs.gnu.org id=B74983.173468739924519 (code B ref 74983); Fri, 20 Dec 2024 09:37:02 +0000 Original-Received: (at 74983) by debbugs.gnu.org; 20 Dec 2024 09:36:39 +0000 Original-Received: from localhost ([127.0.0.1]:41697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOZR1-0006NP-1a for submit@debbugs.gnu.org; Fri, 20 Dec 2024 04:36:39 -0500 Original-Received: from mail-ed1-f45.google.com ([209.85.208.45]:53715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOZQy-0006N7-Oz for 74983@debbugs.gnu.org; Fri, 20 Dec 2024 04:36:37 -0500 Original-Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5d7e527becaso2658261a12.3 for <74983@debbugs.gnu.org>; Fri, 20 Dec 2024 01:36:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734687331; x=1735292131; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=xOGCLSDwkP2rhQVLG5magfnz+rKHyixKA9Nfc4Pe4LI=; b=aHO1X2O/3keSJCsYTrf4cIlAk1CdH8P8cpGPw/ZJAv2nEzR+kSxYZ1ESWaGdMEB29z 9xhMMGdpEiON4vBdT5Wj6PaMbCU1Ts0RBtyIb1/M9IybalJCLShcA0KXGek/MEUUOdEc PKkOnJWFK/9S7BE5QlQtdUfoLicuxiHrsUp7gOMMsOt7nEFlOpVFBsPLRDVhDXF9DwKp n4Q720dPhczCW+h2X5Ayckf3QETFx57ZY9jM3rrKmjl44XRpuv1YJa+huANa9cjXt4Vf VIAJJ46jgiJ+zUBgO7Ey6EC6yERRsdu1S3ITo+DsAUAdKL206npZ9yV2ylgqQIfP3WbB kCTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734687331; x=1735292131; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xOGCLSDwkP2rhQVLG5magfnz+rKHyixKA9Nfc4Pe4LI=; b=RKQynzGoqh98rzNGYe+k+g10f49T+PwHRwh8HNB1NN55G1tEnw/zoTwae6wEYcl1kZ K/KUXcOw8cpxsOWKyUPI8ZooiFkfP/J0F1QYlDJ/9hQmJGq2Zm2LR6df6awBBYdfmRJB uC7rJItLM8Jiq4GVcmLxzzQwhwqJIhn28wqZ7dWoph/YevDwkozlMjavc95acS4DuN9v lezkNDqj6K1gQipswFJq2GZXpocA05UXAPGWRcyaI2Kdjb1JZWdOaN5kcKbixLOvvxAl mf4AcZ9QJ89mLaQKMFOt+ctgBOGRmf3xqJm6EjQYlUUfBxJZIBpOTellvDwPIsQKnua9 ewGg== X-Gm-Message-State: AOJu0YxNMylDrsKMmts5bd8W9G2ftIrdbLD/CrjM0dWgLxST1+A13EQr VG/NE5kcEVfD7qvqoNIOndZfj98MwDoP+JJgVu7omND2CMYUE7o2qJ9dUMP8meife8YvxOaz/9x d7v9Yg55jyIhr2hs53rue6EYKXI8= X-Gm-Gg: ASbGncvYDeBnMjitUkUe/wHdXnTVL8nOGRLuCxyj6AENQoC51C14WKYhgIYwNQbs96x WyG/tX6Pl3fRbSq4LudovBJFXJ6M+0OA2cgJx2ek= X-Google-Smtp-Source: AGHT+IFvwVr+tr7sx+L9N7CIQTFU339DEAR3AjcZ+LY0ZYQwdwLIfUfIV0izGe1OhZrYsS/Vnfg41Uos6QnaxiQ19Y8= X-Received: by 2002:a05:6402:5291:b0:5d2:7396:b0ed with SMTP id 4fb4d7f45d1cf-5d81ddb3ae6mr3980241a12.14.1734687330748; Fri, 20 Dec 2024 01:35:30 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 20 Dec 2024 04:35:30 -0500 In-Reply-To: <86pllmkfcm.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297447 Archived-At: Eli Zaretskii writes: >> From: Hong Xu >> Date: Thu, 19 Dec 2024 14:36:29 -0800 >> >> * Since `define-key' is considered legacy and we encourage `keymap-set' >> now. > > Thanks. But the second chunk is not really right, since we have many > more define-key there than keymap-set. > > So my suggestion is not to _replace_ define-key with keymap-set, but > instead describe _both_, explaining that as of Emacs 29 we are > migrating towards keymap-set, which is preferred. > > Stefan, WDYT? I'd tend to agree. Users will have to recognize define-key for a long time indeed, not just in our sources (which are relatively easily fixable in comparison) but also in online forums, third-party packages, and so on. I didn't yet look at the patch though.