From: Stefan Kangas <stefankangas@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: luangruo@yahoo.com, 71669-done@debbugs.gnu.org
Subject: bug#71669: 30.0.50; macOS: `emacs --geometry` flag broken, only `-geometry` works
Date: Fri, 21 Jun 2024 18:09:00 +0000 [thread overview]
Message-ID: <CADwFkmnkcZ5qP24kg+zGEi_w1vffpnh1Y3wLnhiV3zNCwS2aig@mail.gmail.com> (raw)
In-Reply-To: <861q4qn6ui.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
> Not necessarily. My reading of the VC history is that before commit
> d7d8c62a57e7, which unified the NS handling of command-line arguments
> with the rest of GUI platforms, there was no support for -g (in any of
> its forms, including -geometry and --geometry) on macOS. So it could
> be that the fact we now support -g and -geometry is a bug.
In d7d8c62a57e7 it was actually still commented out. Proper support was
only added 4 years later, in commit e543ae917.
The fact that "--geometry" wasn't commented out at the time looks like
it was just an oversight.
> If you add --geometry to command-line-ns-option-alist, does it work as
> expected, with all formats of -geometry that are supposed to be
> supported? If yes, we could enable that on macOS and see if anything
> breaks or someone complains. But maybe if you try this, you will find
> the reason why this switch is not fully supported on NS.
It works fine, so I pushed a patch to master. Closing this now, thanks.
prev parent reply other threads:[~2024-06-21 18:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 7:51 bug#71669: 30.0.50; macOS: `emacs --geometry` flag broken, only `-geometry` works Stefan Kangas
2024-06-20 14:14 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-20 16:15 ` Stefan Kangas
2024-06-21 1:22 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-21 1:43 ` Stefan Kangas
2024-06-21 6:32 ` Eli Zaretskii
2024-06-21 18:09 ` Stefan Kangas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmnkcZ5qP24kg+zGEi_w1vffpnh1Y3wLnhiV3zNCwS2aig@mail.gmail.com \
--to=stefankangas@gmail.com \
--cc=71669-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).