From: Stefan Kangas <stefan@marxist.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 42889@debbugs.gnu.org
Subject: bug#42889: 28.0.50; make-pointer-invisible t should work also for navigation commands
Date: Wed, 20 Oct 2021 08:07:32 -0700 [thread overview]
Message-ID: <CADwFkmnkRERVHg1UwjZoUtQh09wG_6gLuxXEZb-AOe_J+GRQjw@mail.gmail.com> (raw)
In-Reply-To: <834kp0f08c.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 18 Aug 2020 18:21:55 +0300")
[-- Attachment #1: Type: text/plain, Size: 678 bytes --]
tags 42889 + patch
thanks
Eli Zaretskii <eliz@gnu.org> writes:
>> Date: Mon, 17 Aug 2020 19:56:40 +0300
>> From: Eli Zaretskii <eliz@gnu.org>
>> Cc: 42889@debbugs.gnu.org
>>
>> I actually thought about something more direct: force
>> note_mouse_highlight return early before highlighting anything, when a
>> certain variable is non-nil (that variable could be f->pointer_invisible).
>
> Btw, please take a look at the variable mouse-highlight: doesn't it
> already provide support for the feature being sought here?
Yes, I think it does. I think this is strictly a documentation bug
then, thanks for pointing it out.
I guess the attached patch should be okay for emacs-28.
[-- Attachment #2: 0001-Refer-to-mouse-highlight-from-make-pointer-invisible.patch --]
[-- Type: text/x-diff, Size: 1075 bytes --]
From 8da55ed988d59f95426da2f8d9af6efe7bbd740c Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefan@marxist.se>
Date: Wed, 20 Oct 2021 16:53:44 +0200
Subject: [PATCH] Refer to mouse-highlight from make-pointer-invisible
docstring
* src/frame.c (syms_of_frame) <Vmake_pointer_invisible>: Doc fix;
add reference to 'mouse-highlight'. (Bug#42889)
---
src/frame.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/frame.c b/src/frame.c
index f95566818a..2b1cb452ef 100644
--- a/src/frame.c
+++ b/src/frame.c
@@ -6238,7 +6238,10 @@ syms_of_frame (void)
DEFVAR_LISP ("make-pointer-invisible", Vmake_pointer_invisible,
doc: /* If non-nil, make mouse pointer invisible while typing.
-The pointer becomes visible again when the mouse is moved. */);
+The pointer becomes visible again when the mouse is moved.
+
+When using this, you might also want to disable highlighting of
+clickable text. See `mouse-highlight'. */);
Vmake_pointer_invisible = Qt;
DEFVAR_LISP ("move-frame-functions", Vmove_frame_functions,
--
2.30.2
next prev parent reply other threads:[~2021-10-20 15:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-16 14:12 bug#42889: 28.0.50; make-pointer-invisible t should work also for navigation commands Stefan Kangas
2020-08-16 14:54 ` Eli Zaretskii
2020-08-17 15:34 ` Stefan Kangas
2020-08-17 16:56 ` Eli Zaretskii
2020-08-18 15:21 ` Eli Zaretskii
2021-10-20 15:07 ` Stefan Kangas [this message]
2021-10-20 16:20 ` Eli Zaretskii
2021-10-20 16:40 ` Stefan Kangas
2021-08-27 17:51 ` Lars Ingebrigtsen
2021-10-20 14:52 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmnkRERVHg1UwjZoUtQh09wG_6gLuxXEZb-AOe_J+GRQjw@mail.gmail.com \
--to=stefan@marxist.se \
--cc=42889@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).