From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#49722: 27.2; Emacs won't build with old versions of fontconfig Date: Fri, 5 Nov 2021 07:14:10 -0700 Message-ID: References: <87k0lg115s.fsf@163.com> <83zguby8fd.fsf@gnu.org> <87o8arz00o.fsf@163.com> <838s1uyjuy.fsf@gnu.org> <87im0yzl7h.fsf@163.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24913"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 49722@debbugs.gnu.org To: Andrei Kuznetsov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 05 15:15:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mj004-0006HG-Ak for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Nov 2021 15:15:24 +0100 Original-Received: from localhost ([::1]:53638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mj003-0001qu-8Q for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Nov 2021 10:15:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mizzi-0001qX-RN for bug-gnu-emacs@gnu.org; Fri, 05 Nov 2021 10:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35183) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mizzi-0002Bs-J6 for bug-gnu-emacs@gnu.org; Fri, 05 Nov 2021 10:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mizzi-0007eT-AV for bug-gnu-emacs@gnu.org; Fri, 05 Nov 2021 10:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Nov 2021 14:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49722 X-GNU-PR-Package: emacs Original-Received: via spool by 49722-submit@debbugs.gnu.org id=B49722.163612166229345 (code B ref 49722); Fri, 05 Nov 2021 14:15:02 +0000 Original-Received: (at 49722) by debbugs.gnu.org; 5 Nov 2021 14:14:22 +0000 Original-Received: from localhost ([127.0.0.1]:46728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mizz3-0007dF-Rl for submit@debbugs.gnu.org; Fri, 05 Nov 2021 10:14:22 -0400 Original-Received: from mail-pg1-f170.google.com ([209.85.215.170]:39527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mizz1-0007cn-V2 for 49722@debbugs.gnu.org; Fri, 05 Nov 2021 10:14:20 -0400 Original-Received: by mail-pg1-f170.google.com with SMTP id g184so8494071pgc.6 for <49722@debbugs.gnu.org>; Fri, 05 Nov 2021 07:14:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc :content-transfer-encoding; bh=SVGRLVyJc35thK1MKIYjHNajJJjYHRe5RooWJ12VYNM=; b=xfieKselGy8pe4NtxGveLxiv4Ujs/NSvDce38VZ6VckmQhf/mXWY0/Ggf7tZ7MtEtS mvqejNCWrY2BdrQgodAp7MXPxlOqWJNxbtkl9Oela81uX+q2+O3bbfvuZ1j6b5AZ9Jbj OTqgF/uJTvA9skjyfA0WhIsN5dI3SHHW9i/X5qMUmY5whxK4ySr8AyWYvu+GHlGggx3p d5XmiPF4GhSV3CeHb9ZmpBZ8TCrD0WWCWo2r9SQqPJxl9l4ShahzAxZUz4TOU6hVpdXo htLosDHlSa7UIojtBr7Es7TeCHScK3eQzffyXV3tnwbsJBFN90xfHoruBgT1VlNQX35z O3Dw== X-Gm-Message-State: AOAM531zfP0OXL3nI1jnAcZOuys9EE634DxwSi5nUmddpJqsEZHdD44G KNl/PTILA/ktv/q5nccOUsUuDgXq1P8cSB32k+0= X-Google-Smtp-Source: ABdhPJw5c4ycEbr0NxoLWHVo9khsPEf6PMWVIiYH0eSHfGphBj8cgsvSwDkM34SlnwTBjy3RJlTuO7dZUuiofc8mBnI= X-Received: by 2002:a05:6a00:244d:b0:44d:c279:5155 with SMTP id d13-20020a056a00244d00b0044dc2795155mr59104283pfj.0.1636121650873; Fri, 05 Nov 2021 07:14:10 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 5 Nov 2021 07:14:10 -0700 In-Reply-To: <87im0yzl7h.fsf@163.com> (Andrei Kuznetsov's message of "Sun, 25 Jul 2021 19:28:34 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219003 Archived-At: close 49722 28.1 thanks Eli Zaretskii writes: >> xftfont.c: In function =E2=80=98xftfont_cached_font_ok=E2=80=99: >> xftfont.c:591: error: =E2=80=98FC_LCD_FILTER=E2=80=99 undeclared (first = use in this function) >> xftfont.c:591: error: (Each undeclared identifier is reported only once >> xftfont.c:591: error: for each function it appears in.) >> >> It appears that FC_LCD_FILTER is not present on these older versions of >> fontconfig. > > Thanks. We once had the following in xftfont.c: > > #ifndef FC_LCD_FILTER > /* Older fontconfig versions don't have FC_LCD_FILTER. */ > #define FC_LCD_FILTER "lcdfilter" > #endif > > But it got moved to ftfont.c when a function which used it was moved > there. However, since xftfont.c still uses this, I think we should > have this #define in xftfont.c as well, so please try adding that at > the beginning of xftfont.c, and see if that helps. Andrei Kuznetsov writes: > Indeed it does. With the aformentioned change, Emacs now builds and > seems to operate normally. The fix was installed, so I'm closing this bug report. commit 41a55a330f518254da795719ac6e3085254d4110 Author: Eli Zaretskii Date: Sun Jul 25 15:50:46 2021 +0300 Fix compilation of xftfont.c with old fontconfig * src/xftfont.c (FC_LCD_FILTER): Define if undefined, for older versions of fontconfig. This was mistakenly deleted 2 years ago. (Bug#49722)