From: Stefan Kangas <stefan@marxist.se>
To: Andrei Kuznetsov <r12451428287@163.com>
Cc: 49722@debbugs.gnu.org
Subject: bug#49722: 27.2; Emacs won't build with old versions of fontconfig
Date: Fri, 5 Nov 2021 07:14:10 -0700 [thread overview]
Message-ID: <CADwFkmnhWt0UD+a+rxo579iP8n6oqZUcG5fhjKaKCH5g2nyk-Q@mail.gmail.com> (raw)
In-Reply-To: <87im0yzl7h.fsf@163.com> (Andrei Kuznetsov's message of "Sun, 25 Jul 2021 19:28:34 +0800")
close 49722 28.1
thanks
Eli Zaretskii <eliz@gnu.org> writes:
>> xftfont.c: In function ‘xftfont_cached_font_ok’:
>> xftfont.c:591: error: ‘FC_LCD_FILTER’ undeclared (first use in this function)
>> xftfont.c:591: error: (Each undeclared identifier is reported only once
>> xftfont.c:591: error: for each function it appears in.)
>>
>> It appears that FC_LCD_FILTER is not present on these older versions of
>> fontconfig.
>
> Thanks. We once had the following in xftfont.c:
>
> #ifndef FC_LCD_FILTER
> /* Older fontconfig versions don't have FC_LCD_FILTER. */
> #define FC_LCD_FILTER "lcdfilter"
> #endif
>
> But it got moved to ftfont.c when a function which used it was moved
> there. However, since xftfont.c still uses this, I think we should
> have this #define in xftfont.c as well, so please try adding that at
> the beginning of xftfont.c, and see if that helps.
Andrei Kuznetsov <r12451428287@163.com> writes:
> Indeed it does. With the aformentioned change, Emacs now builds and
> seems to operate normally.
The fix was installed, so I'm closing this bug report.
commit 41a55a330f518254da795719ac6e3085254d4110
Author: Eli Zaretskii <eliz@gnu.org>
Date: Sun Jul 25 15:50:46 2021 +0300
Fix compilation of xftfont.c with old fontconfig
* src/xftfont.c (FC_LCD_FILTER): Define if undefined, for older
versions of fontconfig. This was mistakenly deleted 2 years ago.
(Bug#49722)
prev parent reply other threads:[~2021-11-05 14:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 10:01 bug#49722: 27.2; Emacs won't build with old versions of fontconfig Andrei Kuznetsov
2021-07-24 16:37 ` Eli Zaretskii
2021-07-25 0:53 ` Andrei Kuznetsov
2021-07-25 6:43 ` Eli Zaretskii
2021-07-25 11:28 ` Andrei Kuznetsov
2021-11-05 14:14 ` Stefan Kangas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmnhWt0UD+a+rxo579iP8n6oqZUcG5fhjKaKCH5g2nyk-Q@mail.gmail.com \
--to=stefan@marxist.se \
--cc=49722@debbugs.gnu.org \
--cc=r12451428287@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).