From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#4804: 23.1; bookmark-bmenu-bookmark performances Date: Sun, 30 Jun 2019 03:09:45 +0200 Message-ID: References: <87my3fzx7l.fsf@tux.homenetwork> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="135059"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 4804@debbugs.gnu.org, Thierry Volpiatto To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 30 03:11:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hhON3-000YzM-Qe for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Jun 2019 03:11:09 +0200 Original-Received: from localhost ([::1]:42622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhON2-00034t-5a for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Jun 2019 21:11:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51687) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhOMx-00034h-AB for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2019 21:11:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hhOMw-0002vf-7p for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2019 21:11:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59804) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hhOMw-0002vT-3f for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2019 21:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hhOMv-0003kj-TF for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2019 21:11:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87my3fzx7l.fsf@tux.homenetwork> Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jun 2019 01:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4804 X-GNU-PR-Package: emacs Original-Received: via spool by 4804-submit@debbugs.gnu.org id=B4804.156185700814361 (code B ref 4804); Sun, 30 Jun 2019 01:11:01 +0000 Original-Received: (at 4804) by debbugs.gnu.org; 30 Jun 2019 01:10:08 +0000 Original-Received: from localhost ([127.0.0.1]:45115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhOM4-0003jZ-6n for submit@debbugs.gnu.org; Sat, 29 Jun 2019 21:10:08 -0400 Original-Received: from mail-wr1-f50.google.com ([209.85.221.50]:40802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhOLz-0003ii-8R for 4804@debbugs.gnu.org; Sat, 29 Jun 2019 21:10:04 -0400 Original-Received: by mail-wr1-f50.google.com with SMTP id p11so10001181wre.7 for <4804@debbugs.gnu.org>; Sat, 29 Jun 2019 18:10:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=1Y/dPhqYMXcyhtD2MxV52SKb/lLX5de43IMp0kcB94U=; b=r7g21AScHVSpQogVW3rnrBSIlt4tduqc6MOoUCqY1/jLq/L7QM7OPedCb1KKD3GxuD dczMnH6E0AvY9eL4UjPHoSV+3mKpFLA0CAR8d1ceVItNujF6sjh52eSbQyU2vB9m+NfC i9zeAVw401DVG854eEmFAYfbOOU2IRlm1rPraE3XIc7buy9IL9YacVp/JV691XU4G7Vf V2y3eBN46rZ70PlW0vXHpi0qhjq+6kskPD4aHADt4l3wXaXLszc6l5oPWkJ+J19orxi7 OBEt1HhTF2Xbh4gQn3fB14JSTPJUtZdTJfwOa0AL89e7uWDSXY3/F+80sfeoDGuI0nV0 w6sQ== X-Gm-Message-State: APjAAAV0lu171Qzm+qjkVjrAoY02l3ompF020YzGcvGGcS2kE63Wh7V9 2KOY9oez1jbE4M3gcuWleJrUIWkZst/czefz+K4= X-Google-Smtp-Source: APXvYqyH3MUz4mh4rljHvHGYUa60EoYNVSKTnzARLsif/uVO2WaQxIx5EIj66ZRTPCLGmJjHmQF2cIbRGBQ0B2B3mes= X-Received: by 2002:a5d:66d2:: with SMTP id k18mr11358096wrw.85.1561856997299; Sat, 29 Jun 2019 18:09:57 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161851 Archived-At: tags 4804 fixed close 4804 23.2 quit Stefan Monnier writes: >> 1) run a loop on all menu list to toggle filenames visibility. >> 2) come back to the original place and get bookmark name with >> buffer-substring >> 3) run again a loop to toggle filenames visibility back. >> That's very costly. > > Agreed, it's costly, brittle, and ugly. > > But your solution relies on a correspondance between > bookmark-latest-sorted-alist and the buffer's content, even though this > correspondance is nowhere enforced (i.e. future changes to the code are > likely to break it, or manual buffer modifications could also break it). > > Much easier and more robust would be to put the relevant data directly > in the buffer in the form of text-properties, so it can be extracted > directly via get-text-property regardless of whether the filenames > are hidden. > > > Stefan This was subsequently implemented by Stefan Monnier: fc9d6ad645ab0332811bcd7b79341f68ddd958e8 2009-11-21 06:43:45 +0000 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=fc9d6ad645ab0332811bcd7b79341f68ddd958e8 I'm therefore closing this bug report. Thanks, Stefan Kangas