unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 4804@debbugs.gnu.org, Thierry Volpiatto <thierry.volpiatto@gmail.com>
Subject: bug#4804: 23.1; bookmark-bmenu-bookmark performances
Date: Sun, 30 Jun 2019 03:09:45 +0200	[thread overview]
Message-ID: <CADwFkmngp-wEiAsWLvunB=O-pFXdSG_aHNUG-vXZ24U_66ChRg@mail.gmail.com> (raw)
In-Reply-To: <87my3fzx7l.fsf@tux.homenetwork>

tags 4804 fixed
close 4804 23.2
quit

Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> 1) run a loop on all menu list to toggle filenames visibility.
>> 2) come back to the original place and get bookmark name with
>> buffer-substring
>> 3) run again a loop to toggle filenames visibility back.
>> That's very costly.
>
> Agreed, it's costly, brittle, and ugly.
>
> But your solution relies on a correspondance between
> bookmark-latest-sorted-alist and the buffer's content, even though this
> correspondance is nowhere enforced (i.e. future changes to the code are
> likely to break it, or manual buffer modifications could also break it).
>
> Much easier and more robust would be to put the relevant data directly
> in the buffer in the form of text-properties, so it can be extracted
> directly via get-text-property regardless of whether the filenames
> are hidden.
>
>
>         Stefan

This was subsequently implemented by Stefan Monnier:

fc9d6ad645ab0332811bcd7b79341f68ddd958e8
2009-11-21 06:43:45 +0000
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=fc9d6ad645ab0332811bcd7b79341f68ddd958e8

I'm therefore closing this bug report.

Thanks,
Stefan Kangas





      parent reply	other threads:[~2019-06-30  1:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-25  8:36 bug#4804: 23.1; bookmark-bmenu-bookmark performances Thierry Volpiatto
2009-10-25 15:12 ` Stefan Monnier
2019-06-30  1:09 ` Stefan Kangas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmngp-wEiAsWLvunB=O-pFXdSG_aHNUG-vXZ24U_66ChRg@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=4804@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=thierry.volpiatto@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).