From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#50752: 28.0.50; easy-menu-define lowers the menu-bar key Date: Tue, 26 Oct 2021 22:24:10 +0200 Message-ID: References: <87ee8hfajg.fsf@gnus.org> <838rypc98p.fsf@gnu.org> <87h7ddc8iy.fsf@gnus.org> <831r4hc7ta.fsf@gnu.org> <878rypc7e8.fsf@gnus.org> <83zgr5asej.fsf@gnu.org> <8735oxc51n.fsf@gnus.org> <83wnm8c3v3.fsf@gnu.org> <87tuhcc1u1.fsf@gnus.org> <83tuhcaqad.fsf@gnu.org> <881r4fq5b8.fsf@fencepost.gnu.org> <87tuh5z22g.fsf@gnus.org> <83r1c91bu1.fsf@gnu.org> <878ryhz1cb.fsf@gnus.org> <83o87d1acw.fsf@gnu.org> <87h7d5xl8o.fsf@gnus.org> <83lf2h19cn.fsf@gnu.org> <83ee88ym1q.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28462"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rgm@gnu.org, larsi@gnus.org, 50752@debbugs.gnu.org, shuguang79@qq.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 26 22:25:58 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfT1B-0007AT-Lc for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Oct 2021 22:25:57 +0200 Original-Received: from localhost ([::1]:47554 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mfT1A-0003IZ-La for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Oct 2021 16:25:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51996) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfT0K-0003Gd-8K for bug-gnu-emacs@gnu.org; Tue, 26 Oct 2021 16:25:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36097) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mfT0I-0005iN-Rc for bug-gnu-emacs@gnu.org; Tue, 26 Oct 2021 16:25:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mfT0I-0005Ep-MM for bug-gnu-emacs@gnu.org; Tue, 26 Oct 2021 16:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Oct 2021 20:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50752 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50752-submit@debbugs.gnu.org id=B50752.163527985920053 (code B ref 50752); Tue, 26 Oct 2021 20:25:02 +0000 Original-Received: (at 50752) by debbugs.gnu.org; 26 Oct 2021 20:24:19 +0000 Original-Received: from localhost ([127.0.0.1]:47639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfSza-0005DM-RB for submit@debbugs.gnu.org; Tue, 26 Oct 2021 16:24:19 -0400 Original-Received: from mail-pg1-f176.google.com ([209.85.215.176]:46857) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mfSzY-0005D5-Tw for 50752@debbugs.gnu.org; Tue, 26 Oct 2021 16:24:17 -0400 Original-Received: by mail-pg1-f176.google.com with SMTP id m21so604950pgu.13 for <50752@debbugs.gnu.org>; Tue, 26 Oct 2021 13:24:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=JY6GeksYTPrZoH2juLjspgK6/hpHYRHPQGijw8Ny2Sk=; b=1r6WCtC1Yb2VnoZc7jxMZ0Aoh3gPEmu4/ZZQMxBOIJ53drLxVbl2PLIrtvDCFqcyu2 llmsljJt4M+pFZVTImOcsPzCPbZESEgSEwdCQywTTz6GMZSeBpOXQ1wX8GSTOKwjt3Im 3WYTDjOAOozwhxeKY0F/CAogJLKYGWbvd+NEwTlMmLGF7LsmXVc5yh52cwDeJ24AJy8W tTgK86tYvcRR44SzoGvmoIuN0EmF4cctRwwTDboNrvFlNqVhsLu6OkSS68uhKQ6dAtr5 YE2ccK7OqKE/UGg4HHyu9MYv4iWOFsg63/v4DmjpPsE+ExARRBZJat7qtSLE2ctfX8g/ XFKg== X-Gm-Message-State: AOAM532d7cjMtQin0UZr1OnLDyccqjy9P0JExMVh47WKK9aQ1xpuGKNQ 4wxBI9GHcKWOtYEjDZ9D2MmiB8sJkJ9PnUrf8sU= X-Google-Smtp-Source: ABdhPJwCsaDrnRCB+lbnCU5p6su2QXpdf97KupBmN8Nyqj31Sa19R1W92YatV3Abqlz8lQaWqSEWEn3LdwBXYbLKRZY= X-Received: by 2002:aa7:99c3:0:b0:47b:e21d:7315 with SMTP id v3-20020aa799c3000000b0047be21d7315mr20421326pfi.35.1635279851252; Tue, 26 Oct 2021 13:24:11 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 26 Oct 2021 22:24:10 +0200 In-Reply-To: <83ee88ym1q.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218406 Archived-At: Eli Zaretskii writes: > Unfortunately, I meant neither of these two, because they both are > quite non-trivial. I meant a much simpler patch which only downcases > ASCII letters, and that's all. Such a change doesn't need to call > Fdowncase, and definitely doesn't need to futz with multibyte > characters. It should be a simple copy and a single loop downcasing > the characters. (The NEWS entry for emacs-28 should thus say that we > only handle this simple class of problems.) OK, let me just double check that you mean to memcpy and then just loop over the memory byte by bite and update them like so: int new_ch = XFIXNUM (CHAR_TABLE_REF (Vascii_downcase_table, ch)) Or do you mean something even simpler like this? if (ch >= 'A' && ch <= 'Z') new_ch = c + ('A' - 'a'); > The log message should say "don't merge to master". Hmm. If we can live with a simpler fix on emacs-28, can we not live with it on master as well? Or at least live with it until we can evaluate if the simpler fix did the job well enough?