From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#13521: `sort-lines' on the empty region Date: Fri, 21 Aug 2020 00:15:31 -0700 Message-ID: References: <20130122085354.75ced82538551655e724e0ea@gmail.com> <83mu2objro.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22839"; mail-complaints-to="usenet@ciao.gmane.io" Cc: xfq.free@gmail.com, rgm@gnu.org, monnier@iro.umontreal.ca, 13521@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 21 09:16:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k91Hc-0005pq-Fg for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Aug 2020 09:16:16 +0200 Original-Received: from localhost ([::1]:47048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k91Hb-0000s7-Ee for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Aug 2020 03:16:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49496) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k91HO-0000rq-Cy for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 03:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33291) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k91HO-00052S-2x for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 03:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k91HN-0002e5-VG for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 03:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Aug 2020 07:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13521 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13521-submit@debbugs.gnu.org id=B13521.159799414010139 (code B ref 13521); Fri, 21 Aug 2020 07:16:01 +0000 Original-Received: (at 13521) by debbugs.gnu.org; 21 Aug 2020 07:15:40 +0000 Original-Received: from localhost ([127.0.0.1]:44837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k91H1-0002dT-PO for submit@debbugs.gnu.org; Fri, 21 Aug 2020 03:15:39 -0400 Original-Received: from mail-yb1-f178.google.com ([209.85.219.178]:44870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k91Gz-0002dG-EG for 13521@debbugs.gnu.org; Fri, 21 Aug 2020 03:15:38 -0400 Original-Received: by mail-yb1-f178.google.com with SMTP id i10so531019ybt.11 for <13521@debbugs.gnu.org>; Fri, 21 Aug 2020 00:15:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=8Tgqxf5GKWquARSqL3TWeRendG480gie9cmV6zZrcEA=; b=O3wCVUAbFZRjvaSpGFRGfP1diIxyramKbJyU3RpCLigByFhuqbmZxeCQjZxJ5cZ1Vd 3CNBeHOF4L62tDv1kb1+mUvBdJokhNSCPhb6rFbEwjJkIC37OkCowzkjBas34iZyxPg8 7ChnBVwFfWD4n5V2PN2qiNChF79zbbWJ0h3mQHHHf5ekfpzm4lPlMqain5C4zVjog2ls vxXPlh/cb4v1ganCZufogLy+yjJaVEp1mpbd+DA5rI3mw+hhIVkJn+s/DkybCOZtG7q4 aUJSCbR7sveer7xCdwLM7Hq7U60YDtBB6FqmnsOQ1H66SlE5OL+x3H+1ZzHN6lUuzXuc Cuhg== X-Gm-Message-State: AOAM530rpUy+nKo9kT/G5cplLXXttfrswX5fPlDn+cV8r2U7tfG0Q7je 8Ty4BFLbWyzUwFPKzSX8+7d1Ax+j0L6BjQuEGic= X-Google-Smtp-Source: ABdhPJxUcVtIz0r5/Nl3EjJZ3nA4JcxIyh2sJJ06EMwyQOEQvpAJOLIRzvo3GAFiNIOQCNe4yOuiJCn8Iq0vYdNkVLk= X-Received: by 2002:a25:b290:: with SMTP id k16mr1882779ybj.389.1597994131829; Fri, 21 Aug 2020 00:15:31 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 21 Aug 2020 00:15:31 -0700 In-Reply-To: <83mu2objro.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185817 Archived-At: Eli Zaretskii writes: >> The attached patch makes 'sort-lines' sort the entire buffer when there >> is no region. > > How frequently did you see a buffer in Emacs with no region in it? > IME, it takes about 2 commands since buffer creation to have a region > in it. So I predict users to be tripped by this feature quite a lot: > they will think there's no region, invoke the command, and get some > arbitrary region sorted. Requiring them to always provide the region > avoids this pitfall, since the user is forced to make sure the region > is where he or she wants it. And marking the whole buffer is just 2 > key-presses away. > > So I think this change will annoy more than help. Sorry, the correct terminology I should have used is "active region". This is as tested by `use-region-p'. Compare the test I introduce also to the one in `flush-lines', where I lifted it from. Best regards, Stefan Kangas