From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#60251: 29.0.60; Consider the language at point for tree sitter treesit-inspect-node-at-point Date: Tue, 5 Sep 2023 16:32:12 -0700 Message-ID: References: <87lemzes0b.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18216"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Yuan Fu , 60251@debbugs.gnu.org To: Wilhelm H Kirschbaum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 06 01:33:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdfXj-0004YW-VK for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Sep 2023 01:33:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdfXa-0003Qu-MP; Tue, 05 Sep 2023 19:33:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdfXZ-0003QX-ED for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 19:33:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdfXZ-0000Zv-4M for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 19:33:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qdfXZ-0002EW-Qc for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 19:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Sep 2023 23:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60251 X-GNU-PR-Package: emacs Original-Received: via spool by 60251-submit@debbugs.gnu.org id=B60251.16939567418525 (code B ref 60251); Tue, 05 Sep 2023 23:33:01 +0000 Original-Received: (at 60251) by debbugs.gnu.org; 5 Sep 2023 23:32:21 +0000 Original-Received: from localhost ([127.0.0.1]:59808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdfWv-0002DQ-25 for submit@debbugs.gnu.org; Tue, 05 Sep 2023 19:32:21 -0400 Original-Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]:53511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdfWt-0002DA-Ch for 60251@debbugs.gnu.org; Tue, 05 Sep 2023 19:32:20 -0400 Original-Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-50091b91a83so5096620e87.3 for <60251@debbugs.gnu.org>; Tue, 05 Sep 2023 16:32:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693956732; x=1694561532; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=NmZFcsWeOaf6pEo0UBL8Yx86jFxfnccnaa37iKzsNtE=; b=S9lVdK4h5l/rxjKi927BdIg9jrzprBKnBAsE2R81+Ax6qJwpisADzYWVT0ux+B/TaW OLt1UzRGCpkcdvsPSlyhoqK1LQQJORCkYNAnQL/Waz6tDStZqMffH7nXudxmMufQsjkt 77RvlE+/21MVmq+oMTKzAOfQ5xssImsLYPEzYJlxGoWc/aIyp+4wE/l9UvHxFUrBsbyZ OU9vt907A8dJYUnZt1IPJKis7ErTFPrkNPtPkoOJiB67xHHI2nlH6DWyMDtH9jOm3F1S dDyw/q41vD77x46AJ2cA9UlKs+d5hGYnw+FkvRYltfVxVB7sGkJ58QWxQ8ICEbNk4FJN ArWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693956732; x=1694561532; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NmZFcsWeOaf6pEo0UBL8Yx86jFxfnccnaa37iKzsNtE=; b=CHrXOE9R9hTV+yr65RLVn0AHoaNsnFhDr3hXuqzg1Fh/JkaZAZJPLUh1IzAHoyCOcB JTigNjPFp3bN2uM6sGXK1SDGnddVB+oawQRhEh9SFgVJNTFxEDUyVK+ZFROw7RB8LtY3 fxUZc8IfElpcBidZ7Koa3gfGXDGPl8N0UjJ0hEe1NNE1YGIPfNY6I5Cc0JaJ2EyKlFA8 0q/2JAWQdV6cT4icFU5MrZWYEJVir6lHwG39tN2+U+OME6j5kttd0MOatfVmI9fXOLkU 4J7g1ioelpEus46F3VgcEcwiMgqhAD/3+TC52QoR3PgbYBlstrAjFn8o2PI5+YoreM3M HuSw== X-Gm-Message-State: AOJu0Yx3oD+QS6W1PqqY2/nrwxpu9RKRknYCilq5n+Fq+hHXfK/X5Le0 4P8k1TXjnJsi8g9wux3Iwh8IdLAaKAX9cLcMrOw/Y9YRDyc= X-Google-Smtp-Source: AGHT+IGl6hFgnxmIrBLrvshSltawkSfrEaNXrYBq/0Yz4nCa2RIKwDRw0XhlPJLJmqIhwBfkHQxSqyKn9GUW5SYvkO8= X-Received: by 2002:a05:6512:443:b0:500:9de4:5966 with SMTP id y3-20020a056512044300b005009de45966mr802013lfk.62.1693956732524; Tue, 05 Sep 2023 16:32:12 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 5 Sep 2023 16:32:12 -0700 In-Reply-To: <87lemzes0b.fsf@gmail.com> (Wilhelm H. Kirschbaum's message of "Thu, 22 Dec 2022 10:42:03 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269430 Archived-At: Wilhelm H Kirschbaum writes: > The following change will make it possible to inspect a node when using > an embedded language, otherwise it will assume the first specified > language without allowing specifying the language. This assumes that > treesit-language-at-point-function has been correctly set. diff --git Yuan, do you have any comments on the below patch? Thanks in advance. > a/lisp/treesit.el b/lisp/treesit.el > index 6407669118..74dfd26776 100644 > --- a/lisp/treesit.el > +++ b/lisp/treesit.el > @@ -1931,7 +1931,7 @@ treesit-inspect-node-at-point > (interactive "p") > ;; NODE-LIST contains all the node that starts at point. > (let* ((node-list > - (cl-loop for node = (treesit-node-at (point)) > + (cl-loop for node = (treesit-node-at (point) (treesit-language-at > (point))) > then (treesit-node-parent node) > while node > if (eq (treesit-node-start node) > > > Another option might be to allow parser-or-lang as an argument, but > thinking that as an interactive function for debugging the above might > be more useful, but either way it does not seem possible to > inspect-node-at-point for multiple language configuration. > > Regards, > Wilhelm