From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds Date: Tue, 2 Nov 2021 07:41:43 -0700 Message-ID: References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37499"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Jim Porter , 51556@debbugs.gnu.org, kevin.legouguec@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 02 15:51:30 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mhv8M-0009Yp-2B for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Nov 2021 15:51:30 +0100 Original-Received: from localhost ([::1]:36828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhv8L-0008Ar-1h for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Nov 2021 10:51:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhv0A-0007lU-VD for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 10:43:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54449) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mhv0A-0000ke-Mq for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 10:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mhv0A-0004yY-Hq for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 10:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Nov 2021 14:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51556 X-GNU-PR-Package: emacs Original-Received: via spool by 51556-submit@debbugs.gnu.org id=B51556.163586412519046 (code B ref 51556); Tue, 02 Nov 2021 14:43:02 +0000 Original-Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 14:42:05 +0000 Original-Received: from localhost ([127.0.0.1]:37762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhuzF-0004x7-72 for submit@debbugs.gnu.org; Tue, 02 Nov 2021 10:42:05 -0400 Original-Received: from mail-pg1-f179.google.com ([209.85.215.179]:35338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhuyz-0004wI-Gh for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 10:42:04 -0400 Original-Received: by mail-pg1-f179.google.com with SMTP id p17so731123pgj.2 for <51556@debbugs.gnu.org>; Tue, 02 Nov 2021 07:41:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=0aW8ZagTp7ZJ8jZc9VHTtr9c1XeeNVULbnwflyadRBo=; b=dFjl+Yz7RqFY9bGaPre4Pg39vtIGp7K4QR9yB27PtsY/25VEyAVF6k+QxPEXKYW1iO ZwU5Q+H5imWu3HjwjoOYq9q4JuFIdH1gc9Ma63iESNbu0njDhyiHZBvCpFQ6KQT+vsrA HbUnv7/BRgPrmaeUL1xDuBr1zkJKNR2xkp3l2N7UB/acVhMFLAV+ofWWsFZncSwtwQnB wQtoUc92zHrCTkJroqmJkwogBVIQ15ToSzdYn4FuhAq66XEr4pjs9oW5pDPXLIHRLbY7 Fue0xqupgUde+unzaCC9AXCNz8XS9Sy2Gr+ux0LOjlIUQvP6TqlFICXWM7ZAXRJYhJYb wGQg== X-Gm-Message-State: AOAM531PMVCgYPQBIsz3I+EGQCrHh/eEyLcU8+szVdgWipQ+j1+jj6hw aDJhLZQau9+Ka52z8bLd5j6O9w57xNTRtY2Cdw4= X-Google-Smtp-Source: ABdhPJyL3i91jAtNF/P1yulsua2A1sh/YMCcXG4Lf3r1eg2x7KyT5CACDpL4IFdz1sVdCHACCx54htwkQH7YTRlTrQQ= X-Received: by 2002:a63:86c1:: with SMTP id x184mr18850049pgd.114.1635864103802; Tue, 02 Nov 2021 07:41:43 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 2 Nov 2021 07:41:43 -0700 In-Reply-To: <83a6imlo23.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 02 Nov 2021 14:49:56 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218808 Archived-At: Eli Zaretskii writes: > AFAIK, only the background color of the face will affect the display, > and that is not enough. Since a theme determines the looks, it should > also control the icons where that matters. As I have recently announced on emacs-devel, I am working on developing a library supporting icon sets. I think it is better to think of icons as orthogonal to the colors: this allows choosing any combination of icons and colors. For example, I might want to use the icons from some free set X, but I want to use it with all color themes. This will also allow color theme developers to simply say "this or that icon, whatever it is, should have this color", without having to provide a large amount of icons to get it right. Thinking about how to fix this in emacs-28, we discussed adding a face and just removing the foreground color from the svg. If we were add a face here, I think the more general customization that I hope we will introduce in Emacs 29.1 (read: if we accept my new library) would render that face ineffective. So it might not be worth it, I don't know. Perhaps something like that could wait for 29. The simplest solution for emacs-28 seems to simply remove the foreground color of that glyph, which IIUC (but I didn't test) should mean it will just use the foreground color of the current face in the customize buffer. Which should look okay in most cases, I think.