From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#64791: 30.0.50; [PATCH] Fix dired mismatch on some filenames Date: Tue, 5 Sep 2023 15:27:48 -0700 Message-ID: References: <87sf9gozbl.fsf@ledu-giraud.fr> <83fs5g8392.fsf@gnu.org> <87lef8ovgc.fsf@ledu-giraud.fr> <835y6c7yvo.fsf@gnu.org> <87ttsbbbfy.fsf@ledu-giraud.fr> <83zg235d47.fsf@gnu.org> <83wmx75aad.fsf@gnu.org> <83edje5e0s.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000000eef4e0604a4239a" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25797"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64791@debbugs.gnu.org, manuel@ledu-giraud.fr To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 06 00:28:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdeWy-0006Wp-RO for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Sep 2023 00:28:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdeWh-00084r-J3; Tue, 05 Sep 2023 18:28:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdeWg-000847-8Y for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 18:28:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdeWg-0003v4-0L for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 18:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qdeWg-0000V5-5s for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 18:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Sep 2023 22:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64791 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64791-submit@debbugs.gnu.org id=B64791.16939528791915 (code B ref 64791); Tue, 05 Sep 2023 22:28:02 +0000 Original-Received: (at 64791) by debbugs.gnu.org; 5 Sep 2023 22:27:59 +0000 Original-Received: from localhost ([127.0.0.1]:59741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdeWc-0000Un-N0 for submit@debbugs.gnu.org; Tue, 05 Sep 2023 18:27:59 -0400 Original-Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]:53440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdeWa-0000UY-GZ for 64791@debbugs.gnu.org; Tue, 05 Sep 2023 18:27:57 -0400 Original-Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-500cfb168c6so5033933e87.2 for <64791@debbugs.gnu.org>; Tue, 05 Sep 2023 15:27:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693952870; x=1694557670; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=XCK+Lzj1zYrguSEJLD5sde5pCP0xaJ1eTBxAhFmZk6Y=; b=bUGJNneQWtMng48FKtQQqLDJ6B52e10s4AADC333ksCalkmurD9e87aL3H9S4SXuAz 9uYk/X+ZUEJ7X5u2gYLJ8Rxf6DhQtTtDI2f4sFYg7hoCtSYKXEyN8oASkxrQp9qgX3nZ Qg2J2sMl3GzZv7Vb24H33GD7IYAkmXIOwZhSYmC8EwJwGqqQg8Xpfy5VrrDPSiS2BRNq RE6w2De7i9yOYWh0rp3qWb7/KaZVUwoO7iKFtvetjOC4UuDslBA+OCWllPnSjo8DTgFV 8KIyga3fvbZnjZ+qUlssWOAI/HQ43N2PgiOU34ZQzm9zzdL9eRji5q/pl08aYs+R8HqO G4Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693952870; x=1694557670; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XCK+Lzj1zYrguSEJLD5sde5pCP0xaJ1eTBxAhFmZk6Y=; b=fMSQ9tvErSIOPYueHBU8ykFg/DKx4Rj9LpI5s2Wgl0DgKqsuR3t0RT5ngEmZz/r/lS VgswSym77RFzqxn8fQqHOVoNvkEubwg1aTHpfFkFqrCpwD6hqCx4x8refrdouDp0l1/b gCU9cMj5hHAR4cczIF6roR7cnfX6MCKLdLLhmwS/hK3KKT5mm4vFWQHNEK9ALS4P/xbU wdG3iekLj6/QKJjlpbHvx8f4o71Ol4wMJAd/IkNzFbdZNOAishWrwSgYMOz1jNcnseQC tJqz6Tb24cAZplmhvq6r6MwoRgKdjg4QJYXWubRGEGbjZ0aVLDHc988mhXPJcMryz6J9 AXow== X-Gm-Message-State: AOJu0Yyow4smAj5vHAlVygnvrZw0YZWLtDzzGbFH5IHn4AsFoCiOWRar Sszaf96+7uEF7RReRBNqbrUr4MzOotYlJ8BARari9owdlTU= X-Google-Smtp-Source: AGHT+IEli89ZHBvGnjCggup+cbgcMPuL9Ab+Ps/XZbW9wtyRHUz2FxkHwWntpoRttdl7hXOWe1FxaCFmlW5MdPF0p+g= X-Received: by 2002:ac2:5bc4:0:b0:4fd:d172:fc2c with SMTP id u4-20020ac25bc4000000b004fdd172fc2cmr843020lfn.21.1693952869583; Tue, 05 Sep 2023 15:27:49 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 5 Sep 2023 15:27:48 -0700 In-Reply-To: <83edje5e0s.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269420 Archived-At: --0000000000000eef4e0604a4239a Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: > Actually, I take this back: this defvar will be computed when files.el > is loaded, which is at dump time. So this is not TRT, since the > conditions and the environment at dump time could be very different > from those at run time. It could be even on another machine. Yes, right. That's no good. > So I once again suggest to make this a defcustom. This has two > advantages: > > . it will be evaluated at Emacs startup, not at dump time Agreed. Let's change it into a defcustom. > . it will allow users to customize the value and thus avoid costly > search for the program and prevent finding the wrong version of > 'ls' Perhaps this part is okay though, given that the search should only affect users on macOS and *BSD (who presumably will want this anyways)? Proposed patch attached. --0000000000000eef4e0604a4239a Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Make-insert-directory-program-a-defcustom-and-use-gl.patch" Content-Disposition: attachment; filename="0001-Make-insert-directory-program-a-defcustom-and-use-gl.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 1733b0134daf8797_0.1 RnJvbSA0M2ZmOTM5NmZkYzZiNTY0M2E3MmZkYjc2ZWNhMTAwNjc3NjJiMzM0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBXZWQsIDYgU2VwIDIwMjMgMDA6MTY6MDMgKzAyMDAKU3ViamVjdDogW1BBVENIXSBN YWtlIGluc2VydC1kaXJlY3RvcnktcHJvZ3JhbSBhIGRlZmN1c3RvbSBhbmQgdXNlICJnbHMiIG9u CiAqQlNECgoqIGxpc3AvZmlsZXMuZWwgKGluc2VydC1kaXJlY3RvcnktcHJvZ3JhbSk6IENoYW5n ZSBpbnRvIGRlZmN1c3RvbS4KRGVmYXVsdCB0byB1c2luZyAiZ2xzIiBvbiAqQlNEIGFuZCBtYWNP Uy4gIChCdWcjNjQ3OTEpCi0tLQogZXRjL05FV1MgICAgICB8ICA4ICsrKysrKysrCiBsaXNwL2Zp bGVzLmVsIHwgMTEgKysrKysrKysrLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygr KSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4 IGE2OGU2N2UwNjk0Li41MjY0ODQwMDI2MSAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRj L05FV1MKQEAgLTEyOCw2ICsxMjgsMTQgQEAgY2FuIHVzZSB0aGlzIHRvIGRpc3Rpbmd1aXNoIGJl dHdlZW4gYnVmZmVycyB2aXNpdGluZyBmaWxlcyB3aXRoIHRoZQogc2FtZSBiYXNlIG5hbWUgdGhh dCBiZWxvbmcgdG8gZGlmZmVyZW50IHByb2plY3RzIGJ5IHVzaW5nIHRoZSBwcm92aWRlZAogdHJh bnNmb3JtIGZ1bmN0aW9uICdwcm9qZWN0LXVuaXF1aWZ5LWRpcm5hbWUtdHJhbnNmb3JtJy4KIAor KiogJ2luc2VydC1kaXJlY3RvcnktcHJvZ3JhbScgaXMgbm93IGEgZGVmY3VzdG9tLgorCisqKiAn aW5zZXJ0LWRpcmVjdG9yeS1wcm9ncmFtJyBwcmVmZXJzICJnbHMiIG9uICpCU0QgYW5kIG1hY09T LgorT24gKkJTRCBhbmQgbWFjT1Mgc3lzdGVtcywgaXQgbm93IGRlZmF1bHRzIHRvIHVzaW5nIHRo ZSAiZ2xzIgorZXhlY3V0YWJsZSwgaWYgaXQgZXhpc3RzLiAgVGhpcyBzaG91bGQgcmVtb3ZlIHRo ZSBuZWVkIHRvIGNoYW5nZSBpdHMKK3ZhbHVlIHdoZW4gaW5zdGFsbGluZyBHTlUgY29yZXV0aWxz IHVzaW5nIHNvbWV0aGluZyBsaWtlIHBvcnRzIG9yCitIb21lYnJldy4KKwogKiogY2wtcHJpbnQK IAogKioqIFlvdSBjYW4gZXhwYW5kIHRoZSAiLi4uIiB0cnVuY2F0aW9uIGV2ZXJ5d2hlcmUuCmRp ZmYgLS1naXQgYS9saXNwL2ZpbGVzLmVsIGIvbGlzcC9maWxlcy5lbAppbmRleCA0MTg4NjE1ZTQ5 MC4uZWY1YzZhOTZiNTUgMTAwNjQ0Ci0tLSBhL2xpc3AvZmlsZXMuZWwKKysrIGIvbGlzcC9maWxl cy5lbApAQCAtNzcyMywxMCArNzcyMywxNyBAQCBzaGVsbC1xdW90ZS13aWxkY2FyZC1wYXR0ZXJu CiAgICAgICBwYXR0ZXJuKSkpKQogCiAKLShkZWZ2YXIgaW5zZXJ0LWRpcmVjdG9yeS1wcm9ncmFt IChwdXJlY29weSAibHMiKQorKGRlZmN1c3RvbSBpbnNlcnQtZGlyZWN0b3J5LXByb2dyYW0KKyAg KGlmIChhbmQgKG1lbXEgc3lzdGVtLXR5cGUgJyhiZXJrZWxleS11bml4IGRhcndpbikpCisgICAg ICAgICAgIChleGVjdXRhYmxlLWZpbmQgImdscyIpKQorICAgICAgKHB1cmVjb3B5ICJnbHMiKQor ICAgIChwdXJlY29weSAibHMiKSkKICAgIkFic29sdXRlIG9yIHJlbGF0aXZlIG5hbWUgb2YgdGhl IGBscyctbGlrZSBwcm9ncmFtLgogVGhpcyBpcyB1c2VkIGJ5IGBpbnNlcnQtZGlyZWN0b3J5JyBh bmQgYGRpcmVkLWluc2VydC1kaXJlY3RvcnknCi1cKHRodXMsIGFsc28gYnkgYGRpcmVkJykuIikK Kyh0aHVzLCBhbHNvIGJ5IGBkaXJlZCcpLiIKKyAgOmdyb3VwICdkaXJlZAorICA6dHlwZSAnc3Ry aW5nCisgIDp2ZXJzaW9uICIzMC4xIikKIAogKGRlZmN1c3RvbSBkaXJlY3RvcnktZnJlZS1zcGFj ZS1wcm9ncmFtIChwdXJlY29weSAiZGYiKQogICAiUHJvZ3JhbSB0byBnZXQgdGhlIGFtb3VudCBv ZiBmcmVlIHNwYWNlIG9uIGEgZmlsZSBzeXN0ZW0uCi0tIAoyLjQyLjAKCg== --0000000000000eef4e0604a4239a--