From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#72230: 29.4; Cursor Disappears with Hebrew Text Date: Sun, 21 Jul 2024 11:05:57 -0700 Message-ID: References: <86o76qbvd9.fsf@gnu.org> <86ikwybuoq.fsf@gnu.org> <86a5iabq90.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31717"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , 72230@debbugs.gnu.org To: Eli Zaretskii , hermann sorgel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 21 20:08:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sVayu-00083g-5r for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Jul 2024 20:08:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sVayZ-0001S4-4V; Sun, 21 Jul 2024 14:08:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVayW-0001Ro-T0 for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2024 14:08:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sVayW-0005cu-Km for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2024 14:08:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sVayY-0007BX-Bw for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2024 14:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Jul 2024 18:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72230 X-GNU-PR-Package: emacs Original-Received: via spool by 72230-submit@debbugs.gnu.org id=B72230.172158522827554 (code B ref 72230); Sun, 21 Jul 2024 18:08:02 +0000 Original-Received: (at 72230) by debbugs.gnu.org; 21 Jul 2024 18:07:08 +0000 Original-Received: from localhost ([127.0.0.1]:56020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVaxg-0007AL-Ah for submit@debbugs.gnu.org; Sun, 21 Jul 2024 14:07:08 -0400 Original-Received: from mail-ed1-f46.google.com ([209.85.208.46]:57681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sVaxd-00079m-UF for 72230@debbugs.gnu.org; Sun, 21 Jul 2024 14:07:06 -0400 Original-Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5a156556fb4so2483555a12.3 for <72230@debbugs.gnu.org>; Sun, 21 Jul 2024 11:07:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721585158; x=1722189958; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=xf2IhBNSjfuCCFNOGQXIgOUX3v5LqBHuxCH6nnwMj/8=; b=Cpn3Fn0qkjdPYUETCTK7NsMO0G0AF89K6NyYYW5k5zGKr9qEMMCZLs9LWZphATH0Rw btU04+kqMQ94vn+j00TRYqI58V4wd+/MPSUi7G5Y8oR3b1K0UTTOZxze2HO3VTidt+ka zDMePetRP4gCieH1XTq5uVbj5Mr0hYa073glGTbSeFZWK0IZRzYg6GvQCbl4AAdk+xD5 OEvRRkNkXG3204ZqhNcJVyeGwGTvoLpgS/8C5nVOk3XzfiJy15J2Fo1ToMowqHeoEkrX x/pZ9E8iefEXNeQ8Iyc4gv2evs7O7+thWg1TYizlntlc0ll4KDjXoLMjOrIeFnrPJP3e yvpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721585158; x=1722189958; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xf2IhBNSjfuCCFNOGQXIgOUX3v5LqBHuxCH6nnwMj/8=; b=G+i5RjxHtqg6rTxGQ4jNTiCG3Pm7qSqC5s6ME56aveJ/8WxsarGGVa653GgdZXLVq4 wK9kcGilKIy1HIUbPnMvowcvQ1x01Gcfa1EH7HoZ7t6vonykfXjJm/ENe9qk7DWBP5fi U0UfHhYmpHv06bz45FuLX2FR+BcTYcE7v2zuczoB4psKZtZ5Np4AiBMXLRVmIQlaZBcG 41FlPIFIdr0f4BMVocXkrDavvdLZJUz3othk1umPckT0doM6sOH0L0bn1mJXGK3fK1uF kL60DoOlfXNW6CWNGHME8qbR+3aZOXOmBaGVsMLKp0XK2lFKEIV/sE0by5UXMiwQfInz UzKQ== X-Gm-Message-State: AOJu0YxGdE1d8Bjna80xhzWxbfb3ViAL0sxjnaKIoFXJa5tmXGdBL50T q7fmgJIDspSlms0zoaO9MQiVWpQJ52RPgbszedCoMLEmyhbGCD5IoMy9c1z/ii6GIqi4qvbIeeU a9hQru5//AbN6Z4lnKUufvEF+om0= X-Google-Smtp-Source: AGHT+IFT9b8S60tpvc+T+MVTafyiEwsRYtxsw3aLun1U7vXF3Bq8OSUQgQEqNK81EovRXpbAAJvcNu9bL3YBTKFslXU= X-Received: by 2002:a05:6402:270c:b0:5a7:464a:ab9 with SMTP id 4fb4d7f45d1cf-5a7464a0b08mr1226347a12.21.1721585157917; Sun, 21 Jul 2024 11:05:57 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 21 Jul 2024 11:05:57 -0700 In-Reply-To: <86a5iabq90.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289086 Archived-At: Eli Zaretskii writes: > So maybe the problem is elsewhere. One thing is almost certain: it's > a problem specific to the macOS build of Emacs. People who can debug > on that platform are encouraged to suggest insights and changes. This seems to have something to with the clipping path, and is fixed here by the below patch. I don't think it's suitable for installing though. Po Lu, since you added the below NSRectClip call, do you have any thoughts here? diff --git a/src/nsterm.m b/src/nsterm.m index 794630de1c1..54b15bc851d 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -3102,7 +3102,7 @@ Note that CURSOR_WIDTH is meaningful only for (h)bar cursors. #ifdef NS_IMPL_GNUSTEP GSRectClipList (ctx, &r, 1); #else - NSRectClip (r); + // NSRectClip (r); #endif [FRAME_CURSOR_COLOR (f) set]; @@ -3135,7 +3135,7 @@ Note that CURSOR_WIDTH is meaningful only for (h)bar cursors. on the right of its glyph, rather than on the left. */ cursor_glyph = get_phys_cursor_glyph (w); if ((cursor_glyph->resolved_level & 1) != 0) - s.origin.x += cursor_glyph->pixel_width - s.size.width; + s.origin.x += cursor_glyph->pixel_width - cursor_width; NSRectFill (s); [ctx restoreGraphicsState];