From: Stefan Kangas <stefankangas@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>, Yuan Fu <casouri@gmail.com>
Cc: 60511@debbugs.gnu.org, juri@linkov.net
Subject: bug#60511: 29.0.50; treesit-ready-p should not emit warning by default
Date: Sun, 8 Jan 2023 10:14:07 -0800 [thread overview]
Message-ID: <CADwFkmnZP8erjEB5+OrbgdOa5ikbFjLtPLsb0rOThQbrRv8pRA@mail.gmail.com> (raw)
In-Reply-To: <83lemdr2qt.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> I can make treesit-ready-p not emit any warning by default, and change
>> the quiet parameter to WARN, and accept either 'warn or ‘message.
>>
>> Basically:
>>
>> (treesit-ready-p lang) => t/nil
>> (treesit-ready-p lang 'warn) => t/emit warning
>> (treesit-ready-p lang 'message) => t/message
This makes sense to me.
>> Eli, WDYT?
>
> I think the default should be to emit a warning, like we do now.
In that case, it would be better to rename `treesit-ready-p' to reflect
that it's not a predicate function. I believe Juri suggested the name
`treesit-check-readiness'.
Then there's the question if we want a predicate function for this too.
I think it would be useful.
> We should support the main use case of the user turning on a TS mode
> when the required libraries are not installed or incompatible with our
> requirements. Silently doing nothing in that case is not TRT.
To be clear, I did not suggest changing that behavior.
next prev parent reply other threads:[~2023-01-08 18:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 11:19 bug#60511: 29.0.50; treesit-ready-p should not emit warning by default Stefan Kangas
2023-01-03 17:44 ` Juri Linkov
2023-01-04 7:02 ` Yuan Fu
2023-01-04 7:47 ` Juri Linkov
2023-01-08 1:31 ` Yuan Fu
2023-01-08 5:53 ` Eli Zaretskii
2023-01-08 8:39 ` Juri Linkov
2023-01-08 11:03 ` Eli Zaretskii
2023-01-08 17:35 ` Juri Linkov
2023-01-08 17:57 ` Eli Zaretskii
2023-01-08 18:11 ` Juri Linkov
2023-01-08 18:48 ` Eli Zaretskii
2023-01-08 18:14 ` Stefan Kangas [this message]
2023-01-08 18:28 ` Juri Linkov
2023-01-08 18:49 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmnZP8erjEB5+OrbgdOa5ikbFjLtPLsb0rOThQbrRv8pRA@mail.gmail.com \
--to=stefankangas@gmail.com \
--cc=60511@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).