From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#24706: 26.0.50; Minor mode functions should do strict argument type checking Date: Thu, 1 Oct 2020 05:12:49 -0700 Message-ID: References: <83mvi4yvoj.fsf@gnu.org> <83tw5bo1em.fsf@gnu.org> <83tuxlauw0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38480"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 24706-done@debbugs.gnu.org, Philipp Stephani To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 01 14:13:59 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNxTD-0009tU-1j for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Oct 2020 14:13:59 +0200 Original-Received: from localhost ([::1]:37256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNxTC-00014y-4k for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Oct 2020 08:13:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNxSL-0000Lh-58 for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 08:13:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51086) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNxSK-0006Kx-Qx for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 08:13:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kNxSK-0007QK-Lw for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 08:13:04 -0400 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Oct 2020 12:13:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 24706 X-GNU-PR-Package: emacs Mail-Followup-To: 24706@debbugs.gnu.org, stefan@marxist.se, p.stephani2@gmail.com Original-Received: via spool by 24706-done@debbugs.gnu.org id=D24706.160155437728457 (code D ref 24706); Thu, 01 Oct 2020 12:13:04 +0000 Original-Received: (at 24706-done) by debbugs.gnu.org; 1 Oct 2020 12:12:57 +0000 Original-Received: from localhost ([127.0.0.1]:34386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNxSD-0007Ou-FI for submit@debbugs.gnu.org; Thu, 01 Oct 2020 08:12:57 -0400 Original-Received: from mail-ed1-f68.google.com ([209.85.208.68]:43996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNxSB-0007OV-FL for 24706-done@debbugs.gnu.org; Thu, 01 Oct 2020 08:12:55 -0400 Original-Received: by mail-ed1-f68.google.com with SMTP id dn5so1500362edb.10 for <24706-done@debbugs.gnu.org>; Thu, 01 Oct 2020 05:12:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=NHjs/BZOsrPX4ugKC9ux3yljpty9yDT56JsUcuY2QY0=; b=gf+EfgAXQnGcjxZnXwarwZx/Oj6LKhLkZCqvy1KQUW/9+SFq6oTgsM4EnxE0QB30uv hKqV9tT+Wij+FWHPLDMHkZ39Ym7N4dZ/WU1jbsVg60SYs7e7N8DLHGVJaXc75ax5fuRG ZGpu5ZdcncOW8OTSPuBUx6G806K3h6nU5NI9kxuMJmrMFHx9FRnnBIO6sJ5FPabL1ZtG 4xNnrU6pq6cJ3VvsMuO9HuWqabkmytUOM9kOYKf9viSx582vLMCknY6gq7IbYUk722Fb pmv/hqdow8iEspomFZjf4bn5OnqztjBeM/NeluVbGO9NKF3eW6+CfRoeHt7oyCbhbDCV B6sg== X-Gm-Message-State: AOAM532ngLVTBmoYAzepS/lCovMU+bjS/QMTxI3Q0Vk2cT6kvbFNVjnZ XavuBUwTLnKlf8q7+vUVb/BjGG2TKYLeuknA2Z4= X-Google-Smtp-Source: ABdhPJyUVuOwwRqpJYMcV+HpOKW9CThdRgtd55ewwQs8BZOVlpQLJFjqZ67vKuEvrdOMHRJvADtvkmgAESskXfHXE9U= X-Received: by 2002:a50:fa42:: with SMTP id c2mr1876768edq.282.1601554369957; Thu, 01 Oct 2020 05:12:49 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 1 Oct 2020 05:12:49 -0700 In-Reply-To: <83tuxlauw0.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 02 Aug 2020 19:13:19 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189491 Archived-At: Eli Zaretskii writes: >> From: Philipp Stephani >> Date: Sat, 1 Aug 2020 22:47:03 +0200 >> Cc: Drew Adams , 24706@debbugs.gnu.org >> >> Am Mi., 26. Apr. 2017 um 13:27 Uhr schrieb Eli Zaretskii : >> > >> > > From: Philipp Stephani >> > > Date: Sun, 23 Apr 2017 17:51:32 +0000 >> > > Cc: drew.adams@oracle.com, 24706@debbugs.gnu.org >> > > >> > > Eli Zaretskii schrieb am So., 16. Okt. 2016 um 20:51 Uhr: >> > > >> > > > From: Philipp Stephani >> > > > Date: Sun, 16 Oct 2016 18:25:08 +0000 > > It's hard to have a useful discussion when messages are several months > apart. > >> > > The patch for the ELisp manual simply rearranges the same words, so >> > > it's not clear to me why we would prefer it to what's already there. >> > > >> > > I don't think there's any repetition or rearranging here. >> > >> > Here's the ELisp manual part of your proposed change: >> > >> > If the mode command is called from Lisp (i.e., non-interactively), it >> > -should enable the mode if the argument is omitted or @code{nil}; it >> > -should toggle the mode if the argument is the symbol @code{toggle}; >> > -otherwise it should treat the argument in the same way as for an >> > -interactive call with a numeric prefix argument, as described above. >> > +should toggle the mode if the argument is the symbol @code{toggle}; it >> > +should disable the mode if the argument is a non-positive integer; >> > +otherwise, e.g., if the argument is omitted or nil or a positive >> > +integer, it should enable the mode. >> > >> > Don't you agree that it does little apart of re-shuffling the same >> > words? >> >> It also describes what happens when the argument is neither nil nor >> `toggle' nor an integer. That is currently unspecified, or rather >> implicitly specified by the observable (but unspecified) behavior of >> `prefix-numeric-value'. > > I think the "otherwise" part describes that. > >> > > The key difference is that when called from Lisp with an >> > > argument that is neither nil nor an integer, the mode is also enabled. >> > >> > Why would we want to require that? This subsection describes the >> > conventions, it doesn't describe the effect of certain popular >> > implementation of those conventions, because we don't really want to >> > _require_ modes to behave in any way beyond the described behavior. >> >> This isn't about the implementation but the interface, i.e. the >> observable behavior of minor mode functions. > > I don't see how making this the matter of interface changes anything. > We still don't want to require modes to interpret the interface the > way you'd like to see. > > Bottom line: I think there's nothing important left to discuss here. That was 8 weeks ago, and there has been no further comments. I'm therefore closing this bug now. If there is anything more to do here, please reply to this email (use "Reply to all" in your email client) and we can reopen the bug report. Best regards, Stefan Kangas