From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#45379: 28.0.50; Degraded Performance of describe-buffer-bindings Date: Sun, 7 Mar 2021 03:12:17 -0500 Message-ID: References: <02f717c6-dc96-4ba0-9117-2ef079ac556f@www.fastmail.com> <83v9a4wve3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13750"; mail-complaints-to="usenet@ciao.gmane.io" Cc: juri@linkov.net, styang@fastmail.com, stephen.berman@gmx.net, monnier@iro.umontreal.ca, 45379@debbugs.gnu.org To: Eli Zaretskii , Kenichi Handa Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 07 09:13:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lIoXK-0003TS-1E for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Mar 2021 09:13:14 +0100 Original-Received: from localhost ([::1]:38312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIoXJ-0002wX-3d for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Mar 2021 03:13:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39698) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIoX8-0002wD-At for bug-gnu-emacs@gnu.org; Sun, 07 Mar 2021 03:13:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55541) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lIoX8-0005od-3q for bug-gnu-emacs@gnu.org; Sun, 07 Mar 2021 03:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lIoX7-0004Ht-W7 for bug-gnu-emacs@gnu.org; Sun, 07 Mar 2021 03:13:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Mar 2021 08:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45379 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch confirmed Original-Received: via spool by 45379-submit@debbugs.gnu.org id=B45379.161510474516438 (code B ref 45379); Sun, 07 Mar 2021 08:13:01 +0000 Original-Received: (at 45379) by debbugs.gnu.org; 7 Mar 2021 08:12:25 +0000 Original-Received: from localhost ([127.0.0.1]:38854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIoWX-0004H4-7K for submit@debbugs.gnu.org; Sun, 07 Mar 2021 03:12:25 -0500 Original-Received: from mail-pf1-f172.google.com ([209.85.210.172]:44084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIoWW-0004Gr-9g for 45379@debbugs.gnu.org; Sun, 07 Mar 2021 03:12:24 -0500 Original-Received: by mail-pf1-f172.google.com with SMTP id t29so5057013pfg.11 for <45379@debbugs.gnu.org>; Sun, 07 Mar 2021 00:12:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=bTYLzNNnDDJOSf2N3DR9GIASH7LOJra6HpjH7NkSPdo=; b=TUX1gH46EHqrR+4gq4MKNxiffol9oKrWHvaSYG81p6/wx6n0vuJvDUBMLS9s/OXGE9 HSQV7cd3hteJBJ666Ur0S+RcNr1XJZv0MNY7R/JvxyrrkKZpTKEZRAPl1D2usuBeenWM /DLoMxd1injlHlUTdDhMstRPoIf81W03NHJvJKRuh2v2VaCTBJIwiqL1ncw7yk2+V2py i+i4iCB53ZhflWOM1oNCVohY+mWFT76jKJVcIVZwWn/bnyXp3pHqTZ7t6qUgrjDgfrDm tNMjZwaiF2oCWH96JJzqoeY73cPMGqwMn8DXYrgfUoj1KSaPQXINxpB48JnL6qkEo2f6 iBCQ== X-Gm-Message-State: AOAM531J4OWPHOpoY7592ziP28i+1HBWrnjQnmRtlgFMr6SkfCL6hjXr 6qet71bh4xtIvhrlBTNtx22NHOEkhFC4EgK7TdU= X-Google-Smtp-Source: ABdhPJycdIlS2fOcRG5XTYBr7lIglfpjHk+RuU96IPRpBehRR4LI2Fe42Krm2GeZLWI25YEpa8rKPULrNdhaVp/H0jE= X-Received: by 2002:a63:6206:: with SMTP id w6mr13712545pgb.363.1615104738570; Sun, 07 Mar 2021 00:12:18 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 7 Mar 2021 03:12:17 -0500 In-Reply-To: <83v9a4wve3.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201730 Archived-At: Eli Zaretskii writes: >> It turns out that we were doing unnecessary looping due to the above >> mentioned commit. While working on this, I also found that we can get >> rid of an unnecessary call to char_table_ref_and_range, which should >> make this function run even faster. > > I'm not sure I understand the reasons for each of the changes here. > char-tables are a tricky data structure, so I'd like to make sure this > change doesn't make our code subtly incorrect. Thanks. I have been struggling to come up with good unit tests, so any ideas about that would also be very welcome. > So could you please walk us through the proposed changes, adding > explanations for each part as you go? Yes. Please allow for at least a couple of days to write this up. > (And what do char-tables have to do with describing key bindings, > btw?) Full keymaps are char-tables, while sparse keymaps are just lists. The call stack looks like this: Fdescribe_buffer_bindings [keymap.c] -> describe-map-tree [help.el] -> describe-map -> Fhelp__describe_vector [keymap.c] -> describe_vector