From: Stefan Kangas <stefan@marxist.se>
To: Eli Zaretskii <eliz@gnu.org>, Kenichi Handa <handa@gnu.org>
Cc: juri@linkov.net, styang@fastmail.com, stephen.berman@gmx.net,
monnier@iro.umontreal.ca, 45379@debbugs.gnu.org
Subject: bug#45379: 28.0.50; Degraded Performance of describe-buffer-bindings
Date: Sun, 7 Mar 2021 03:12:17 -0500 [thread overview]
Message-ID: <CADwFkmnX56wcVW=y1a3NZv0AqXraRs_3bdd44nEVDiaXdm5Fsg@mail.gmail.com> (raw)
In-Reply-To: <83v9a4wve3.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> It turns out that we were doing unnecessary looping due to the above
>> mentioned commit. While working on this, I also found that we can get
>> rid of an unnecessary call to char_table_ref_and_range, which should
>> make this function run even faster.
>
> I'm not sure I understand the reasons for each of the changes here.
> char-tables are a tricky data structure, so I'd like to make sure this
> change doesn't make our code subtly incorrect.
Thanks.
I have been struggling to come up with good unit tests, so any ideas
about that would also be very welcome.
> So could you please walk us through the proposed changes, adding
> explanations for each part as you go?
Yes. Please allow for at least a couple of days to write this up.
> (And what do char-tables have to do with describing key bindings,
> btw?)
Full keymaps are char-tables, while sparse keymaps are just lists.
The call stack looks like this:
Fdescribe_buffer_bindings [keymap.c]
-> describe-map-tree [help.el]
-> describe-map
-> Fhelp__describe_vector [keymap.c]
-> describe_vector
next prev parent reply other threads:[~2021-03-07 8:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 6:01 bug#45379: 28.0.50; Degraded Performance of describe-buffer-bindings styang
2021-01-08 16:47 ` Sheng Yang
2021-01-08 17:00 ` Stefan Kangas
2021-01-08 17:08 ` Stefan Kangas
2021-02-04 15:43 ` Sheng Yang
2021-03-06 4:44 ` Stefan Kangas
2021-03-06 8:15 ` Eli Zaretskii
2021-03-07 1:42 ` handa
2021-03-07 6:15 ` Eli Zaretskii
2021-03-30 7:01 ` Eli Zaretskii
2021-04-01 15:06 ` handa
2021-04-14 3:06 ` Sheng Yang
2021-03-07 8:12 ` Stefan Kangas [this message]
2021-03-07 8:38 ` Eli Zaretskii
2021-05-04 23:31 ` Stefan Kangas
2021-05-06 10:11 ` Eli Zaretskii
2021-05-13 10:10 ` Eli Zaretskii
2021-06-26 21:51 ` Sheng Yang
2021-06-27 5:56 ` Eli Zaretskii
2021-09-07 18:53 ` Eli Zaretskii
2021-09-18 10:37 ` Eli Zaretskii
2021-09-18 12:34 ` Stefan Kangas
2021-09-18 13:24 ` Eli Zaretskii
2021-09-18 14:39 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmnX56wcVW=y1a3NZv0AqXraRs_3bdd44nEVDiaXdm5Fsg@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=45379@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=handa@gnu.org \
--cc=juri@linkov.net \
--cc=monnier@iro.umontreal.ca \
--cc=stephen.berman@gmx.net \
--cc=styang@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).