bug#37202: shadowfile-tests: two failures on macOS

[Stefan Kangas <stefan@marxist.se>]

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]

Michael Albinus <michael.albinus@gmx.de> writes:

Hi Michael,

> Could you, pls, check? In case it still fails, pls set shadow-debug to t
> (in shadowfile-tests.el, line 67), and rerun the test.

Thanks for looking into this.  Unfortunately, I'm still seeing
failures on latest master (commit ea5d591f29):

2 unexpected results:
   FAILED  shadow-test08-shadow-todo
   FAILED  shadow-test09-shadow-copy-files

I've attached the output of "make -C test shadowfile-tests" with
shadow-debug set to t.

Best regards,
Stefan Kangas

[-- Attachment #2: shadowfile-tests.log --]
[-- Type: application/octet-stream, Size: 4424 bytes --]

  GEN      lisp/shadowfile-tests.log
Running 10 tests (2019-09-03 15:09:00+0200, selector `(not (tag :unstable))')
   passed   1/10  shadow-test00-clusters (4.038487 sec)
   passed   2/10  shadow-test01-sites (0.028111 sec)
   passed   3/10  shadow-test02-files (0.011824 sec)
   passed   4/10  shadow-test03-expand-cluster-in-file-name (0.012810 sec)
   passed   5/10  shadow-test04-contract-file-name (0.134683 sec)
   passed   6/10  shadow-test05-file-match (0.015192 sec)
   passed   7/10  shadow-test06-literal-groups (0.034533 sec)
   passed   8/10  shadow-test07-regexp-groups (0.030164 sec)
cluster1 /Stefans-MBP: \`/Stefans-MBP:\' ((shadow-cluster cluster1 /Stefans-MBP: \`/Stefans-MBP:\'))
cluster2 /mock:Stefans-MBP: \`/mock:Stefans-MBP:\' ((shadow-cluster cluster2 /mock:Stefans-MBP: \`/mock:Stefans-MBP:\') (shadow-cluster cluster1 /Stefans-MBP: \`/Stefans-MBP:\'))
/var/folders/pj/rhx0gxy15tv3vx6l3mdy0qvm0000gn/T/shadowfile-testsMVv1V3 ((/cluster1:/var/folders/pj/rhx0gxy15tv3vx6l3mdy0qvm0000gn/T/shadowfile-testsMVv1V3 /cluster2:/var/folders/pj/rhx0gxy15tv3vx6l3mdy0qvm0000gn/T/shadowfile-testsMVv1V3))
(/var/folders/pj/rhx0gxy15tv3vx6l3mdy0qvm0000gn/T/shadowfile-testsMVv1V3 . /cluster2:/var/folders/pj/rhx0gxy15tv3vx6l3mdy0qvm0000gn/T/shadowfile-testsMVv1V3) nil
Test shadow-test08-shadow-todo backtrace:
  signal(ert-test-failed (((should (member (cons file (shadow-contract
  ert-fail(((should (member (cons file (shadow-contract-file-name (con
  (if (unwind-protect (setq value-549 (apply fn-547 args-548)) (setq f
  (let (form-description-551) (if (unwind-protect (setq value-549 (app
  (let ((value-549 'ert-form-evaluation-aborted-550)) (let (form-descr
  (let* ((fn-547 #'member) (args-548 (condition-case err (let ((signal
  (progn (shadow--tests-cleanup) (setq cluster1 "cluster1" primary sha
  (unwind-protect (progn (shadow--tests-cleanup) (setq cluster1 "clust
  (let ((backup-inhibited t) (shadow-info-file shadow-test-info-file) 
  (lambda nil (let* ((fn-532 #'not) (args-533 (condition-case err (let
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name shadow-test08-shadow-todo :documentat
  ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :unstable)) 
  ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
  ert-run-tests-batch((not (tag :unstable)))
  ert-run-tests-batch-and-exit((not (tag :unstable)))
  eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/shadowfile-tests.el"
  command-line()
  normal-top-level()
Test shadow-test08-shadow-todo condition:
    (ert-test-failed
     ((should
       (member
	(cons file ...)
	shadow-files-to-copy))
      :form
      (member
       ("/var/folders/pj/rhx0gxy15tv3vx6l3mdy0qvm0000gn/T/shadowfile-testsMVv1V3" . "/cluster2:/var/folders/pj/rhx0gxy15tv3vx6l3mdy0qvm0000gn/T/shadowfile-testsMVv1V3")
       nil)
      :value nil))
   FAILED   9/10  shadow-test08-shadow-todo (0.134735 sec)


Test shadow-test09-shadow-copy-files backtrace:
  set-buffer(nil)
  (save-current-buffer (set-buffer shadow-todo-buffer) (goto-char (poi
  (progn (shadow--tests-cleanup) (setq cluster1 "cluster1" primary sha
  (unwind-protect (progn (shadow--tests-cleanup) (setq cluster1 "clust
  (let ((backup-inhibited t) (shadow-info-file shadow-test-info-file) 
  (lambda nil (let* ((fn-567 #'not) (args-568 (condition-case err (let
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name shadow-test09-shadow-copy-files :docu
  ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :unstable)) 
  ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
  ert-run-tests-batch((not (tag :unstable)))
  ert-run-tests-batch-and-exit((not (tag :unstable)))
  eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/shadowfile-tests.el"
  command-line()
  normal-top-level()
Test shadow-test09-shadow-copy-files condition:
    (wrong-type-argument stringp nil)
   FAILED  10/10  shadow-test09-shadow-copy-files (0.580559 sec)

Ran 10 tests, 8 results as expected, 2 unexpected (2019-09-03 15:09:06+0200, 5.780896 sec)

2 unexpected results:
   FAILED  shadow-test08-shadow-todo
   FAILED  shadow-test09-shadow-copy-files

make[1]: *** [lisp/shadowfile-tests.log] Error 1
make: *** [lisp/shadowfile-tests] Error 2