* bug#36408: [PATCH] Fix typo in doc string of file-exists-p
@ 2019-06-28 0:12 Stefan Kangas
2019-06-28 6:33 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Kangas @ 2019-06-28 0:12 UTC (permalink / raw)
To: 36408
[-- Attachment #1: Type: text/plain, Size: 276 bytes --]
Please see the attached small fix, making sure the first line is a
complete sentence.
- doc: /* Return t if file FILENAME exists (whether or not you
can read it.)
+ doc: /* Return t if file FILENAME exists (whether or not you
can read it).
Thanks,
Stefan Kangas
[-- Attachment #2: 0001-Fix-typo-in-doc-string-of-file-exists-p.patch --]
[-- Type: application/x-patch, Size: 963 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#36408: [PATCH] Fix typo in doc string of file-exists-p
2019-06-28 0:12 bug#36408: [PATCH] Fix typo in doc string of file-exists-p Stefan Kangas
@ 2019-06-28 6:33 ` Eli Zaretskii
2019-06-29 3:19 ` Richard Stallman
0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2019-06-28 6:33 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 36408
> From: Stefan Kangas <stefan@marxist.se>
> Date: Fri, 28 Jun 2019 02:12:32 +0200
>
> Please see the attached small fix, making sure the first line is a
> complete sentence.
>
> - doc: /* Return t if file FILENAME exists (whether or not you
> can read it.)
> + doc: /* Return t if file FILENAME exists (whether or not you
> can read it).
AFAIK, this is a long-standing stylistic issue. I'm not sure what
people prefer or whether we should insist on consistency in these
cases.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#36408: [PATCH] Fix typo in doc string of file-exists-p
[not found] ` <<83imsqi5hc.fsf@gnu.org>
@ 2019-06-28 15:38 ` Drew Adams
0 siblings, 0 replies; 5+ messages in thread
From: Drew Adams @ 2019-06-28 15:38 UTC (permalink / raw)
To: Eli Zaretskii, Stefan Kangas; +Cc: 36408
> > - doc: /* Return t if file FILENAME exists (whether or not you
> > can read it.)
> > + doc: /* Return t if file FILENAME exists (whether or not you
> > can read it).
>
> AFAIK, this is a long-standing stylistic issue. I'm not sure what
> people prefer or whether we should insist on consistency in these
> cases.
FWIW: There's no stylistic issue here. The first
is incorrect; the second is correct. You won't
find any style guide that would opt for or approve
of the former: "___ ___ (__ __.)". That's not even
a sentence.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#36408: [PATCH] Fix typo in doc string of file-exists-p
2019-06-28 6:33 ` Eli Zaretskii
@ 2019-06-29 3:19 ` Richard Stallman
2019-06-29 7:38 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Richard Stallman @ 2019-06-29 3:19 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: stefan, 36408
[[[ To any NSA and FBI agents reading my email: please consider ]]]
[[[ whether defending the US Constitution against all enemies, ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]
> > - doc: /* Return t if file FILENAME exists (whether or not you
> > can read it.)
> > + doc: /* Return t if file FILENAME exists (whether or not you
> > can read it).
In this case, the latter is correct. You put a period inside the
parentheses only when its contents consist of complete sentences.
--
Dr Richard Stallman
President, Free Software Foundation (https://gnu.org, https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#36408: [PATCH] Fix typo in doc string of file-exists-p
2019-06-29 3:19 ` Richard Stallman
@ 2019-06-29 7:38 ` Eli Zaretskii
0 siblings, 0 replies; 5+ messages in thread
From: Eli Zaretskii @ 2019-06-29 7:38 UTC (permalink / raw)
To: rms; +Cc: stefan, 36408-done
> From: Richard Stallman <rms@gnu.org>
> Cc: stefan@marxist.se, 36408@debbugs.gnu.org
> Date: Fri, 28 Jun 2019 23:19:03 -0400
>
> > > - doc: /* Return t if file FILENAME exists (whether or not you
> > > can read it.)
> > > + doc: /* Return t if file FILENAME exists (whether or not you
> > > can read it).
>
> In this case, the latter is correct. You put a period inside the
> parentheses only when its contents consist of complete sentences.
Thanks, I pushed Stefan's patch to the emacs-26 branch.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-29 7:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-28 0:12 bug#36408: [PATCH] Fix typo in doc string of file-exists-p Stefan Kangas
2019-06-28 6:33 ` Eli Zaretskii
2019-06-29 3:19 ` Richard Stallman
2019-06-29 7:38 ` Eli Zaretskii
[not found] <<CADwFkmnVvd4ki1K+-pjdp_okHL0vFQnTxfWmNbZMeNqt1q1RnA@mail.gmail.com>
[not found] ` <<83imsqi5hc.fsf@gnu.org>
2019-06-28 15:38 ` Drew Adams
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).