From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#67931: [PATCH] Use S/MIME key from content for mail signing via OpenSSL Date: Thu, 11 Jan 2024 13:05:46 -0800 Message-ID: References: <8734vx6mk7.fsf@yshyn.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9248"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , 67931@debbugs.gnu.org To: Illia Ostapyshyn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 11 22:06:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rO2Fj-0002EB-Pk for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Jan 2024 22:06:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rO2Fe-0003Md-4i; Thu, 11 Jan 2024 16:06:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rO2FY-0003LE-QX for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2024 16:06:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rO2FY-00013S-E7 for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2024 16:06:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rO2FV-0000P2-VJ for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2024 16:06:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jan 2024 21:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67931 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67931-submit@debbugs.gnu.org id=B67931.17050071521530 (code B ref 67931); Thu, 11 Jan 2024 21:06:01 +0000 Original-Received: (at 67931) by debbugs.gnu.org; 11 Jan 2024 21:05:52 +0000 Original-Received: from localhost ([127.0.0.1]:34136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rO2FM-0000Ob-Ik for submit@debbugs.gnu.org; Thu, 11 Jan 2024 16:05:52 -0500 Original-Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]:49496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rO2FK-0000OM-GD for 67931@debbugs.gnu.org; Thu, 11 Jan 2024 16:05:52 -0500 Original-Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2ccbc328744so69984621fa.3 for <67931@debbugs.gnu.org>; Thu, 11 Jan 2024 13:05:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705007147; x=1705611947; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=6I2LW+qDHg9+f2iW16ddV+EQnIn2Voi5Lo3I1D3cKfw=; b=gSlIqcDJMS+9cJ2WczvkRhhD+cphjPRZ01Qh3/0k2QdSHGkb5+2uxyuDL7g0y0sj7G SR79Mu6JuEcIXx2D3vk9C4piIZJoHtC8oLsuq4DAVQZt4uY/Xu1WeHZqy82fLAkM/uhM EtxshvwaE5mY22bgjV7iTCpUBPY6r2y0figs0Jxs1VsaIQBQi/obhBUFg0pRHTM3wdhS P/6I3DmFRUOmuArCHF55ZMHpx7tYefJ2sRxYYwarU7YTnGIEzxJM8a7r3HVnmfkbO8XL Gm4Ev26Is7JCCPiaDrnx1kVEEIdvl7CeR4VoLEkLYvlG7wd0vEL+bAc2oLU5Gecd2d0L uPzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705007147; x=1705611947; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6I2LW+qDHg9+f2iW16ddV+EQnIn2Voi5Lo3I1D3cKfw=; b=l38UqpMqOncMjYs3g/wVRsCFwO0MflExVuvZxJ+w6FD/qAJ4SiJl4CXcaRJJDiQvXL XvjDoa7/8BGoGCbgdyTf4nLBTT4hOqkEMK7QQdy875tsXOO2oWL7meoWN8ArxB5xDIQe ts1+XVVdfdF/65spIgTEDqtd/C8V5Rmu6sjylcfLvx9YIHuF0B39d1kw0NhwHk4zaPSc oCKKOYDMIQ/k5CJpI1Z7380pF/7fyluN9SUJ+tWainS+T9CPqKA2PmZ9ggJlPkJl8Roi vzcw2OlJZF8WSL4rQHuHmzlJ/pc7UswrsR8C29q/WuxETg9UJ/54Pj8FdXr8qt/4ul5+ erhA== X-Gm-Message-State: AOJu0YwUWkRRL93MNokFeJXqxvXJVncWgsb8NyZAWXlx8MsAhKOkiZYE WEtAW9DELrPn/YUSuzsML6+8FI2njENjVjPIYwVLroXQ1ZI= X-Google-Smtp-Source: AGHT+IE+juVNTEWBa7DXQS5kHikuDp1QztfM/cyZ/qEFU3pLl/6cCCX6PGwVVPMTdWKQ2Itv+BqEt69wFKEQvNWDZw4= X-Received: by 2002:a2e:9b91:0:b0:2cd:1ca6:87c0 with SMTP id z17-20020a2e9b91000000b002cd1ca687c0mr175128lji.23.1705007146671; Thu, 11 Jan 2024 13:05:46 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 11 Jan 2024 13:05:46 -0800 In-Reply-To: <8734vx6mk7.fsf@yshyn.com> (Illia Ostapyshyn's message of "Wed, 20 Dec 2023 14:16:56 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277960 Archived-At: Illia Ostapyshyn writes: > * Bug > > mml-smime-openssl-sign always takes the cdar of smime-keys, resulting in > keyfile parameter of the #secure tag being ignored. Hence, only the > first entry of smime-keys is used, regardless of the mail contents or > sender address. > > * Fix > > The relevant information (returned from mml-smime-openssl-sign-query) is > already in the cont alist passed to mml-smime-openssl-sign, just use > that instead. Thanks for the patch. Could you please provide a way to reproduce the issue that you're seeing? We don't have anyone onboard that is deeply familiar with this code, I think, and it is security-sensitive. Therefore, I'd like to be careful when making changes here. If we could have unit tests for this, it would be even better, of course.