From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#46523: cl-struct-sequence-type documentation is incorrect Date: Sat, 25 Sep 2021 08:25:16 -0700 Message-ID: References: <87y2fqateb.fsf@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12990"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46523@debbugs.gnu.org, Stefan Monnier To: Michael Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 25 17:31:30 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mU9eD-0003Fn-AD for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 17:31:29 +0200 Original-Received: from localhost ([::1]:54144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mU9eB-0003Nx-Ie for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 11:31:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46850) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mU9Yw-0003FG-Pj for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 11:26:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51052) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mU9Yw-0007Nz-IL for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 11:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mU9Yw-0003gO-FU for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 11:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Sep 2021 15:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46523 X-GNU-PR-Package: emacs Original-Received: via spool by 46523-submit@debbugs.gnu.org id=B46523.163258352414039 (code B ref 46523); Sat, 25 Sep 2021 15:26:02 +0000 Original-Received: (at 46523) by debbugs.gnu.org; 25 Sep 2021 15:25:24 +0000 Original-Received: from localhost ([127.0.0.1]:34351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mU9YK-0003eM-9z for submit@debbugs.gnu.org; Sat, 25 Sep 2021 11:25:24 -0400 Original-Received: from mail-pg1-f182.google.com ([209.85.215.182]:46063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mU9YI-0003e7-Us for 46523@debbugs.gnu.org; Sat, 25 Sep 2021 11:25:23 -0400 Original-Received: by mail-pg1-f182.google.com with SMTP id n18so12918470pgm.12 for <46523@debbugs.gnu.org>; Sat, 25 Sep 2021 08:25:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=SRYjkygQ6aAxwMhFz21698hVpUV72KWX3+BphhDuzpA=; b=mOWIcK6Rgo/NPPkTP1jmKPmiarPh3r6P1veDKs5q7GZNQhf8l5Nj72uZIStzoe9U8g ZbZYr4YT9MrBTknMoTsXv65ve+VGnh0oPaMbDf1jeq5AUlbfUtyIL/nQN/XTj+gFYRSS P7T1wmn7ueI8efKFiNErFsQbvm1Cbn7l9euEbXqg5WTF0DCBBtTu4T048nOgj243SbrQ UeS7pCCzIEZ1aB0iPqgHOa1Yj1LMOdtvELr+rzLDfJDOWb55Ap2inbGrt2lU6sFKlkoX OTR2zKsw2p0UMEGQrOCO0WuvSIZztusS6rI5WXWwCkO0/lFO+bohBBf548Vh2hVZIhNS 3TIg== X-Gm-Message-State: AOAM530zKzpozzQNnBKDAhw1CwJhgb/oJN9hQNwCcvXxDS+VDan+9t6J l16L9zBXK2ZX/7XASopnZF57ZZkDEn0E4TbxFBFps8wE X-Google-Smtp-Source: ABdhPJxOZS2Yjn1srTbusDa8NpzMxjQlJ7VKjgaq339pGUWwJj2O+ElfGTADa5PoIS6jxevzK55oVomYHYR8hr4sA3A= X-Received: by 2002:a63:f946:: with SMTP id q6mr8697818pgk.42.1632583517303; Sat, 25 Sep 2021 08:25:17 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 25 Sep 2021 08:25:16 -0700 In-Reply-To: <87y2fqateb.fsf@pobox.com> (Michael's message of "Sun, 14 Feb 2021 19:42:36 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215450 Archived-At: Michael writes: > Package: cl-macs > Version: 2.02 > > `cl-struct-sequence-type' states that it will "Return `record', > `vector`, or `list' if STRUCT-TYPE is a struct type, nil > otherwise." This is incorrect: it will return `vector' or `list' > if the argument was declared with those types, but if the struct > type was defaulted to `record' it will return nil. If the > argument is not a struct type the function errors. > > This is due to the fact that `cl-struct-define' has the following > clause: > > (if (eq type 'record) > ;; Defstruct using record objects. > (setq type nil)) > > before `type' is passed to `cl--struct-new-class' > (cf. cl-preloaded.el). > > I'm happy to submit a PR updating the docstring for > `cl-struct-sequence-type', but wanted to verify that this is the > desired behavior first (i.e. returning nil if the type is `record'). Does anyone who knows more about this have an opinion here?