From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59923: Error when installing non-existent package add trailing dash character to package name Date: Sun, 11 Dec 2022 10:03:31 -0800 Message-ID: References: <837cyyutcg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14642"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59923-done@debbugs.gnu.org To: Stefan Monnier , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 11 19:04:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4QgU-0003fn-6J for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Dec 2022 19:04:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4QgJ-0005BO-AM; Sun, 11 Dec 2022 13:04:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4QgE-00059Y-KM for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 13:04:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4QgE-0004kr-Ae for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 13:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4QgE-0001IH-5s for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 13:04:02 -0500 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 18:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 59923 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 59923@debbugs.gnu.org, stefankangas@gmail.com, stefankangas@gmail.com Original-Received: via spool by 59923-done@debbugs.gnu.org id=D59923.16707818194960 (code D ref 59923); Sun, 11 Dec 2022 18:04:01 +0000 Original-Received: (at 59923-done) by debbugs.gnu.org; 11 Dec 2022 18:03:39 +0000 Original-Received: from localhost ([127.0.0.1]:47423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4Qfr-0001Hw-5W for submit@debbugs.gnu.org; Sun, 11 Dec 2022 13:03:39 -0500 Original-Received: from mail-oi1-f173.google.com ([209.85.167.173]:39481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4Qfp-0001Hq-Gq for 59923-done@debbugs.gnu.org; Sun, 11 Dec 2022 13:03:37 -0500 Original-Received: by mail-oi1-f173.google.com with SMTP id m204so9305915oib.6 for <59923-done@debbugs.gnu.org>; Sun, 11 Dec 2022 10:03:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=1jxJ9Cvf/3e0tLTRFODyV4dAUabFPsYd7UbhDvXmdE8=; b=NN8WoJMctn52ODy/N3bvdx7hSGqFVj6+1q40EUqhoHNdCtuTsRq+NrOS5lmUTI93LP PZe+HsHLIKZeOvXXgJTIQTWAtjrU3vWyitcxjcTd0jxkssayW6oTuctuvSsOKUuVoK+Y y8tOFqYJcBTLHisTmtU3JKRvv5IHgxqfpvstiJMHeC6Y2g/EcPBdTeSBzgdYQq8E7KEf dNxyahOSpm4bCsNDTYdurq7o9CaXnMy6yumEkGM2A+wyGQt5VDWDaXnjrfVwQDxKeKUX Pw0Dc+fRdjCXF0Mg2YB0IDFRgDD2xyTJwDEY5SbhEmffNBmxB9kEPIiJt9VFbajUSdE+ 0e6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1jxJ9Cvf/3e0tLTRFODyV4dAUabFPsYd7UbhDvXmdE8=; b=duGFfnn2HCSPQi3vY18o/znv8tR5Su01S725scgGspsoEUD4bpjW9Zz+PsmxMPw16J sQYpk95JG/t9fFFklhRPKWpqcd8sSp6E9o1nho42oJp0L5aqeJAJ7zrzgXaul13Aktvs CjKx6Um3+XQOZXuzlrqf3rXCvAm07hAQ2N6OX9tQiT++X8PGv1g50WrMlGHOLlf7l0y4 NdIArc2J28H8U7dKFHJ7E1OMi9yIbh1dXY1+LQBvdEajJH3yauL+46JiqKGTBWQJ6SQC xun/r9jSinYRDa9cUV9Nj5YEBcaVAHxtYXYZfsvYUZmy0DzyFv006rzpBScqeOrIOVl2 Txpw== X-Gm-Message-State: ANoB5pmm4+nKTtHnJLsZyg5DZmHIMjKV1Up//HKjAU/0QOtk25AZ8AW6 aIZBNtW8I6wTA3NAvSDeMsaAux2/q0TMBOFrzPg= X-Google-Smtp-Source: AA0mqf5LjmlkmICopYQ9eqMoBvtabNi7EwrqY6jsh5VQNLf4HZjP9tB+Bfp/9C29eH0v4k+OCychuiU/7sH9GTgrglg= X-Received: by 2002:a05:6808:989:b0:35e:373e:226a with SMTP id a9-20020a056808098900b0035e373e226amr3100378oic.199.1670781811895; Sun, 11 Dec 2022 10:03:31 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 11 Dec 2022 10:03:31 -0800 In-Reply-To: X-Hashcash: 1:20:221211:59923-done@debbugs.gnu.org::XDzvzI+9xRGOhuKD:53A+ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250638 Archived-At: Stefan Monnier writes: >>> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el >>> index a9fd8c741e..4d33311cb7 100644 >>> --- a/lisp/emacs-lisp/package.el >>> +++ b/lisp/emacs-lisp/package.el >>> @@ -1949,8 +1949,10 @@ package-compute-transaction >>> (if (eq next-pkg 'emacs) >>> (error "This package requires Emacs version %s" >>> (package-version-join next-version)) >>> - (error "Package `%s-%s' is unavailable" >>> - next-pkg (package-version-join next-version)))))) >>> + (error (if (not next-version) >>> + (format "Package `%s' is unavailable" next-pkg) >>> + (format "Package `%s' (version %s) is unavailable" >>> + next-pkg (package-version-join >>> next-version)))))))) >>> (setq packages >>> (package-compute-transaction (cons found packages) >>> (package-desc-reqs found) >>> > > LGTM (modulo the wrapping introduced by email quoting, obviously :-) > > > Stefan Thanks, installed (commit 3e349ee119).