From: Stefan Kangas <stefan@marxist.se>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 44980@debbugs.gnu.org
Subject: bug#44980: [PATCH] Fix test for failed uses of lexical vars in byte-compiler
Date: Tue, 1 Dec 2020 06:38:01 -0600 [thread overview]
Message-ID: <CADwFkmnRgcfS1nJJPG15TQ1O3BTsn9ejAxTA1Dh5ePjuHtCXGQ@mail.gmail.com> (raw)
In-Reply-To: <jwv7dq2t88t.fsf-monnier+emacs@gnu.org>
tags 44980 fixed
close 44980
thanks
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> However, the test uses `assq' to check `byte-compile-lexical-variables',
>> but that is not an alist. It seems to me that the correct test would
>> use `memq'.
>>
>> Please see the attached patch that fixes this. It also adds tests.
>>
>> WDYT? Am I missing something?
>
> I have a strong feeling of déjà vu, so I think you're not missing
> anything and it's just an old bug which I thought I had fixed.
OK, thanks. Pushed to master as commit ace6eba036, and closing.
prev parent reply other threads:[~2020-12-01 12:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 3:17 bug#44980: [PATCH] Fix test for failed uses of lexical vars in byte-compiler Stefan Kangas
2020-12-01 5:20 ` Stefan Monnier
2020-12-01 12:38 ` Stefan Kangas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmnRgcfS1nJJPG15TQ1O3BTsn9ejAxTA1Dh5ePjuHtCXGQ@mail.gmail.com \
--to=stefan@marxist.se \
--cc=44980@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).