From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#19565: Emacs vulnerable to endless-data attack (minor) Date: Tue, 8 Oct 2019 18:50:22 +0200 Message-ID: References: <83a7ad3hlf.fsf@gnu.org> <874l0le314.fsf@gnus.org> <831rvo1qlk.fsf@gnu.org> <87zhibyzh8.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="88186"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 19565@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 08 18:51:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iHshb-000Mjf-RB for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Oct 2019 18:51:11 +0200 Original-Received: from localhost ([::1]:58534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHsha-0007YY-Gq for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Oct 2019 12:51:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45482) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHshT-0007YM-SP for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 12:51:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHshS-0005gy-PO for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 12:51:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42570) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iHshS-0005gt-Lf for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 12:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iHshS-0000zu-HW for bug-gnu-emacs@gnu.org; Tue, 08 Oct 2019 12:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Oct 2019 16:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19565 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security Original-Received: via spool by 19565-submit@debbugs.gnu.org id=B19565.15705534423805 (code B ref 19565); Tue, 08 Oct 2019 16:51:02 +0000 Original-Received: (at 19565) by debbugs.gnu.org; 8 Oct 2019 16:50:42 +0000 Original-Received: from localhost ([127.0.0.1]:51391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHsh7-0000zI-RF for submit@debbugs.gnu.org; Tue, 08 Oct 2019 12:50:42 -0400 Original-Received: from mail-pg1-f179.google.com ([209.85.215.179]:38394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iHsh5-0000z4-LC for 19565@debbugs.gnu.org; Tue, 08 Oct 2019 12:50:39 -0400 Original-Received: by mail-pg1-f179.google.com with SMTP id x10so10561992pgi.5 for <19565@debbugs.gnu.org>; Tue, 08 Oct 2019 09:50:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Tgr6jf8dpCM9V5gjAaAqYly3gWMIgw0+qhReVOepk2A=; b=X1ptRFUDvdUOD4ZpGX603XCLuqntz8sUWGmThjzYHIjY0VRzs1jWmVWWsO4KFAWx/4 Ki6spizXB8svnJboI29pvVhIKO3WtKuL54UtcKGE92BcsQTUqu1awC+v5m/Cj/7dlkL5 /Hhv66bqi+bb1J00XXlDcQIYWuyf0e5xjDPBYWiB4rYsJv7LjgXjD+72NR/gXfBcr+CU ZrQjzpS+hTqfTiwcB3UXosq4nON1Kn3EkdQwdaZ3JFxkoJhvIwuIvzqe/wnQU1pY84zZ V/wGllc3i6+GNCpTbvED/CgPL50jePBaL2b23EuoPr5OzrStmr0K5H/h+d655obDavcJ YgkQ== X-Gm-Message-State: APjAAAU0crqlf7xRcgzaARWTQH7UAMUDD6xfI6dUel4TQrMAJ76SX0X+ oODHgH2cDzDqDRDjjHHQ7CpezFuGhTQ4BHLZCGs= X-Google-Smtp-Source: APXvYqyN/i9d8+6p/wKutkj2BlE5Als7kXaKLh+JhPLayQTyWO0UF4o0CoenGZd9qJ428DNOhnEakSm0v1Cz15kViUU= X-Received: by 2002:a63:1310:: with SMTP id i16mr34861166pgl.200.1570553433663; Tue, 08 Oct 2019 09:50:33 -0700 (PDT) In-Reply-To: <87zhibyzh8.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168673 Archived-At: Lars Ingebrigtsen writes: > So bytes/sec, as you suggest, may be the best heuristic. But it should > only kick in after having received a large number of bytes, probably. Maybe this is a stupid question, but what if I'm on a slow connection? Then I would never hit the max? Emacs does have users also in areas of the world where the connections are generally slow, but where AFAIK in addition to that they may have to pay for data. Also consider the use case of a user from the developed world currently on data roaming, with a maximum of 100 MiB of free data... I'm not against the bytes/sec idea, and maybe I don't understand it well enough, but I also think there is a case for being able to specify a maximum number of bytes for a particular connection. For example, the "archive-contents" file is never that big unless something is seriously wrong. The MELPA "archive-contents" file is probably one of the biggest examples in use today and currently weighs in at 1,433,186 bytes. This means that a maximum of, say, 128 MiB should be extremely generous in this case, also allowing for it to grow quite a lot in the next decade or so. Best regards, Stefan Kangas