From: Stefan Kangas <stefan@marxist.se>
To: Sebastian Urban <mrsebastianurban@gmail.com>
Cc: 47671@debbugs.gnu.org
Subject: bug#47671: Small tweaks & fixes for Emacs/GNU ELPA websites
Date: Sun, 25 Apr 2021 20:15:47 -0500 [thread overview]
Message-ID: <CADwFkmnP0T4eke5eHUZ9YNM8j40Xu6Cx7tyUSMKiU63rWH2Vnw@mail.gmail.com> (raw)
In-Reply-To: <b3f03a35-b30f-83e2-c885-bd1aa45285a5@gmail.com>
Sebastian Urban <mrsebastianurban@gmail.com> writes:
> Everything looks good. Thanks, but...
Excellent, thanks for your continued attention to detail.
>> Second, "A Guided Tour of Emacs" website. According to the
>> LAYOUT.CSS (https://www.gnu.org/software/emacs/layout.css):
>>
>> pre { font-family: monospace; (...) font-size: 1.2em; }
>>
>> This is used in the "Download" section, actually. It's missing "Fira
>> Mono", and I don't think font-size is needed there at all.
>
> I'm not sure what happened to the "font-size: 1.2em". I mean, I'm not
> sure whether you skipped it or missed. I know, I forgot to add it to
> the diff...
Sorry, I missed it. I thought you meant that it was merely redundant,
when you were in fact suggesting a visual improvement.
Fixed now; it looks much better.
> Inside "pre" you could also reduce "padding" from 10px to 5px.
I think it looks better with the slightly larger padding here, as I feel
it allows the text room to breathe.
There is of course room for subjective opinion here. FWIW, I took a
look at the GitHub documentation for reference (they presumably have
actual designers doing their stuff) and they use a much larger 16px for
their pre-tags.
> Other than that, I just wonder why "Fira Sans" is not capitalized,
> while "Fira Mono" is?
I noticed that, but didn't bother as the result was the same here.
But we might as well capitalize it, so I did that now.
Thanks again for these suggestions!
next prev parent reply other threads:[~2021-04-26 1:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 10:55 bug#47671: Small tweaks & fixes for Emacs/GNU ELPA websites Sebastian Urban
2021-04-20 14:11 ` Stefan Kangas
2021-04-25 20:41 ` Sebastian Urban
2021-04-26 1:15 ` Stefan Kangas [this message]
2021-04-26 14:19 ` Sebastian Urban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmnP0T4eke5eHUZ9YNM8j40Xu6Cx7tyUSMKiU63rWH2Vnw@mail.gmail.com \
--to=stefan@marxist.se \
--cc=47671@debbugs.gnu.org \
--cc=mrsebastianurban@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).