From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59266: 29.0.50; [PATCH] Add flat-button to set-face-attribute docstring Date: Mon, 14 Nov 2022 22:56:15 -0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5474"; mail-complaints-to="usenet@ciao.gmane.io" To: Gabriel , 59266@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 15 07:57:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oupsd-0001KY-8G for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Nov 2022 07:57:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oupsV-0005CJ-7X; Tue, 15 Nov 2022 01:57:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oupsU-0005CA-EY for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2022 01:57:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oupsU-0003px-5s for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2022 01:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oupsU-0006M8-03 for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2022 01:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Nov 2022 06:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59266 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59266-submit@debbugs.gnu.org id=B59266.166849538324372 (code B ref 59266); Tue, 15 Nov 2022 06:57:01 +0000 Original-Received: (at 59266) by debbugs.gnu.org; 15 Nov 2022 06:56:23 +0000 Original-Received: from localhost ([127.0.0.1]:52642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouprr-0006L2-Fq for submit@debbugs.gnu.org; Tue, 15 Nov 2022 01:56:23 -0500 Original-Received: from mail-oo1-f49.google.com ([209.85.161.49]:34690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouprq-0006Ko-0v for 59266@debbugs.gnu.org; Tue, 15 Nov 2022 01:56:22 -0500 Original-Received: by mail-oo1-f49.google.com with SMTP id j1-20020a4ad181000000b0049e6e8c13b4so1917214oor.1 for <59266@debbugs.gnu.org>; Mon, 14 Nov 2022 22:56:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=iA/s/MkGXsQr2CHIbNBL7qnHbX5K5mRijGzew1lRM2U=; b=PahHMK5AVLve+0vKzwjkfCWi33Z0tKrjFjTWBuousAohvrdO9iyijWNd7U27SFYt1n V9VeEV25VB+83rzWy+D8gARy0TeFPIobDazh9MpobsT6CqaOgMCLQEJcpN4Jge6PiJLZ SJ7M9Zs6zKsnyWwZbLV/9ChgTMG3363e4DdDh0EdrONj7voiqzOfD4UYSXVyEdF4ydXQ rgC/aqKmcqQI7QG3Gf3x65983zXOYS461j8GBerVEMzW8vem1GxeZYsyiEQQFen4HWLX 3SKQFz82xyvTWsS9YAZlELs/DQxwr8exWAHGgXiHnWBqK5vdq55uWEfrZdj89ko/kTkj dyrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iA/s/MkGXsQr2CHIbNBL7qnHbX5K5mRijGzew1lRM2U=; b=DVTAMRflKjFXy548892uU1RVnVUghrrvdfok0Ubvd3poJ+eJ4k8swzG4WzPWgviweC S0zlnibtQ7GnhmUn+xlxJ0ZP2Qgq7loXFoiQoE5h12zB9W7PF3rqd5dqiLSBl/NrAXXK OmdCFhLqS+Qt5ta6/wB/qWgrSsqV+mV7DqwemoDNG6YLCeXpT+ox0G4DiR76UPwCbkWY 0d+1kiRI+JOqTK25Lfwj0vproRcDLBbESqWl6jM7hqEZCxlt/+/4U+pPoWrjRDu1YPVc 24+U+KE1b/qH+ZZ9NlzwvInCUdardfUX/5Ecl9XvJ23/CQ6YAdEdKozJjVWe8U33z2gJ dTiw== X-Gm-Message-State: ANoB5pm/iWiNeb0bMOeV/5Sw28Vdt3JNUlOEJ/U4mPT3WjiTqra8vsZT SWPRxyIp57PngfYhuec4Ug3uOiqJf7IBDbGQ14k= X-Google-Smtp-Source: AA0mqf6QD8uTUYMTZbxfv7bJU9Et8QFpJss6O95L/aTTOw7naf97TC4sH6LbM4+YfrD1PSQw3LutxP9S5/vwQwpig2Y= X-Received: by 2002:a4a:eb95:0:b0:49e:3627:279f with SMTP id d21-20020a4aeb95000000b0049e3627279fmr6929673ooj.5.1668495376149; Mon, 14 Nov 2022 22:56:16 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 14 Nov 2022 22:56:15 -0800 In-Reply-To: X-Hashcash: 1:20:221115:gabriel376@hotmail.com::UG1uEhRXIAO3I17r:1Y1O X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247919 Archived-At: Gabriel writes: >> Thanks for the patch. It copies the text from (info "(elisp)Face >> Attributes") and in that sense looks good. But shouldn't we keep the >> part saying that nil is "the default if the property list doesn't >> contain a style specification"? > > I think the word "omitted" makes it clear that "nil is the default if > the property list doesn't contain a STYLE specification", similar to how > it's phrased in (info "(elisp)Face Attributes"). WDYT? > > "[...] If STYLE is nil, `flat-button' or omitted, draw a 2D box." Ah, right. Yes, I agree. I think this could go in, but let's see if anyone else has any comments first. Thanks.