From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#14148: 24.3; make ido-mode slightly more customizable Date: Wed, 10 Jan 2024 03:20:17 -0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15082"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 14148@debbugs.gnu.org To: Steven Degutis Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 10 12:21:06 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNWdu-0003mX-IB for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jan 2024 12:21:06 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNWdj-0004sP-Te; Wed, 10 Jan 2024 06:20:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNWdi-0004qM-L8 for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 06:20:54 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNWdi-0001DF-Az for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 06:20:54 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNWdp-0002jd-MD for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 06:21:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jan 2024 11:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14148 X-GNU-PR-Package: emacs Original-Received: via spool by 14148-submit@debbugs.gnu.org id=B14148.170488563310454 (code B ref 14148); Wed, 10 Jan 2024 11:21:01 +0000 Original-Received: (at 14148) by debbugs.gnu.org; 10 Jan 2024 11:20:33 +0000 Original-Received: from localhost ([127.0.0.1]:42236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNWdN-0002iY-7g for submit@debbugs.gnu.org; Wed, 10 Jan 2024 06:20:33 -0500 Original-Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:46498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNWdK-0002iI-T1 for 14148@debbugs.gnu.org; Wed, 10 Jan 2024 06:20:31 -0500 Original-Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-557a3ce9942so3966572a12.1 for <14148@debbugs.gnu.org>; Wed, 10 Jan 2024 03:20:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704885617; x=1705490417; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=q+PLgP+MumeMKdD7fq4fzxlByRA/ubOxj3UbBAgSA20=; b=Yj2lRnSzotKd0d0dysIllwFyVmXh63ushQSxzd5y1zI1T86T2uEe/oTYQDdVr7cdYH zAYo1CIyMq/nlqQ4gQYoaePPho5AIZZrHav6RU+sPGHelRtbAEvudDjmuTEgDnpvwiZV E4ET9nN08S/GgvZBJuY2fECETRee5OK9A9KH5jYhaONiP0ei0+UYchpAgjuhlXS0LHUy CKzCCqFwSS6ip0hoUgerrSm8ZHhLm0DTnhN5vBVYYYfCfLOLOU2ZP75dUN+FFvsdY+9f kOaHpe2QPLxW/4afXNeYeCW6k4J8c5OkblJifmZD2dvgqOq92S3mP7KQJIUXO6XDvkc3 rCnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704885617; x=1705490417; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q+PLgP+MumeMKdD7fq4fzxlByRA/ubOxj3UbBAgSA20=; b=AW1m7pgYhca7LqHUUFQA4VF2LwnNlNoqamlVvv8iLdFG82XInrfilNAYxSAMdRJT5D ddUNnmGIAjtHe0U1toytfVejSxvsfeTn0ltejINhDBIRQItJzLtGTmXnIr079VZsyExS 0owLtn9Gn2I15guVZ/YA3jhsuGGysE61Zep4FaMDe4aBLTdN8AghmSz4WCTNYHJd+DE/ yaz6s/r31JU1tVEm/dqpC5C0TDtijn95LyAz0XL+DXbVX8fS67K3RblBuLj2jRoHOi1q saGJtVdWmsRIpTbbXL2LihK8T34Tn1St3HavWtv+35nKFOIQ9n/oRrxoVUgWeEDlndPy rfUg== X-Gm-Message-State: AOJu0YzD4z2Pve4CPdaLugOialWGsBusZpNQgzviXq0fVZc4o3PjBVQr TvnK2EuzUUmumMr8xjgcpXdzoRNH4lMp0WCSmo/CfH7dArIZgQ== X-Google-Smtp-Source: AGHT+IEb3zKHaBJKUOwseU8vIAtI9gVSzN/oACpTGsBdB3gG1J7JKfSD4jwfKR+WmBRGkMa5Ex5GgdKpFC+AFLeO2gQ= X-Received: by 2002:a50:baec:0:b0:555:22c3:4a84 with SMTP id x99-20020a50baec000000b0055522c34a84mr238838ede.51.1704885617540; Wed, 10 Jan 2024 03:20:17 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 10 Jan 2024 03:20:17 -0800 In-Reply-To: (Steven Degutis's message of "Fri, 5 Apr 2013 10:38:17 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277719 Archived-At: Steven Degutis writes: > list appear vertically. However, This is limited for two reasons, both > of which are easy to fix. For one thing, the elements at indices 4 and 5 > of ido-decorations are overloaded, and used in two places when they > really should be separated out into two different pairs of > decorations. Specifically on lines 4573/4575, this should use new > elements, at new indices 11 and 12 (for backwards compatibility), which > default to the same values as the existing elements 4 and 5. Then these > "brackets" can be customized separately (one as a newline and one not) > when displaying vertically. And only when element 11 exists should it > use 11 and 12, otherwise it should fall back to 4 and 5 for backwards > compatibility with anyone who has customized ido-decorations themselves > before this change. Finally, the inner-if on line 4563 has to be wrapped > with an (and (not (ido-show-when-sole-exact-match)) ...) with that > variable created as a defcustom above. This will prevent the sole exact > match from being hidden, which in vertical mode is confusing and seems > to indicate that there no longer remains any matches. I would add the > changelog myself but I'm woefully ignorant on how to do so. There is > already most of the work done in a patch on the devel mailing list in a > post by Stefan Monnier. That was 10 years ago, so I'm reaching out to see if this is still an issue on a modern version of Emacs. Did you try the new fido-mode, for example? If I don't hear back from you within a couple of months, Ill just assume that this has been fixed and close this bug. Thanks in advance.