From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#52954: Rename split-string to string-split Date: Sun, 2 Jan 2022 11:46:37 -0500 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21849"; mail-complaints-to="usenet@ciao.gmane.io" To: 52954@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 02 17:49:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n442n-0005aZ-9x for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Jan 2022 17:49:17 +0100 Original-Received: from localhost ([::1]:56378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n442l-0003TO-CO for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Jan 2022 11:49:15 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n440c-00027h-8f for bug-gnu-emacs@gnu.org; Sun, 02 Jan 2022 11:47:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50211) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n440b-00069c-Um for bug-gnu-emacs@gnu.org; Sun, 02 Jan 2022 11:47:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n440b-0002QL-PU for bug-gnu-emacs@gnu.org; Sun, 02 Jan 2022 11:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jan 2022 16:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52954 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16411420059285 (code B ref -1); Sun, 02 Jan 2022 16:47:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Jan 2022 16:46:45 +0000 Original-Received: from localhost ([127.0.0.1]:33524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n440K-0002Ph-Sr for submit@debbugs.gnu.org; Sun, 02 Jan 2022 11:46:45 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:55630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n440J-0002PZ-Gr for submit@debbugs.gnu.org; Sun, 02 Jan 2022 11:46:43 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n440H-0001p3-W7 for bug-gnu-emacs@gnu.org; Sun, 02 Jan 2022 11:46:43 -0500 Original-Received: from mail-pj1-f43.google.com ([209.85.216.43]:37433) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n440G-000653-Bs for bug-gnu-emacs@gnu.org; Sun, 02 Jan 2022 11:46:41 -0500 Original-Received: by mail-pj1-f43.google.com with SMTP id y16-20020a17090a6c9000b001b13ffaa625so35551602pjj.2 for ; Sun, 02 Jan 2022 08:46:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=FeBKQg7gXJ5x1sPGFe/tUhl3YU/80Yrz/ZlPiin1K8k=; b=LjtmFgBsTPu0dGRGkAeE5+TjZsqTo5T9D++XNfIUzD7q2bXU6jL4ivwfab7p8XE/OA tc9EUXknJqR+LWWnfmchs28AOf5ybx+VLQLaQbplhKix+zxdHR3SJk7hsXUNZlSThQ7x 83G8H+Z493X5MC1WpMg6YmERT8SXMDz0g/kbY6mlhfF2uBlmapyGksQHcTAa4od+cd7H COhbXr/lOk2t0kSxFRb/CmOaH/xs+z22jfA/kYvTT96/gDH8JlRJ8eNwOCGWd2jgbf3x o3m/0hwZgEFs7oMiNbfKA0psTkdffrzkDxymSpv+q3kGXzSGsthdvYgNFoMalNY3HK33 OO1g== X-Gm-Message-State: AOAM531YaDckD83A2lgX+s6ePe92vqB2t3PWLDR7IDkuUOnE7ZlI+C6o EIKs/dPsyk7DX74tHrbdrKY0W7KFKiTyRxroCq/ltKir X-Google-Smtp-Source: ABdhPJwnxu4cs+VcVDGsNmu49eTz3GpQz+GOCm6oqbiDrz3DyHn5SNx34gh+sIQ+ARaXYG/BShOHze780H0GBpcLgk0= X-Received: by 2002:a17:902:ab97:b0:149:8662:1736 with SMTP id f23-20020a170902ab9700b0014986621736mr27932418plr.174.1641141997830; Sun, 02 Jan 2022 08:46:37 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 2 Jan 2022 11:46:37 -0500 Received-SPF: pass client-ip=209.85.216.43; envelope-from=stefankangas@gmail.com; helo=mail-pj1-f43.google.com X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223551 Archived-At: Severity: wishlist The function `split-string' does not follow use the `string-' prefix that we use for many other string functions. How about renaming it and introducing an alias for the old name? IOW, basically the below and the necessary documentation fixes and so on: diff --git a/lisp/subr.el b/lisp/subr.el index 11105c4aa6..a9bd406b63 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -4890,7 +4890,7 @@ split-string-default-separators ;; defaulted, OMIT-NULLS should be treated as t. Simplifying the logical ;; expression leads to the equivalent implementation that if SEPARATORS ;; is defaulted, OMIT-NULLS is treated as t. -(defun split-string (string &optional separators omit-nulls trim) +(defun string-split (string &optional separators omit-nulls trim) "Split STRING into substrings bounded by matches for SEPARATORS. The beginning and end of STRING, and each match for SEPARATORS, are @@ -4969,6 +4969,7 @@ split-string (funcall push-one) (nreverse list))) +(defalias 'split-string #'string-split) ; renamed in 29.1 (defun combine-and-quote-strings (strings &optional separator) "Concatenate the STRINGS, adding the SEPARATOR (default \" \").