From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#6411: Ispell string or comment Date: Wed, 21 Aug 2019 22:57:21 +0200 Message-ID: References: <83r25ejvjm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="35915"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Lennart Borgman , 6411@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 21 23:28:58 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i0YA5-0009EY-Rl for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Aug 2019 23:28:57 +0200 Original-Received: from localhost ([::1]:35548 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0YA3-0005Z1-C8 for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Aug 2019 17:28:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53376) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0Y9F-0004mx-V6 for bug-gnu-emacs@gnu.org; Wed, 21 Aug 2019 17:28:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0Y9D-0003sE-MP for bug-gnu-emacs@gnu.org; Wed, 21 Aug 2019 17:28:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56067) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i0Y9D-0003pt-Fq for bug-gnu-emacs@gnu.org; Wed, 21 Aug 2019 17:28:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i0Xh8-0000zB-8k for bug-gnu-emacs@gnu.org; Wed, 21 Aug 2019 16:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Aug 2019 20:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 6411-submit@debbugs.gnu.org id=B6411.15664210943667 (code B ref 6411); Wed, 21 Aug 2019 20:59:02 +0000 Original-Received: (at 6411) by debbugs.gnu.org; 21 Aug 2019 20:58:14 +0000 Original-Received: from localhost ([127.0.0.1]:36621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0Xg7-0000vd-0d for submit@debbugs.gnu.org; Wed, 21 Aug 2019 16:58:14 -0400 Original-Received: from mail-pl1-f175.google.com ([209.85.214.175]:33267) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0Xfq-0000ug-46 for 6411@debbugs.gnu.org; Wed, 21 Aug 2019 16:57:57 -0400 Original-Received: by mail-pl1-f175.google.com with SMTP id go14so2005638plb.0 for <6411@debbugs.gnu.org>; Wed, 21 Aug 2019 13:57:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m7D+cTwnHBmdyHvfhi6Q1eBcVifwO8KM2sGXc5aMduA=; b=lqGkOGjzmr8TeU0eu79qgZpSepYmJMJ+C5XZnujrwPDYhrPMb0bxuMJ3JfX5wbTtgK 9Jq13TtLa5LbjZi2tEo91WNo4YxwzESj6W+TFW3OrXu8U0yE0oKW3i2AuT2puEaA7KdN nfoDr3KsSWz2uf0VAbf/oM7JNfT8yd8SoOxagwXacAE4Drqr/i6ROYMpujSt3AcVT7+y lh1ucd9xOg+HW6x/sssjD6oRQIL2v8ReQE0eo8jfsKbkx+iElpU7x/DcCiifK0p+ANKe qALLuZ28dCijeBDDWg2x7w1SLRdO0ygqBUYp4YOB3CLq+0afef1Pm7Uu/OBJEbp5imUa xiKA== X-Gm-Message-State: APjAAAUprJOabygCj/Pg2G55Tx2Gl1gdvDx8x0CBXEX5Z1ZHEDDNMp0o wjFQsQ/GHItnRBYC0oGAjQD4VlC7fRQGfS0l2g8= X-Google-Smtp-Source: APXvYqzt7kzRQA6DzoGdnyVaFk4ZIjVbiiXfZ5Yrf8Pm56I5Rlcax6uoOEPvRn/9FPB+Sj0aznyS3y8miXHN95VaYy8= X-Received: by 2002:a17:902:d70a:: with SMTP id w10mr33732502ply.251.1566421054480; Wed, 21 Aug 2019 13:57:34 -0700 (PDT) In-Reply-To: <83r25ejvjm.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165525 Archived-At: tags 6411 - patch quit Eli Zaretskii writes: > > > Here is a suggestion for a function ispell-comment-or-string for spell > > > checking of current comment or string, see attachement. > > > > This patch from 2010 still applies on current master, and it seems to > > work as advertised from my minimal testing. I think it would be a > > good addition. Does anyone object to installing it? > > Sorry, but I happen to think the proposed implementation is somewhat > inelegant: Thanks, many good points that I agree with. I will review the proposed patch more carefully next time beyond just testing that it works. Let's hope someone picks up the ball and provides us with a revised or new patch. If Lennart Borgman doesn't feel up to it after all these years, maybe someone else? Best regards, Stefan Kangas