From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#37420: [PATCH] Recommend against SHA-1 for security-related applications Date: Mon, 16 Sep 2019 23:50:33 +0200 Message-ID: References: <87v9tsv65b.fsf@gnus.org> <87ef0grneg.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000091ba7b0592b29828" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="64491"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37420@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 16 23:56:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i9yyg-000Gc3-Av for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Sep 2019 23:56:10 +0200 Original-Received: from localhost ([::1]:40356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9yyf-000167-9Z for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Sep 2019 17:56:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36620) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9ytk-0004jw-6O for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2019 17:51:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i9yti-00050B-O4 for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2019 17:51:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42423) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i9yti-000505-IR for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2019 17:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i9yti-0006uD-EY for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2019 17:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Sep 2019 21:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37420 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37420-submit@debbugs.gnu.org id=B37420.156867065326520 (code B ref 37420); Mon, 16 Sep 2019 21:51:02 +0000 Original-Received: (at 37420) by debbugs.gnu.org; 16 Sep 2019 21:50:53 +0000 Original-Received: from localhost ([127.0.0.1]:51243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9ytZ-0006tg-Cj for submit@debbugs.gnu.org; Mon, 16 Sep 2019 17:50:53 -0400 Original-Received: from mail-pf1-f181.google.com ([209.85.210.181]:41262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9ytX-0006tS-4u for 37420@debbugs.gnu.org; Mon, 16 Sep 2019 17:50:51 -0400 Original-Received: by mail-pf1-f181.google.com with SMTP id q7so730796pfh.8 for <37420@debbugs.gnu.org>; Mon, 16 Sep 2019 14:50:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C2m1yQ8Lb3902w4Es6cgAlaN0BPFgGNC7RMO+jUPfWU=; b=N1Gd0IElfH9Vyed+yz8V+36Doact1fduFOil253FOFIHIC67L1T/bZmQeJObHLjnlv Xm48Z0ZDSnjmWUXFmOO9MfkSAbrl4sfLNpatUm9/yH0sdYM8654i26Csf+HHqD75Y6dL 002BCHuAvN8l/TcHjT2COLuVunQrp99dh2R9gpfH9TDwkoj8nJtkifEQF6jd8aQsu3mP 939Pvtuu8LArd+WNYxvC1iLgwA/XPS9EadP8ZNC15VE21r7bV7raGwfySazFSfimI+zg 2Qv91QmnGcWVzt93XyJ7g3WAzt+zpsedf58MQQL1lhT+NB9WWjngW7ZLd6P58YudRz9u 4PuA== X-Gm-Message-State: APjAAAXZ/r4A5/hL8KBB4Xd4Xy1DsS1sqil6AUtg2VC6v1qd/bq83q2G XbzOFwypTM4NB1jXMG+JcKkgtGFyLlcn9wI2Bxsmkpxs X-Google-Smtp-Source: APXvYqzMLoQDOe19t9XY6lO7Knxo85wp6ldPsEcHiBC8kxCxl5plbAs5Sdp3UU6I3XLZBGgZ9vZLzpQpjHIcsDk3r3M= X-Received: by 2002:a17:90a:17ab:: with SMTP id q40mr1483577pja.106.1568670645066; Mon, 16 Sep 2019 14:50:45 -0700 (PDT) In-Reply-To: <87ef0grneg.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166594 Archived-At: --00000000000091ba7b0592b29828 Content-Type: text/plain; charset="UTF-8" Lars Ingebrigtsen writes: > Looks good. Thanks. As I was playing around with this a bit more, I also came up with another patch (attached) to be committed on top of the first one. This patch adds tests and makes some minor doc fixes. Best regards, Stefan Kangas --00000000000091ba7b0592b29828 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Add-tests-for-secure-hash-and-improve-doc-string.patch" Content-Disposition: attachment; filename="0001-Add-tests-for-secure-hash-and-improve-doc-string.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k0mxw7yt0 RnJvbSA2NGJhOTVkZDU2NGYyMjkxMGI0OGY4NjQ0ZGI0MDEzZjlmZTY1ZWIxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBNb24sIDE2IFNlcCAyMDE5IDIzOjM5OjU4ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g QWRkIHRlc3RzIGZvciBzZWN1cmUtaGFzaCBhbmQgaW1wcm92ZSBkb2Mgc3RyaW5nCgoqIHNyYy9m bnMuYyAoRnNlY3VyZV9oYXNoX2FsZ29yaXRobXMpOiBGaXggdHlwby4KKEZzZWN1cmVfaGFzaCk6 IEFkZCBhbGdvcml0aG0gbGlzdCB0byBkb2Mgc3RyaW5nLgoqIHRlc3Qvc3JjL2Zucy10ZXN0cy5l bCAodGVzdC1zZWN1cmUtaGFzaCk6IE5ldyB0ZXN0LgotLS0KIHNyYy9mbnMuYyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAxMSArKysrKysrKysrLQogLi4uL2VtYWNz LWxpc3AvcGFja2FnZS1yZXNvdXJjZXMvYXJjaGl2ZS1jb250ZW50cyB8ICA1ICsrKystCiB0ZXN0 L3NyYy9mbnMtdGVzdHMuZWwgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTUgKysrKysr KysrKysrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDI5IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2Zucy5jIGIvc3JjL2Zucy5jCmluZGV4IGRmOTIxZTI4ZjMu LjVmNTNlNTk2YTEgMTAwNjQ0Ci0tLSBhL3NyYy9mbnMuYworKysgYi9zcmMvZm5zLmMKQEAgLTUw ODQsNyArNTA4NCw3IEBAIG1ha2VfZGlnZXN0X3N0cmluZyAoTGlzcF9PYmplY3QgZGlnZXN0LCBp bnQgZGlnZXN0X3NpemUpCiAKIERFRlVOICgic2VjdXJlLWhhc2gtYWxnb3JpdGhtcyIsIEZzZWN1 cmVfaGFzaF9hbGdvcml0aG1zLAogICAgICAgIFNzZWN1cmVfaGFzaF9hbGdvcml0aG1zLCAwLCAw LCAwLAotICAgICAgIGRvYzogLyogUmV0dXJuIGEgbGlzdCBvZiBhbGwgdGhlIHN1cHBvcnRlZCBg c2VjdXJlX2hhc2gnIGFsZ29yaXRobXMuICovKQorICAgICAgIGRvYzogLyogUmV0dXJuIGEgbGlz dCBvZiBhbGwgdGhlIHN1cHBvcnRlZCBgc2VjdXJlLWhhc2gnIGFsZ29yaXRobXMuICovKQogICAo dm9pZCkKIHsKICAgcmV0dXJuIGxpc3QgKFFtZDUsIFFzaGExLCBRc2hhMjI0LCBRc2hhMjU2LCBR c2hhMzg0LCBRc2hhNTEyKTsKQEAgLTUzOTAsNiArNTM5MCwxNSBAQCBERUZVTiAoInNlY3VyZS1o YXNoIiwgRnNlY3VyZV9oYXNoLCBTc2VjdXJlX2hhc2gsIDIsIDUsIDAsCiBBTEdPUklUSE0gaXMg YSBzeW1ib2wgc3BlY2lmeWluZyB0aGUgaGFzaCB0byB1c2U6CiBtZDUsIHNoYTEsIHNoYTIyNCwg c2hhMjU2LCBzaGEzODQgb3Igc2hhNTEyLgogCitUaGVzZSBzeW1ib2xzIGNvcnJlc3BvbmRzIHRv IHRoZSBmb2xsb3dpbmcgaGFzaGluZyBhbGdvcml0aG1zOgorCisgICAgbWQ1ICAgIC0gTUQ1Cisg ICAgc2hhMSAgIC0gU0hBLTEKKyAgICBzaGEyMjQgLSBTSEEtMiAvIFNIQS0yMjQKKyAgICBzaGEy NTYgLSBTSEEtMiAvIFNIQS0zODQKKyAgICBzaGEzODQgLSBTSEEtMiAvIFNIQS0zODQKKyAgICBz aGE1MTIgLSBTSEEtMiAvIFNIQS01MTIKKwogVGhlIHR3byBvcHRpb25hbCBhcmd1bWVudHMgU1RB UlQgYW5kIEVORCBhcmUgcG9zaXRpb25zIHNwZWNpZnlpbmcgZm9yCiB3aGljaCBwYXJ0IG9mIE9C SkVDVCB0byBjb21wdXRlIHRoZSBoYXNoLiAgSWYgbmlsIG9yIG9taXR0ZWQsIHVzZXMgdGhlCiB3 aG9sZSBPQkpFQ1QuCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLXJl c291cmNlcy9hcmNoaXZlLWNvbnRlbnRzIGIvdGVzdC9saXNwL2VtYWNzLWxpc3AvcGFja2FnZS1y ZXNvdXJjZXMvYXJjaGl2ZS1jb250ZW50cwppbmRleCBlMmY5MjMwNGY4Li5mYmJjZGZhNjQwIDEw MDY0NAotLS0gYS90ZXN0L2xpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLXJlc291cmNlcy9hcmNoaXZl LWNvbnRlbnRzCisrKyBiL3Rlc3QvbGlzcC9lbWFjcy1saXNwL3BhY2thZ2UtcmVzb3VyY2VzL2Fy Y2hpdmUtY29udGVudHMKQEAgLTEsOSArMSwxMiBAQAorOzsgUkZDMzMzOSB0aW1lc3RhbXAKKzs7 IExhc3QtVXBkYXRlZDogMjAxNC0wMS0xNlQwNTo0MzozNS4wMDBaCiAoMQogIChzaW1wbGUtc2lu Z2xlIC4KICAgICAgICAgICAgICAgICBbKDEgMykKICAgICAgICAgICAgICAgICAgbmlsICJBIHNp bmdsZS1maWxlIHBhY2thZ2Ugd2l0aCBubyBkZXBlbmRlbmNpZXMiIHNpbmdsZQogICAgICAgICAg ICAgICAgICAoKDp1cmwgLiAiaHR0cDovL2Rvb2RsZXMuYXUiKQotICAgICAgICAgICAgICAgICAg KDprZXl3b3JkcyBxdW90ZSAoImZyb2JuaWNhdGUiKSkpXSkKKyAgICAgICAgICAgICAgICAgICg6 a2V5d29yZHMgcXVvdGUgKCJmcm9ibmljYXRlIikpCisgICAgICAgICAgICAgICAgICAoOmhhc2gg KV0pCiAgKHNpbXBsZS1kZXBlbmQgLgogICAgICAgICAgICAgICAgIFsoMSAwKQogICAgICAgICAg ICAgICAgICAoKHNpbXBsZS1zaW5nbGUgKDEgMykpKSAiQSBzaW5nbGUtZmlsZSBwYWNrYWdlIHdp dGggYSBkZXBlbmRlbmN5LiIgc2luZ2xlXSkKZGlmZiAtLWdpdCBhL3Rlc3Qvc3JjL2Zucy10ZXN0 cy5lbCBiL3Rlc3Qvc3JjL2Zucy10ZXN0cy5lbAppbmRleCA3ZDU2ZGE3N2NmLi41YmU5YTllYjdi IDEwMDY0NAotLS0gYS90ZXN0L3NyYy9mbnMtdGVzdHMuZWwKKysrIGIvdGVzdC9zcmMvZm5zLXRl c3RzLmVsCkBAIC04NTgsNCArODU4LDE5IEBAIHRlc3QtaGFzaC1mdW5jdGlvbi10aGF0LW11dGF0 ZXMtaGFzaC10YWJsZQogICAgICAgIChwdXRoYXNoIGsgayBoKSkpCiAgICAgKHNob3VsZCAoPSAx MDAgKGhhc2gtdGFibGUtY291bnQgaCkpKSkpCiAKKyhlcnQtZGVmdGVzdCB0ZXN0LXNlY3VyZS1o YXNoICgpCisgIChzaG91bGQgKGVxdWFsIChzZWN1cmUtaGFzaCAnbWQ1ICAgICJmb29iYXIiKSAi Mzg1OGY2MjIzMGFjM2M5MTVmMzAwYzY2NDMxMmM2M2YiKSkKKyAgKHNob3VsZCAoZXF1YWwgKHNl Y3VyZS1oYXNoICdzaGExICAgImZvb2JhciIpICI4ODQzZDdmOTI0MTYyMTFkZTllYmI5NjNmZjRj ZTI4MTI1OTMyODc4IikpCisgIChzaG91bGQgKGVxdWFsIChzZWN1cmUtaGFzaCAnc2hhMjI0ICJm b29iYXIiKSAoY29uY2F0ICJkZTc2YzNlNTY3ZmNhOWQyNDZmNWY4ZDNiMmU3MDRhMyIKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIjhjM2M1 ZTI1ODk4OGFiNTI1Zjk0MWRiOCIpKSkKKyAgKHNob3VsZCAoZXF1YWwgKHNlY3VyZS1oYXNoICdz aGEyNTYgImZvb2JhciIpIChjb25jYXQgImMzYWI4ZmYxMzcyMGU4YWQ5MDQ3ZGQzOTQ2NmIzYzg5 IgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAiNzRlNTkyYzJmYTM4M2Q0YTM5NjA3MTRjYWVmMGM0ZjIiKSkpCisgIChzaG91bGQgKGVxdWFs IChzZWN1cmUtaGFzaCAnc2hhMzg0ICJmb29iYXIiKSAoY29uY2F0ICIzYzljMzBkOWY2NjVlNzRk NTE1Yzg0Mjk2MGQ0YTQ1MSIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgImM4M2EwMTI1ZmQzZGU3MzkyZDdiMzcyMzFhZjEwYzcyIgorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiZWE1 OGFlZGZjZGY4OWE1NzY1YmY5MDJhZjkzZWNmMDYiKSkpCisgIChzaG91bGQgKGVxdWFsIChzZWN1 cmUtaGFzaCAnc2hhNTEyICJmb29iYXIiKSAoY29uY2F0ICIwYTUwMjYxZWJkMWEzOTBmZWQyYmYz MjZmMjY3M2MxNCIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIjU1ODJhNjM0MmQ1MjMyMDQ5NzNkMDIxOTMzN2Y4MTYxIgorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiNmE4MDY5YjAx MjU4N2NmNTYzNWY2OTI1ZjFiNTZjMzYiCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICIwMjMwYzE5YjI3MzUwMGVlMDEzZTAzMDYwMWJmMjQy NSIpKSkpCisKIChwcm92aWRlICdmbnMtdGVzdHMpCi0tIAoyLjIwLjEKCg== --00000000000091ba7b0592b29828--