From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#37420: [PATCH] Recommend against SHA-1 for security-related applications Date: Mon, 16 Sep 2019 22:29:43 +0200 Message-ID: References: <87v9tsv65b.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000077fa7f0592b17751" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="245065"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37420@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 16 22:31:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i9xeV-0011aG-3o for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Sep 2019 22:31:15 +0200 Original-Received: from localhost ([::1]:39820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9xeU-0003Z7-1j for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Sep 2019 16:31:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53052) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9xeK-0003Yo-I2 for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2019 16:31:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i9xeI-0000yq-Ri for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2019 16:31:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42318) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i9xeI-0000yj-NQ for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2019 16:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i9xeI-0007aC-K2 for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2019 16:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Sep 2019 20:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37420 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37420-submit@debbugs.gnu.org id=B37420.156866580425382 (code B ref 37420); Mon, 16 Sep 2019 20:31:02 +0000 Original-Received: (at 37420) by debbugs.gnu.org; 16 Sep 2019 20:30:04 +0000 Original-Received: from localhost ([127.0.0.1]:51139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9xdL-0006ap-Jb for submit@debbugs.gnu.org; Mon, 16 Sep 2019 16:30:04 -0400 Original-Received: from mail-pg1-f181.google.com ([209.85.215.181]:35955) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9xdI-0006ZJ-PX for 37420@debbugs.gnu.org; Mon, 16 Sep 2019 16:30:01 -0400 Original-Received: by mail-pg1-f181.google.com with SMTP id m29so642476pgc.3 for <37420@debbugs.gnu.org>; Mon, 16 Sep 2019 13:30:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m3tMGiVwOV9IN1PX3CO9kN07KOkEvq/kgb7bI+ArZDg=; b=crLvXt4hjA/GsthYIi1pvSg8P418LV52Et1znQSEUNM+tdHYawltaraKDg3szz9DhB QKSI86tgA+DXOKwPEomp1gxZ/FYdahAYWlEfmYRs5Lzbbg+yi/SJhfg1CfA2ZrMLDhaa UEoOxBVT1/SdFJr94ldxVGId8DrIZftyqJF/n0pfvdPzzEwfG9Pt3ey5o9pRU8341WrM Lrd0jetHtiKUAEX90HSpDenUyI3JfDAqEYswY7ZksklDAVFTZKeEigP2ZiBGR6tMbUdy 19gJn6rqY0tSdifSb36A8fYNmjSDI7/4kQ3Q+pMEbPSbwflgqhaPcAxG/rF8xQWqJn3d KHog== X-Gm-Message-State: APjAAAXkdsBEg+ppakYgS/AfLM58ad+euSFt3UWQUQ5VkTHY2AJq3Ujf Y0alWApHvF4MDm+XWhW1k5vBMot1XVIt4b60Qus= X-Google-Smtp-Source: APXvYqyvRuFDx7ywN3cWJg21emj35BgnVgkJAm95wVKxESUa43mIjZGumPyW8BqBiUeXm8JC0gOkUApgvDF6Ay+1d3I= X-Received: by 2002:a17:90a:8d0c:: with SMTP id c12mr1087264pjo.119.1568665794762; Mon, 16 Sep 2019 13:29:54 -0700 (PDT) In-Reply-To: <87v9tsv65b.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166582 Archived-At: --00000000000077fa7f0592b17751 Content-Type: text/plain; charset="UTF-8" Lars Ingebrigtsen writes: > > We should clarify that these attacks are not only theoretical, and > > actively discourage using it in security-related applications in the > > Elisp Manual. The attached patch is an attempt at doing that. > > Looks good to me. Thanks. I thought a bit more about this, and would like to suggest the attached slightly more ambitious patch which also recommends against them in the doc strings of sha1, md5 and secure-hash. (I also changed so the doc strings consistently say SHA-1 instead of SHA1, which seems to be more correct AFAICT.) Best regards, Stefan Kangas --00000000000077fa7f0592b17751 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Recommend-against-SHA-1-and-MD5-for-security.patch" Content-Disposition: attachment; filename="0001-Recommend-against-SHA-1-and-MD5-for-security.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k0mv0e1h0 RnJvbSA5YTQ5ZmZiOGVjNWVkZTA1YmM2ZDcxMDAwNjZkOWVkYTdlZmRkZTQ2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBNb24sIDE2IFNlcCAyMDE5IDEwOjQ1OjE0ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g UmVjb21tZW5kIGFnYWluc3QgU0hBLTEgYW5kIE1ENSBmb3Igc2VjdXJpdHkKCiogZG9jL2xpc3By ZWYvdGV4dC50ZXhpIChDaGVja3N1bS9IYXNoKToKKiBzcmMvZm5zLmMgKEZtZDUsIEZzZWN1cmVf aGFzaCk6CiogbGlzcC9zdWJyLmVsIChzaGExKTogRG9jIGZpeCB0byByZWNvbW1lbmQgYWdhaW5z dCBTSEEtMSBhbmQgTUQ1IGZvcgpzZWN1cml0eS1yZWxhdGVkIGFwcGxpY2F0aW9ucywgc2luY2Ug dGhleSBhcmUgbm90IGNvbGxpc2lvbgpyZXNpc3RhbnQuICAoQnVnIzM3NDIwKQotLS0KIGRvYy9s aXNwcmVmL3RleHQudGV4aSB8IDEyICsrKysrKy0tLS0tLQogbGlzcC9zdWJyLmVsICAgICAgICAg IHwgIDggKysrKysrLS0KIHNyYy9mbnMuYyAgICAgICAgICAgICB8IDExICsrKysrKysrKy0tCiAz IGZpbGVzIGNoYW5nZWQsIDIxIGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL2RvYy9saXNwcmVmL3RleHQudGV4aSBiL2RvYy9saXNwcmVmL3RleHQudGV4aQppbmRl eCA3Y2U1NGY1OWM2Li41NGI4OWNmZjVhIDEwMDY0NAotLS0gYS9kb2MvbGlzcHJlZi90ZXh0LnRl eGkKKysrIGIvZG9jL2xpc3ByZWYvdGV4dC50ZXhpCkBAIC00NzEwLDEyICs0NzEwLDEyIEBAIENo ZWNrc3VtL0hhc2gKIFNIQS0xLCBTSEEtMiwgU0hBLTIyNCwgU0hBLTI1NiwgU0hBLTM4NCBhbmQg U0hBLTUxMi4gIE1ENSBpcyB0aGUKIG9sZGVzdCBvZiB0aGVzZSBhbGdvcml0aG1zLCBhbmQgaXMg Y29tbW9ubHkgdXNlZCBpbiBAZGZue21lc3NhZ2UKIGRpZ2VzdHN9IHRvIGNoZWNrIHRoZSBpbnRl Z3JpdHkgb2YgbWVzc2FnZXMgdHJhbnNtaXR0ZWQgb3ZlciBhCi1uZXR3b3JrLiAgTUQ1IGlzIG5v dCBjb2xsaXNpb24gcmVzaXN0YW50IChpLmUuLCBpdCBpcyBwb3NzaWJsZSB0bwotZGVsaWJlcmF0 ZWx5IGRlc2lnbiBkaWZmZXJlbnQgcGllY2VzIG9mIGRhdGEgd2hpY2ggaGF2ZSB0aGUgc2FtZSBN RDUKLWhhc2gpLCBzbyB5b3Ugc2hvdWxkIG5vdCB1c2VkIGl0IGZvciBhbnl0aGluZyBzZWN1cml0 eS1yZWxhdGVkLiAgQQotc2ltaWxhciB0aGVvcmV0aWNhbCB3ZWFrbmVzcyBhbHNvIGV4aXN0cyBp biBTSEEtMS4gIFRoZXJlZm9yZSwgZm9yCi1zZWN1cml0eS1yZWxhdGVkIGFwcGxpY2F0aW9ucyB5 b3Ugc2hvdWxkIHVzZSB0aGUgb3RoZXIgaGFzaCB0eXBlcywKLXN1Y2ggYXMgU0hBLTIuCituZXR3 b3JrLiAgTUQ1IGFuZCBTSEEtMSBhcmUgbm90IGNvbGxpc2lvbiByZXNpc3RhbnQgKGkuZS4sIGl0 IGlzCitwb3NzaWJsZSB0byBkZWxpYmVyYXRlbHkgZGVzaWduIGRpZmZlcmVudCBwaWVjZXMgb2Yg ZGF0YSB3aGljaCBoYXZlCit0aGUgc2FtZSBNRDUgb3IgU0hBLTEgaGFzaCksIHNvIHlvdSBzaG91 bGQgbm90IHVzZSB0aGVtIGZvciBhbnl0aGluZworc2VjdXJpdHktcmVsYXRlZC4gIEZvciBzZWN1 cml0eS1yZWxhdGVkIGFwcGxpY2F0aW9ucyB5b3Ugc2hvdWxkIHVzZQordGhlIG90aGVyIGhhc2gg dHlwZXMsIHN1Y2ggYXMgU0hBLTIgKGUuZy4gQGNvZGV7c2hhMzg0fSBvcgorQGNvZGV7c2hhNTEy fSkuCiAKIEBkZWZ1biBzZWN1cmUtaGFzaC1hbGdvcml0aG1zCiBUaGlzIGZ1bmN0aW9uIHJldHVy bnMgYSBsaXN0IG9mIHN5bWJvbHMgcmVwcmVzZW50aW5nIGFsZ29yaXRobXMgdGhhdApkaWZmIC0t Z2l0IGEvbGlzcC9zdWJyLmVsIGIvbGlzcC9zdWJyLmVsCmluZGV4IDBiNDdkYTg4NGIuLjQ1Yjk5 YTgyZDIgMTAwNjQ0Ci0tLSBhL2xpc3Avc3Vici5lbAorKysgYi9saXNwL3N1YnIuZWwKQEAgLTMx MjAsMTEgKzMxMjAsMTUgQEAgZmllbGQtYXQtcG9zCiAgICAgICByYXctZmllbGQpKSkKIAogKGRl ZnVuIHNoYTEgKG9iamVjdCAmb3B0aW9uYWwgc3RhcnQgZW5kIGJpbmFyeSkKLSAgIlJldHVybiB0 aGUgU0hBMSAoU2VjdXJlIEhhc2ggQWxnb3JpdGhtKSBvZiBhbiBPQkpFQ1QuCisgICJSZXR1cm4g dGhlIFNIQS0xIChTZWN1cmUgSGFzaCBBbGdvcml0aG0pIG9mIGFuIE9CSkVDVC4KIE9CSkVDVCBp cyBlaXRoZXIgYSBzdHJpbmcgb3IgYSBidWZmZXIuICBPcHRpb25hbCBhcmd1bWVudHMgU1RBUlQg YW5kCiBFTkQgYXJlIGNoYXJhY3RlciBwb3NpdGlvbnMgc3BlY2lmeWluZyB3aGljaCBwb3J0aW9u IG9mIE9CSkVDVCBmb3IKIGNvbXB1dGluZyB0aGUgaGFzaC4gIElmIEJJTkFSWSBpcyBub24tbmls LCByZXR1cm4gYSBzdHJpbmcgaW4gYmluYXJ5Ci1mb3JtLiIKK2Zvcm0uCisKK05vdGUgdGhhdCBT SEEtMSBpcyBub3QgY29sbGlzaW9uIHJlc2lzdGFudCBhbmQgc2hvdWxkIG5vdCBiZSB1c2VkCitm b3IgYW55dGhpbmcgc2VjdXJpdHktcmVsYXRlZC4gIFNlZSBgc2VjdXJlLWhhc2gnIGZvcgorYWx0 ZXJuYXRpdmVzLiIKICAgKHNlY3VyZS1oYXNoICdzaGExIG9iamVjdCBzdGFydCBlbmQgYmluYXJ5 KSkKIAogKGRlZnVuIGZ1bmN0aW9uLWdldCAoZiBwcm9wICZvcHRpb25hbCBhdXRvbG9hZCkKZGlm ZiAtLWdpdCBhL3NyYy9mbnMuYyBiL3NyYy9mbnMuYwppbmRleCBkZjkyMWUyOGYzLi4yMDA0N2Jl NjNkIDEwMDY0NAotLS0gYS9zcmMvZm5zLmMKKysrIGIvc3JjL2Zucy5jCkBAIC01Mzc5LDcgKzUz NzksMTAgQEAgREVGVU4gKCJtZDUiLCBGbWQ1LCBTbWQ1LCAxLCA1LCAwLAogY29tbWFuZCBgcHJl ZmVyLWNvZGluZy1zeXN0ZW0nKSBpcyB1c2VkLgogCiBJZiBOT0VSUk9SIGlzIG5vbi1uaWwsIHNp bGVudGx5IGFzc3VtZSB0aGUgYHJhdy10ZXh0JyBjb2RpbmcgaWYgdGhlCi1ndWVzc3dvcmsgZmFp bHMuICBOb3JtYWxseSwgYW4gZXJyb3IgaXMgc2lnbmFsZWQgaW4gc3VjaCBjYXNlLiAgKi8pCitn dWVzc3dvcmsgZmFpbHMuICBOb3JtYWxseSwgYW4gZXJyb3IgaXMgc2lnbmFsZWQgaW4gc3VjaCBj YXNlLgorCitOb3RlIHRoYXQgTUQ1IGlzIG5vdCBjb2xsaXNpb24gcmVzaXN0YW50IGFuZCBzaG91 bGQgbm90IGJlIHVzZWQgZm9yCithbnl0aGluZyBzZWN1cml0eS1yZWxhdGVkLiAgU2VlIGBzZWN1 cmUtaGFzaCcgZm9yIGFsdGVybmF0aXZlcy4gICovKQogICAoTGlzcF9PYmplY3Qgb2JqZWN0LCBM aXNwX09iamVjdCBzdGFydCwgTGlzcF9PYmplY3QgZW5kLCBMaXNwX09iamVjdCBjb2Rpbmdfc3lz dGVtLCBMaXNwX09iamVjdCBub2Vycm9yKQogewogICByZXR1cm4gc2VjdXJlX2hhc2ggKFFtZDUs IG9iamVjdCwgc3RhcnQsIGVuZCwgY29kaW5nX3N5c3RlbSwgbm9lcnJvciwgUW5pbCk7CkBAIC01 Mzk2LDcgKzUzOTksMTEgQEAgREVGVU4gKCJzZWN1cmUtaGFzaCIsIEZzZWN1cmVfaGFzaCwgU3Nl Y3VyZV9oYXNoLCAyLCA1LCAwLAogCiBUaGUgZnVsbCBsaXN0IG9mIGFsZ29yaXRobXMgY2FuIGJl IG9idGFpbmVkIHdpdGggYHNlY3VyZS1oYXNoLWFsZ29yaXRobXMnLgogCi1JZiBCSU5BUlkgaXMg bm9uLW5pbCwgcmV0dXJucyBhIHN0cmluZyBpbiBiaW5hcnkgZm9ybS4gICovKQorSWYgQklOQVJZ IGlzIG5vbi1uaWwsIHJldHVybnMgYSBzdHJpbmcgaW4gYmluYXJ5IGZvcm0uCisKK05vdGUgdGhh dCBNRDUgYW5kIFNIQS0xIGFyZSBub3QgY29sbGlzaW9uIHJlc2lzdGFudCBhbmQgc2hvdWxkIG5v dCBiZQordXNlZCBmb3IgYW55dGhpbmcgc2VjdXJpdHktcmVsYXRlZC4gIFVzZSBvbmUgb2YgdGhl IG90aGVyIGhhc2ggdHlwZXMKK2ZvciBzZWN1cml0eS1yZWxhdGVkIGFwcGxpY2F0aW9ucy4gICov KQogICAoTGlzcF9PYmplY3QgYWxnb3JpdGhtLCBMaXNwX09iamVjdCBvYmplY3QsIExpc3BfT2Jq ZWN0IHN0YXJ0LCBMaXNwX09iamVjdCBlbmQsIExpc3BfT2JqZWN0IGJpbmFyeSkKIHsKICAgcmV0 dXJuIHNlY3VyZV9oYXNoIChhbGdvcml0aG0sIG9iamVjdCwgc3RhcnQsIGVuZCwgUW5pbCwgUW5p bCwgYmluYXJ5KTsKLS0gCjIuMjAuMQoK --00000000000077fa7f0592b17751--