From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#45012: 27.1.50; Emacs 27.1 release archive missing emacs-module.h Date: Mon, 11 Oct 2021 05:36:25 -0700 Message-ID: References: <83v9dkf594.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16366"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: Paul Eggert , 45012@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 11 14:38:32 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mZuZc-00044p-9Y for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Oct 2021 14:38:32 +0200 Original-Received: from localhost ([::1]:34176 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mZuZb-0008Dt-8j for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Oct 2021 08:38:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mZuYB-0007B4-9p for bug-gnu-emacs@gnu.org; Mon, 11 Oct 2021 08:37:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45468) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mZuYB-0004Dq-0S for bug-gnu-emacs@gnu.org; Mon, 11 Oct 2021 08:37:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mZuYA-0006rV-Uh for bug-gnu-emacs@gnu.org; Mon, 11 Oct 2021 08:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Oct 2021 12:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45012 X-GNU-PR-Package: emacs Original-Received: via spool by 45012-submit@debbugs.gnu.org id=B45012.163395579326308 (code B ref 45012); Mon, 11 Oct 2021 12:37:02 +0000 Original-Received: (at 45012) by debbugs.gnu.org; 11 Oct 2021 12:36:33 +0000 Original-Received: from localhost ([127.0.0.1]:57012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZuXh-0006qF-Ft for submit@debbugs.gnu.org; Mon, 11 Oct 2021 08:36:33 -0400 Original-Received: from mail-pl1-f175.google.com ([209.85.214.175]:33749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZuXf-0006pu-FG for 45012@debbugs.gnu.org; Mon, 11 Oct 2021 08:36:32 -0400 Original-Received: by mail-pl1-f175.google.com with SMTP id a11so11282714plm.0 for <45012@debbugs.gnu.org>; Mon, 11 Oct 2021 05:36:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=kiQCTi7GfLJMDgOy84XhbHWgvueh5LwJykuwECZJYpo=; b=Xv49G40O9WXUfL+zNebGhVaSaeVTvlDbaIMGXZctD9j+CitHxdjMq/Ez22LwAhYJfD +OTboA4IzDVcWaEbmMN99Y2fWdhfgN2/iaXA7RqKTcvXPD97aLiZ9W72s8eHgt7bFjjV ABuIpoRaU03p5w+a3YWJ+1I3Lu4q5bJ7AlWCwLaiti67Ff2mijZ65E5v0D+nPSihIwof I47u4bO6PI+AOz8z5yhZa74LLmSmUEW3C98hWNgiS+MOBkkaqj4SpBbQwoO3Qxtfnh5e JV1q09DJlWJmbIBbDDuCiphjJmUFK4ylomZO7Ouv8W8DTSHDn0gnffe6nxrd1XUpryqD EqWA== X-Gm-Message-State: AOAM530rKPTOEqVn5a/Ry001Ps1xQAXu9ZqJY+VHK/t1euucsHnVtBjT qisUNB8fZvbraTq9Q6dWfYrdtiLOOSrvLEYAT30= X-Google-Smtp-Source: ABdhPJwqvLW9BexBJkVPJbRA07DQZcwIqc4aN7YcqnKFGf3mFEOy1z70I/1yQXqOJlysObCV4zMRqX+l79wan4HYJp4= X-Received: by 2002:a17:90a:c70d:: with SMTP id o13mr12359473pjt.143.1633955785874; Mon, 11 Oct 2021 05:36:25 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 11 Oct 2021 05:36:25 -0700 In-Reply-To: (Philipp Stephani's message of "Wed, 2 Dec 2020 19:11:44 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216897 Archived-At: Philipp Stephani writes: > Am Mi., 2. Dez. 2020 um 19:10 Uhr schrieb Eli Zaretskii : >> >> > From: Philipp Stephani >> > Date: Wed, 02 Dec 2020 18:52:26 +0100 >> > >> > The release archive for Emacs 27.1 as distributed on ftp.gnu.org is >> > missing the emacs-module.h header. >> >> This happens because emacs-module.h was removed from make-dist, in >> this commit: >> >> commit 1043cd30acffcc0b61da4a80dcf3f8a5ac459267 >> Author: Paul Eggert >> AuthorDate: Sat Jun 8 14:08:05 2019 -0700 >> Commit: Paul Eggert >> CommitDate: Sat Jun 8 14:42:10 2019 -0700 >> >> Fix out-of-source make-dist problems >> >> Problem with jisx2131-filter reported by Phillip Lord in: >> https://lists.gnu.org/r/emacs-devel/2019-06/msg00147.html >> * admin/charsets/Makefile.in (SED_SCRIPT): >> Put it in $(srcdir), which is not necessarily the working directory. >> ($(SED_SCRIPT)): Rename from jisx2131-filter. All uses changed. >> (clean): Do not remove SED_SCRIPT. >> (extraclean): Remove it here instead. >> * make-dist (possibly_non_vc_files): Remove src/emacs-module.h. >> Although it is portable and could be distributed in the tarball, >> it's too much hassle to do that, so let each builder make it. >> >> Wasn't there some discussion about the problems with distributing it, >> as it is not entirely portable? > > If so, then we need to fix that. emacs-module.h must be 100% portable. Paul, do you have any opinion here? The discussion shows that Eli thought at the time that it's not really worth doing much about this.