unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: rgm@gnu.org, monnier@iro.umontreal.ca, 46472@debbugs.gnu.org
Subject: bug#46472: Make lisp/mail/uce.el obsolete
Date: Sat, 16 Oct 2021 08:48:55 -0400	[thread overview]
Message-ID: <CADwFkmnK1Uec4DV6ReSNg3eVKaejxBkZ3Mak214sb9Jt7V8A0A@mail.gmail.com> (raw)
In-Reply-To: <837deek1jw.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> This should pop only once per Emacs session, not each time the command
> is invoked.

Thanks, I believe all your comments are fixed in the attached.

[-- Attachment #2: 0001-Recommend-against-using-uce.el.patch --]
[-- Type: text/x-diff, Size: 2632 bytes --]

From bc85fc30ba94b1166fc526c7bae2b373dcecaa49 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefan@marxist.se>
Date: Sat, 16 Oct 2021 14:39:04 +0200
Subject: [PATCH] Recommend against using uce.el

* lisp/mail/uce.el (uce-reply-to-uce): Recommend against its use on
the first invocation.  (Bug#46472)
---
 lisp/mail/uce.el | 32 +++++++++++++++++++++++++++++++-
 1 file changed, 31 insertions(+), 1 deletion(-)

diff --git a/lisp/mail/uce.el b/lisp/mail/uce.el
index b07004de38..4347ff1402 100644
--- a/lisp/mail/uce.el
+++ b/lisp/mail/uce.el
@@ -30,6 +30,9 @@
 ;; uce-reply-to-uce.  Please let me know about your changes so I can
 ;; incorporate them.  I'd appreciate it.
 
+;; NOTE: We don't recommend using this feature; see the message in
+;; 'uce-reply-to-uce' for the reasons.
+
 ;; The command uce-reply-to-uce, if called when the current message
 ;; buffer is a UCE, will setup a reply *mail* buffer as follows.  It
 ;; scans the full headers of the message for: 1) the normal return
@@ -213,6 +216,8 @@ rmail-buffer
 (declare-function rmail-maybe-set-message-counters "rmail" ())
 (declare-function rmail-toggle-header "rmail" (&optional arg))
 
+(defvar uce--usage-warning-displayed nil)
+
 ;;;###autoload
 (defun uce-reply-to-uce (&optional _ignored)
   "Compose a reply to unsolicited commercial email (UCE).
@@ -358,7 +363,32 @@ uce-reply-to-uce
       ;; Run hooks before we leave buffer for editing.  Reasonable usage
       ;; might be to set up special key bindings, replace standard
       ;; functions in mail-mode, etc.
-      (run-hooks 'mail-setup-hook 'uce-setup-hook))))
+      (run-hooks 'mail-setup-hook 'uce-setup-hook)))
+  (unless uce--usage-warning-displayed
+    (setq uce--usage-warning-displayed t)
+    (pop-to-buffer (get-buffer-create "uce-reply-to-uce warning"))
+    (insert "\
+-- !!! NOTE !!! ---------------------------------------------
+
+Replying to spam is at best pointless, but most likely actively
+harmful.
+
+- You will confirm that your email address is valid, thus ensuring
+  you get more spam.
+
+- You will leak information and open yourself up for further
+  attack.  For example, they could use your \"geolocation\" to find
+  your home address and phone number.
+
+- The sender address is likely fake.
+
+- You help them refine their methods of spamming.
+
+Therefore, we strongly recommend that you do not use this package.
+Use a spam filter instead, or just delete the spam.
+
+-------------------------------------------------------------
+")))
 
 (defun uce-insert-ranting (&optional _ignored)
   "Insert text of the usual reply to UCE into current buffer."
-- 
2.30.2


  reply	other threads:[~2021-10-16 12:48 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-12 21:58 bug#46472: Make lisp/mail/uce.el obsolete Stefan Kangas
2021-02-13  7:58 ` Eli Zaretskii
2021-02-13 12:25   ` Stefan Kangas
2021-02-13 14:00     ` Eli Zaretskii
2021-03-04 19:27       ` Glenn Morris
2021-03-04 21:12         ` Eli Zaretskii
2021-03-06 17:14           ` Stefan Kangas
2021-03-06 17:25             ` Eli Zaretskii
2022-06-17 13:07         ` Lars Ingebrigtsen
2021-10-12  4:33       ` Stefan Kangas
2021-10-12 13:52         ` Eli Zaretskii
2021-10-12 16:12           ` Stefan Kangas
2021-10-12 16:44             ` Eli Zaretskii
2021-10-12 17:29               ` Stefan Kangas
2021-10-12 18:50                 ` Eli Zaretskii
2021-10-14 20:45                   ` Stefan Kangas
2021-10-15  6:12                     ` Eli Zaretskii
2021-10-15  8:50                       ` Stefan Kangas
2021-10-15 10:46                         ` Eli Zaretskii
2021-10-16 12:48                           ` Stefan Kangas [this message]
2021-10-16 12:50                             ` Eli Zaretskii
2021-10-17 23:56                               ` Stefan Kangas
2021-10-16 12:32                       ` Stefan Kangas
2021-03-03 21:22   ` Stefan Monnier
2021-03-04  3:39     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmnK1Uec4DV6ReSNg3eVKaejxBkZ3Mak214sb9Jt7V8A0A@mail.gmail.com \
    --to=stefan@marxist.se \
    --cc=46472@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).