From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59544: [PATCH] Fixed lib-src/etags.c command execute vulnerability Date: Fri, 25 Nov 2022 00:56:32 -0800 Message-ID: References: <837czkw7sl.fsf@gnu.org> <8335a8w643.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20595"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59544 <59544@debbugs.gnu.org>, Eli Zaretskii To: lux Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 25 09:57:47 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyUWo-00055r-9u for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Nov 2022 09:57:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyUW8-0005fc-8U; Fri, 25 Nov 2022 03:57:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyUW7-0005eS-HQ for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 03:57:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyUW7-0007DV-7f for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 03:57:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyUW6-000086-Ar for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 03:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Nov 2022 08:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59544 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security patch Original-Received: via spool by 59544-submit@debbugs.gnu.org id=B59544.1669366608457 (code B ref 59544); Fri, 25 Nov 2022 08:57:02 +0000 Original-Received: (at 59544) by debbugs.gnu.org; 25 Nov 2022 08:56:48 +0000 Original-Received: from localhost ([127.0.0.1]:33458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyUVs-00007E-1Q for submit@debbugs.gnu.org; Fri, 25 Nov 2022 03:56:48 -0500 Original-Received: from mail-ot1-f52.google.com ([209.85.210.52]:36648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyUVh-00006c-Uk for 59544@debbugs.gnu.org; Fri, 25 Nov 2022 03:56:46 -0500 Original-Received: by mail-ot1-f52.google.com with SMTP id l42-20020a9d1b2d000000b0066c6366fbc3so2271552otl.3 for <59544@debbugs.gnu.org>; Fri, 25 Nov 2022 00:56:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=2NB1qQZQYSd9cmg6hv/iGSHwsxrNu/Ndy4onKkeFGNU=; b=FizytMESsIiH+gfGwvRj5aKkWWOQROep+aFay80D29o1K86xZUNtykGIx5Ah93OBvs PQRpspxx0iyxOf9TRyWUU1Jn0uRTOATbfIpIvMdESaum88YfXx2qDDdXn7XpyU6CFr35 aGUnEBkKE2hV2d+mBPXIgp5hbRoZPJpmURhHKiRfoewbUBn3rzwRGTTwKEKrZognLNWo JLBRyz6cozS7rjOZLRXYDCpoqlhBYYuZgq9UaxX7Hzg6x52o7zl+nal5kAsEt/z7C2SK yRtJj7ICpKJW2iBZbZo4wata3/sMqmavw+qdQdwZNQ8SMsyvJBzNI/BJreHP0r0MBS+b RoDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2NB1qQZQYSd9cmg6hv/iGSHwsxrNu/Ndy4onKkeFGNU=; b=IKElJNYjGEaTmeDmofSEjquA0usKvL8ku8eAwNi4TZ6Xy8DL3odfc7BQu60Zu5Ir0y gc+8M+kXzFj/NdqlLimvuOJn1cXSecjq0exjn6y8Pe7fDI5TwnjUMABFgZtisWIa008v SRYdXSBnzaKRhCerO48JUQVbkAOJ/OmSYKHomChYw7B3gPSfyhaVtnqTB56TCjw7rZrP QLCAxtLcC47WnGI5jdk+m6hwHStOCB948zlKmn3UtSwQbGCzvYJ08XTr3P8nnOIUQifQ Qj0AqCcsWwiZS8S7IgRNh9ycBpi22gIVG8wtiijFqFnrB32VhB07gCqJ+Ij+qWcquNL4 iKRQ== X-Gm-Message-State: ANoB5pmV05BNcH43nZ+2X4PKlo35DPjr0Y0HlDvkRQOrPTHtlC7FmHqB m/TH1Kc1GbPjNjpEuzv39Eivm4TEddR5bul+n1w= X-Google-Smtp-Source: AA0mqf5tITDyOPVVloVcnY1DT/sgTCzdnd88pdM+pv35OzJFTGPTuYjl8zkCcFFv/CJFMDTvdqcK7jLOoYcOxHDroBM= X-Received: by 2002:a9d:70cc:0:b0:66c:5232:b9d1 with SMTP id w12-20020a9d70cc000000b0066c5232b9d1mr8393009otj.224.1669366592494; Fri, 25 Nov 2022 00:56:32 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 25 Nov 2022 00:56:32 -0800 In-Reply-To: X-Hashcash: 1:20:221125:59544@debbugs.gnu.org::DCMy2bwyPwaSFEpN:F77e X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248982 Archived-At: "lux" writes: >> Hmm, I'm not sure about the hard-coded 512 character line limit here. >> ISTR that some people use much longer lines than that. > > Hi, do you have any suggestions? At present, I think hardcoding 512 is > enough, thanks :-) No idea, really. 2^16? 2^20? But why not allocate it dynamically, getting rid of any such arbitrary limits? AFAIU, grep (which we used before) doesn't have such limits, so I fear that we otherwise risk introducing regressions.