From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#66466: [PATCH] Support lua-ts-mode in align.el Date: Thu, 12 Oct 2023 11:20:10 +0000 Message-ID: References: <87bkd5oyoj.fsf@pub.pink> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35630"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66466@debbugs.gnu.org, john muhl To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 12 13:21:07 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qqtkY-0009Ao-Rp for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 Oct 2023 13:21:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqtkC-0006r3-C3; Thu, 12 Oct 2023 07:20:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqtk9-0006qh-JO for bug-gnu-emacs@gnu.org; Thu, 12 Oct 2023 07:20:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qqtk8-000439-6G for bug-gnu-emacs@gnu.org; Thu, 12 Oct 2023 07:20:40 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qqtkU-0003bh-54 for bug-gnu-emacs@gnu.org; Thu, 12 Oct 2023 07:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Oct 2023 11:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66466 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66466-submit@debbugs.gnu.org id=B66466.169710964513828 (code B ref 66466); Thu, 12 Oct 2023 11:21:02 +0000 Original-Received: (at 66466) by debbugs.gnu.org; 12 Oct 2023 11:20:45 +0000 Original-Received: from localhost ([127.0.0.1]:41180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqtkD-0003ay-3W for submit@debbugs.gnu.org; Thu, 12 Oct 2023 07:20:45 -0400 Original-Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]:60424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qqtk7-0003af-Sj for 66466@debbugs.gnu.org; Thu, 12 Oct 2023 07:20:44 -0400 Original-Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2c124adf469so9967251fa.0 for <66466@debbugs.gnu.org>; Thu, 12 Oct 2023 04:20:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697109611; x=1697714411; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=BSyl6fMMRY6oRTZl128HmMDGFMdDazzkQeCY7FIy62M=; b=FEdl7h3OZZs+V6V3+9CuHVgoC+Bpti/wko6UMARwGEB3j/ypnOwBfgC0h5X0cO09qp gQJtw7Ko3jEKw1uqiG7u3nBYf6F9NXffQJ6BtriArc8vgsHoQeCSWzSdLHgpQqxWm30X cjIenXfvj3syrEnM3poSXN3DpU9r7Jv5+kzmkBnuzIv2p4Xj4nt8hc6oYp04jrq2iaBW SmcGjHh3Ul6VNtPklw2fXNASbpwxcHXHx4ySVJ5EVZtuaYg7e5K9u42PscWQ1XKoLRbY Yp3j80CbhLLhMQPFGxxE7Mwq93WcOxD/n9fC1jpIBwC45B+rt9Em6tyaWE5jgcCdpX+P /fmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697109611; x=1697714411; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BSyl6fMMRY6oRTZl128HmMDGFMdDazzkQeCY7FIy62M=; b=QFvijE6UmseBPTTGWR0x2vdMntkNo9ulUhKLkG7rxVBnfEpYVlLRSDZ42AcRXyw8jg vVeetdli8N9ujOXAC3tghHjlHbUzCHWUeTMYwLg+S/vIz1ugb/G75MaukBQIXRV9CEki EAAyU8vOd7n1i2NpB6/6oEteJGPJJfviOglRb+gm2DKc2TRH53vZGRdIDwpEEAmTZ0Yx Ux+qzLyKxHNOYjgaViZV0z9R/URklPUCWBPq9jGL29X/vaRzy/5/SM9cnhW+6kxnSFE9 eBILtuF4ahNhb+ZQcXrkPzrXPt5UB4a8AseLe28M5PFfWUbruKBU2PqHMAI/+4vqhf1Q QSLg== X-Gm-Message-State: AOJu0YxS1vAEWQ9/KcMmTPlKuCAUgtyR1QU+MKdyY0iQvmiSqRqTdtd0 uPMEHJUQ4ORxlDszpsf09Od+6kdp5r6LDuNUvFs= X-Google-Smtp-Source: AGHT+IGHBhiToFLBN8+I9Kq76235sEo4Ng/19niGq/EZRAehm2pYkuxMaJNnCipykA3o+FWtbkTgx3xBp+1EZw6Mkbw= X-Received: by 2002:a2e:2e15:0:b0:2bc:f439:b5a5 with SMTP id u21-20020a2e2e15000000b002bcf439b5a5mr23593067lju.14.1697109611022; Thu, 12 Oct 2023 04:20:11 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 12 Oct 2023 11:20:10 +0000 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272288 Archived-At: Eshel Yaron writes: >> Should `lua-mode' also be in `modes'? > > Another option would be for `lua-ts-mode` to define > `align-mode-rules-list` locally, instead of extending `align-rules-list` > globally. That's an option, but then sharing it between modes is harder. FWIW, only prolog-mode seems to do it locally. > Also, I noticed that we already have several similar rules for aligning > assignments and comments in `align-rules-list`. Do none of them work > for Lua? If so, I wonder what specifics of Lua's syntax make the > existing rules inapplicable. Maybe one of the existing rules can be > extended instead. Maybe, OTOH the list of rules is not that long.