From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#48404: 28.0.50; "Invalid version syntax" errors with read-extended-command Date: Fri, 14 May 2021 18:45:16 +0200 Message-ID: References: <875yzms6im.fsf@gnu.org> <83wns1zvhs.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12784"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48404@debbugs.gnu.org, Tassilo Horn To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 14 19:26:39 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lhbaB-00034Q-4m for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 May 2021 19:26:39 +0200 Original-Received: from localhost ([::1]:36284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhbaA-0002zK-8E for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 May 2021 13:26:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhawr-0006ZJ-V8 for bug-gnu-emacs@gnu.org; Fri, 14 May 2021 12:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35391) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lhawr-0006A4-NY for bug-gnu-emacs@gnu.org; Fri, 14 May 2021 12:46:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lhawr-0005F5-M4 for bug-gnu-emacs@gnu.org; Fri, 14 May 2021 12:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 May 2021 16:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48404 X-GNU-PR-Package: emacs Original-Received: via spool by 48404-submit@debbugs.gnu.org id=B48404.162101073820120 (code B ref 48404); Fri, 14 May 2021 16:46:01 +0000 Original-Received: (at 48404) by debbugs.gnu.org; 14 May 2021 16:45:38 +0000 Original-Received: from localhost ([127.0.0.1]:46937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhawT-0005ES-Sx for submit@debbugs.gnu.org; Fri, 14 May 2021 12:45:38 -0400 Original-Received: from mail-pg1-f179.google.com ([209.85.215.179]:41580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhawR-0005EA-FT for 48404@debbugs.gnu.org; Fri, 14 May 2021 12:45:36 -0400 Original-Received: by mail-pg1-f179.google.com with SMTP id t30so3158482pgl.8 for <48404@debbugs.gnu.org>; Fri, 14 May 2021 09:45:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ihzJ8GlAB16khCyEsNJTpoNAcaVobZN3X07uL6d2Pec=; b=nZGg0l0ufvtKtyvTexUbdMrg3CswaqJFdHnzsCab2YgfoRNor4JSolyC/SnQM9g0qN xZVar/JvSJlvhs4LSMFdeWoz3EGo4WciXomdqQ7ttoyk4ebN0e5o7VN4VFa1Uf61l7Vb LX4KgR6s8gGAGKDUR6c9OwemyeTBio9FHUWuaHytAL1ERt34zNjCtk6Z1Rn9zc+Q1xww yRJeKaOApxlWDzujYr4b2ADPZx25rtFR/DK5GWvdAx0hhsJDHqVQvymbec+1MAE/KePK nWvD2DtRvbSi+p+MzhYTCz630pzYlLYZqWICmhJ0lfgqfJY30WRa9J2N/kLIi6iNfDYk AUFw== X-Gm-Message-State: AOAM533x96tKRjPlPfdeDMEWfD10jrarzSyLWLDMMyKazAjMaEtARGCi PvFZ1hDsMTnaFtiI8tmhmJ63j9rBU1rMtyjYfTxQGIgT X-Google-Smtp-Source: ABdhPJwDoTfEZHCjlpx7dpuRuoSoiTLYTEjXouVWYwsgfI0zgRJ3YY76wJyq+jOiA/bkGclQ3mhpxWhBA9QeUAunUvQ= X-Received: by 2002:a63:e4a:: with SMTP id 10mr34510761pgo.67.1621010729555; Fri, 14 May 2021 09:45:29 -0700 (PDT) In-Reply-To: <83wns1zvhs.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206540 Archived-At: Eli Zaretskii writes: > > Since commit 1af91d271e077134e272055407fb8c4312a7579b I get strange > > "Invalid version syntax: (must start with a number)= " > > errors during M-x completion in the minibuffer. I can't reproduce with > > emacs -Q but in the error, is always some (M)ELPA package. > > > > For example, M-x mag TAB gives > > > > completion--some: Invalid version syntax: =E2=80=98Magit 3.0.0=E2=80= =99 (must start with a number) > > That commit uses byte-obsolete-info property of a symbol, and expects > its caddr to be a valid version number. It sounds like in some cases > it is not an Emacs version, but something else. So, questions: > > . can you find out what kind of value does the byte-obsolete-info > property is there on Magit functions? and > . how come these properties were added to something that is not an > Emacs core code? > > In any case, it sounds like blindly trusting the value of that > property is not a good idea, and we should wrap the call to > version-to-list there in condition-case. Could you try that? The timing for Lars pushing my patch was a bit unfortunate, as I'm currently away traveling and won't have any time to look at this in the next week or two at least. I unfortunately didn't say so in the relevant bug thread, but I hadn't yet convinced myself that the patch was the correct one, and had the intention of returning to it for a closer look before pushing. If any immediate issues can be resolved, this is on my todo list and I will take a look at this when I'm back home. It would also be fine to just revert my patch for now and re-open the bug report. Thanks.