From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59548: [PATCH] Include the package name in package-vc--unpack's prompt Date: Thu, 24 Nov 2022 15:27:41 -0800 Message-ID: References: <8114c20a-148e-7e89-5ad8-a5fb43112cb9@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18699"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic , 59548@debbugs.gnu.org To: daanturo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 25 00:28:30 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyLdu-0004lx-BX for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Nov 2022 00:28:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyLdV-0006gx-8U; Thu, 24 Nov 2022 18:28:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyLdT-0006g7-Th for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 18:28:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyLdT-0000nw-Lq for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 18:28:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyLdS-0002jD-EF for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 18:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Nov 2022 23:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59548 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59548-submit@debbugs.gnu.org id=B59548.166933247010441 (code B ref 59548); Thu, 24 Nov 2022 23:28:02 +0000 Original-Received: (at 59548) by debbugs.gnu.org; 24 Nov 2022 23:27:50 +0000 Original-Received: from localhost ([127.0.0.1]:60485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyLdG-0002iL-9u for submit@debbugs.gnu.org; Thu, 24 Nov 2022 18:27:50 -0500 Original-Received: from mail-ot1-f45.google.com ([209.85.210.45]:43931) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyLdD-0002i5-Pq for 59548@debbugs.gnu.org; Thu, 24 Nov 2022 18:27:48 -0500 Original-Received: by mail-ot1-f45.google.com with SMTP id t19-20020a9d7753000000b0066d77a3d474so1702316otl.10 for <59548@debbugs.gnu.org>; Thu, 24 Nov 2022 15:27:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=76t5z6Ha/gUHu2sH7eexIpPCoxMjuwAkPKDSWlXUGBI=; b=bbpZnia/CbMbbQLC3+0wQE828obnUY9ShXPGvtB/wl+qV6JT/8MtD57QvOH+Q5ULze nFCkGZPypA8X0HYWUE0ER4NkeT5AM6n80CpnMama9yfz/j0KbH1lD89zRiXaGoi0i3O2 n1vIeRJOCAiFi2bVwhgFBbQulp7ubzkso51eSZyLaasNCGQB/PwWXJR+UWRzmhN7GEG4 sYL3Cjkk8E4FvoaMj3Em4kVwWtxwhcT0ZFdrKXT6Z8I1MvDi1+ltwBPnZoWi+PCj71Ma Zd2OS1CdGtTssbiEy4v3HQQ/fXzpDlWV1iNbPSO4GIr7D4wP4GVg4GrJEeHeU1p6V2Gu 5mow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=76t5z6Ha/gUHu2sH7eexIpPCoxMjuwAkPKDSWlXUGBI=; b=Av3f+oxpZTT2mIbtJxHW54CbnsY8qVhRsfjl9OaBIRoznrR1A43ylv5HjzYKLSMUXh 8F0pU5i/6h1LToEZx2GrYjlhmuZL2rPB4ZCExGnubpvq7Q+v5xD4iVuf+vqsfWUxl12/ sRYb8SreLmb/W6V24N1Uz27+0O+jv4cLjmbBAyv8pWkeGsaLFe68Rm9tsPGzokkGKQb2 IXY12jCedeehp27Zz5EQDXSLjbC72OMbsYPjKR5wuU4+KMooiFC/frO4WQq+oqvCzJ1X VyCmiQ+l3O6N/fba37ofV9W5ho3k7ZqKgE3UvvZBNHuCOsM0/4YIZYoca6XTqYS/RtMJ 4s8w== X-Gm-Message-State: ANoB5pnwd0Czg6Vxr97k1pyIIAIlJIi9YPJcYETUlXplgpH5AMScF3qD +ldwk3ow8fYELl0KJQp4dNhB70hWR4pSUs2T1To= X-Google-Smtp-Source: AA0mqf6Y+9B57G0M65v5ypDh6/QCrl1hZTaU15rHlWnj7HVgTZoz+XfXPoC2vuLYKFfB4S1Ffjo42CReoPBniAxWA0Y= X-Received: by 2002:a9d:70cc:0:b0:66c:5232:b9d1 with SMTP id w12-20020a9d70cc000000b0066c5232b9d1mr7686087otj.224.1669332462135; Thu, 24 Nov 2022 15:27:42 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 24 Nov 2022 15:27:41 -0800 In-Reply-To: <8114c20a-148e-7e89-5ad8-a5fb43112cb9@gmail.com> (daanturo@gmail.com's message of "Fri, 25 Nov 2022 00:12:37 +0700") X-Hashcash: 1:20:221124:philipk@posteo.net::vOvHH+B8ZWP7n1S8:0Ij7 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248925 Archived-At: daanturo writes: > Tags: patch > > Make the prompt a bit more informative, as sometimes I am presented with > this question at startup without even knowing the cause. LGTM. Philip, WDYT? > From dba6787f0cb1e92f3c9eb62b1f7d9ab6599c43a1 Mon Sep 17 00:00:00 2001 > From: Daanturo > Date: Fri, 25 Nov 2022 00:06:37 +0700 > Subject: [PATCH] More informant prompt for package-vc--unpack > > * lisp/emacs-lisp/package-vc.el (package-vc--unpack): show the package's > name while asking whether to overwrite its previous checkout. > --- > lisp/emacs-lisp/package-vc.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el > index bf1ea2bdf4..a9c1bbfe60 100644 > --- a/lisp/emacs-lisp/package-vc.el > +++ b/lisp/emacs-lisp/package-vc.el > @@ -523,7 +523,7 @@ package-vc--unpack > (pkg-dir (expand-file-name dirname package-user-dir))) > (setf (package-desc-dir pkg-desc) pkg-dir) > (when (file-exists-p pkg-dir) > - (if (yes-or-no-p "Overwrite previous checkout?") > + (if (yes-or-no-p (format "Overwrite %s's previous checkout?" name)) > (package--delete-directory pkg-dir) > (error "There already exists a checkout for %s" name))) > (package-vc--clone pkg-desc pkg-spec pkg-dir rev)