From: Stefan Kangas <stefankangas@gmail.com>
To: daanturo <daanturo@gmail.com>
Cc: Philip Kaludercic <philipk@posteo.net>, 59548@debbugs.gnu.org
Subject: bug#59548: [PATCH] Include the package name in package-vc--unpack's prompt
Date: Thu, 24 Nov 2022 15:27:41 -0800 [thread overview]
Message-ID: <CADwFkmnGA1aEGfdExBdkBGP1JPeZGgKbva+qKJ-AQHCRiQ9CvQ@mail.gmail.com> (raw)
In-Reply-To: <8114c20a-148e-7e89-5ad8-a5fb43112cb9@gmail.com> (daanturo@gmail.com's message of "Fri, 25 Nov 2022 00:12:37 +0700")
daanturo <daanturo@gmail.com> writes:
> Tags: patch
>
> Make the prompt a bit more informative, as sometimes I am presented with
> this question at startup without even knowing the cause.
LGTM. Philip, WDYT?
> From dba6787f0cb1e92f3c9eb62b1f7d9ab6599c43a1 Mon Sep 17 00:00:00 2001
> From: Daanturo <daanturo@gmail.com>
> Date: Fri, 25 Nov 2022 00:06:37 +0700
> Subject: [PATCH] More informant prompt for package-vc--unpack
>
> * lisp/emacs-lisp/package-vc.el (package-vc--unpack): show the package's
> name while asking whether to overwrite its previous checkout.
> ---
> lisp/emacs-lisp/package-vc.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
> index bf1ea2bdf4..a9c1bbfe60 100644
> --- a/lisp/emacs-lisp/package-vc.el
> +++ b/lisp/emacs-lisp/package-vc.el
> @@ -523,7 +523,7 @@ package-vc--unpack
> (pkg-dir (expand-file-name dirname package-user-dir)))
> (setf (package-desc-dir pkg-desc) pkg-dir)
> (when (file-exists-p pkg-dir)
> - (if (yes-or-no-p "Overwrite previous checkout?")
> + (if (yes-or-no-p (format "Overwrite %s's previous checkout?" name))
> (package--delete-directory pkg-dir)
> (error "There already exists a checkout for %s" name)))
> (package-vc--clone pkg-desc pkg-spec pkg-dir rev)
next prev parent reply other threads:[~2022-11-24 23:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 17:12 bug#59548: [PATCH] Include the package name in package-vc--unpack's prompt daanturo
2022-11-24 23:27 ` Stefan Kangas [this message]
2022-11-25 7:31 ` Philip Kaludercic
2022-11-25 8:04 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmnGA1aEGfdExBdkBGP1JPeZGgKbva+qKJ-AQHCRiQ9CvQ@mail.gmail.com \
--to=stefankangas@gmail.com \
--cc=59548@debbugs.gnu.org \
--cc=daanturo@gmail.com \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).