From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds Date: Tue, 2 Nov 2021 10:01:56 -0700 Message-ID: References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> <83tuguk3h2.fsf@gnu.org> <83k0hqjywm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17322"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, 51556@debbugs.gnu.org, kevin.legouguec@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 02 18:03:50 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mhxCQ-0004CT-9K for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Nov 2021 18:03:50 +0100 Original-Received: from localhost ([::1]:60218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhxCO-0000FT-UD for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Nov 2021 13:03:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhxBe-0007gs-4S for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 13:03:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54615) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mhxBd-00057h-RH for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 13:03:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mhxBd-00051R-M8 for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 13:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Nov 2021 17:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51556 X-GNU-PR-Package: emacs Original-Received: via spool by 51556-submit@debbugs.gnu.org id=B51556.163587252419205 (code B ref 51556); Tue, 02 Nov 2021 17:03:01 +0000 Original-Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 17:02:04 +0000 Original-Received: from localhost ([127.0.0.1]:37928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhxAi-0004zg-Kx for submit@debbugs.gnu.org; Tue, 02 Nov 2021 13:02:04 -0400 Original-Received: from mail-pg1-f173.google.com ([209.85.215.173]:34574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhxAh-0004z9-Bl for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 13:02:03 -0400 Original-Received: by mail-pg1-f173.google.com with SMTP id j9so15900pgh.1 for <51556@debbugs.gnu.org>; Tue, 02 Nov 2021 10:02:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=TNehbi/MsZauC7izyXbK7opf/x3CSs68GyKXM4JMUhM=; b=GyGB0Qhxd2w4zh38T/AINqcwzECIxqFty/m9ldW6pqj/+LoEdvKkwEz7LtkzXGx97K pmLQlLoSHykm+0TgHI1cTiDDoBe26SrmBGlnoAT3nj/tqnjh2L+nHGBU8occDmHWQKvM XP4Gryt0rxsFAhI2c/R4lOAlSVIBDstxUM8mCSOySpEB6KnPgL1XCK/b5x9xpqhu6DPG 6ej63t57/uCkfn9nM5p9YoBRnB84lrwbAvuFHswwYkli7KqWXezSpoOf8YPWy8L7f+Eg moZ5yHj5fTL0S32/8zUphcEfedc64T2sBNRVNf3zS4iPQ8iR0t9WScW1Z4VekJiseuSu Ll5w== X-Gm-Message-State: AOAM5303BqI9A/3ftv4LYfugvuCf/2pG17AJEZejj6B3M7Db7F61EI1J zA5jc/5hEfyFhrruKGhNKpyRK8z2WwJtmQUO0BQ= X-Google-Smtp-Source: ABdhPJy2RA22yiy56MOXKsCnOukVCkFGe3zwR3n7ftjjfsqjUTOU52YmB1PTu1TtEZhA/HFLMXD+Yi/I2IOr9lYjwhY= X-Received: by 2002:a63:330f:: with SMTP id z15mr28906866pgz.42.1635872517142; Tue, 02 Nov 2021 10:01:57 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 2 Nov 2021 10:01:56 -0700 In-Reply-To: <83k0hqjywm.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218819 Archived-At: Eli Zaretskii writes: > I don't think I understand what that means. We disregard the colors > specified by the SVG image? No, we do respect colors specified by the SVG image. That's why we see the current behavior. However, if no foreground color is specified in the SVG file, we use the foreground color of the current face instead. That's why the fix I propose work. > Sorry, at this stage I'd prefer not to install anything on the release > branch that isn't a bugfix. Or else take it up with Lars, and ask him > to forget about releasing Emacs 28.1 soon, because this way it will > take a while ;-) I consider this a bug fix, but admittedly only a minor one. However, I also note that the visibility of those symbols is worse with a dark theme in Emacs 28 than in Emacs 27, so we might consider it a regression. That said, I of course understand that some kind of line have to be drawn, and I'm personally fine with installing this only on master. If people feel that it is important, perhaps we could consider backporting the fix to Emacs 28.2 later (read: please speak up if you think so).