From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#44676: [PATCH 2/4] Support native compilation of packages on install Date: Fri, 20 Nov 2020 12:07:42 -0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33223"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44676@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 20 21:08:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kgCha-0008ZR-Re for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Nov 2020 21:08:14 +0100 Original-Received: from localhost ([::1]:49480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kgChZ-0000JC-TS for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Nov 2020 15:08:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kgChO-0000Ha-HC for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2020 15:08:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32793) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kgChO-00073S-8R for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2020 15:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kgChO-00054E-3w for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2020 15:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Nov 2020 20:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44676-submit@debbugs.gnu.org id=B44676.160590287019459 (code B ref 44676); Fri, 20 Nov 2020 20:08:02 +0000 Original-Received: (at 44676) by debbugs.gnu.org; 20 Nov 2020 20:07:50 +0000 Original-Received: from localhost ([127.0.0.1]:44339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kgChC-00053m-5n for submit@debbugs.gnu.org; Fri, 20 Nov 2020 15:07:50 -0500 Original-Received: from mail-ej1-f49.google.com ([209.85.218.49]:37321) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kgChA-00053Z-7W for 44676@debbugs.gnu.org; Fri, 20 Nov 2020 15:07:48 -0500 Original-Received: by mail-ej1-f49.google.com with SMTP id f20so14558089ejz.4 for <44676@debbugs.gnu.org>; Fri, 20 Nov 2020 12:07:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=0m0UtrFDIEtymYnUOUuNQ1j07xYxyvRR3KtOb2np7o0=; b=tAZ20QX/MImrh+KuQC/oFjI6QSFqvi251/mrCray7KmCdu0hW/sHyLMAvzoZFHSl7V 0qYK7uT++D2nE8qJd/96WGa4tRtvJl+6ZsBTirHqtXswvnseKylmINZjK4ZYVuuoIBCl kgPr8NNoFT+YdaCAYsFAn+QpMeKbkkmUMUxeN9EAUjhwe2xYyV1VGxWP0Ac2Z0GA9DwD tU5pqIrsMEa5V+b99yM8hK9y37nVULFjNHOMm5r3hefykvfcr1kaV7SSbl5OsnppUjxQ kVMGAQ5YhQTKftA3YbmOihrCdaKdXAHgxD0J6UaCTOA7ltkfUv+HQTnMFTAMqrL96+1e MDLA== X-Gm-Message-State: AOAM531o7pV134mPEKGwrlotVJ7x4wcDMGRAynAgliVPKCpkYNU/Jzya /nO7VuFaQgDubm8Rs+Mx1HwTkXOLGMaP+wVNmWcdX342 X-Google-Smtp-Source: ABdhPJwLf4MeI4K2ZDkZGIqBqY5E61L0sBvheGR13mR4hRpoNOnIvxv7LKhQMFDtH89ZQRFI60y+wmT6UgqR9BmCyj8= X-Received: by 2002:a17:906:8058:: with SMTP id x24mr35322222ejw.272.1605902862655; Fri, 20 Nov 2020 12:07:42 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 20 Nov 2020 12:07:42 -0800 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193796 Archived-At: Andrea Corallo writes: >> +(defcustom package-native-compile t >> + "Non-nil means to native compile packages on installation." >> + :type '(boolean) >> + :risky t >> + :version "28.1") > > I don't have a strong feeling but I'm really not convinced this should > be t by default. Despite personal preferences the nil equivalent of > this is what we already do for vast majority of the .el distributed with > Emacs. WDYT? I don't have a strong opinion. Since I recompile Emacs frequently, I would likely want to set this to nil, but I assume most users would just use whatever comes with their distro. So perhaps a t value makes more sense for most users. That said, I'm happy with introducing the variable set to a nil value. We have time to change it later when we can think about it some more, and get experience with it. So I'll change it as you suggest (and update the NEWS entry accordingly). > Otherwise LGTM Thanks.