From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#57691: 29.0.50; image-tests failures Date: Fri, 9 Sep 2022 18:37:20 -0400 Message-ID: References: <83y1utcbcl.fsf@gnu.org> <83illwdauv.fsf@gnu.org> <83czc4d7up.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10055"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57691@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 10 00:38:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWmdX-0002VF-2C for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Sep 2022 00:38:11 +0200 Original-Received: from localhost ([::1]:59856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWmdW-0005es-2E for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Sep 2022 18:38:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40338) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWmdO-0005eN-Kc for bug-gnu-emacs@gnu.org; Fri, 09 Sep 2022 18:38:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47193) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oWmdO-0001rj-CJ for bug-gnu-emacs@gnu.org; Fri, 09 Sep 2022 18:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oWmdO-0007LR-3A for bug-gnu-emacs@gnu.org; Fri, 09 Sep 2022 18:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Sep 2022 22:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57691 X-GNU-PR-Package: emacs Original-Received: via spool by 57691-submit@debbugs.gnu.org id=B57691.166276304928180 (code B ref 57691); Fri, 09 Sep 2022 22:38:02 +0000 Original-Received: (at 57691) by debbugs.gnu.org; 9 Sep 2022 22:37:29 +0000 Original-Received: from localhost ([127.0.0.1]:35889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWmcq-0007KR-Om for submit@debbugs.gnu.org; Fri, 09 Sep 2022 18:37:29 -0400 Original-Received: from mail-ot1-f50.google.com ([209.85.210.50]:36662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWmco-0007KE-Ps for 57691@debbugs.gnu.org; Fri, 09 Sep 2022 18:37:27 -0400 Original-Received: by mail-ot1-f50.google.com with SMTP id 6-20020a9d0106000000b0063963134d04so1980121otu.3 for <57691@debbugs.gnu.org>; Fri, 09 Sep 2022 15:37:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date; bh=UshXe2xy8/50KNkl7koWXXZCtyleg64HBsIOQXENEs0=; b=dr4CVij2f+6ucYkQH5x/NrOwwvhU+n4BD05tqwryYhN2vOwH+kNPajStBJbIKu5NON zMYXUunjlWa+tvgb2FAgoPcXe1/OtxOKBlq0h9T9NeKy0d+0CJfrJdTG/TABDbuXy0MC Q5P8Xd8FtBb3/ku3kKHjVxG7CdtrP6dgKx2FJzfRymLkx3/5AWYGQtcu2kvtUCtiVeHr hfbqjajA2GUFXYv6bvohhH8PYMapmchv49QV80rpt/QjVKscYoakQlUziUdCeZHIX5xz mMEAz4bWMg4onTvyjSoPc8GpwU+u1YjJ6WWMK4fkQp8n2xDhyN2pCMnnyrKoRFJBsyn4 JBZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date; bh=UshXe2xy8/50KNkl7koWXXZCtyleg64HBsIOQXENEs0=; b=NUIN5dPWFnzuYjSzUMfl8Vjf4XDSQSatkpCZWHWfY6Dk1CvHk3Evix5JaApyGc+1A5 9SwXSghgKuaaiy4wfOfzulZnKbVnBWlFkcLstmEr8zvC+JrAfL7Fbm+dSZaGutz0h9gB byeaXjbfXipvoNjcmmYIbGMBEfKfpTKHfzPFDN7kC7B1F7o3YcKBB/Bv9O03uutTBOsd jdg2lPqNZFLKAH8NBJ2qbrvlweXDL171hDVceshY9oGC9cZ+TnBzix3ikpTRY+Fjwrrn MbvQ6BWuHNFF+ku3TlvMcbJ8lVND5Wz3/VZ5AaeziQh3WFJmTTf+ztCtOygRdPRM7XCT ZRfQ== X-Gm-Message-State: ACgBeo08fhfYSH7RlVEi2XIEFM7OXIeOmU1vpqmh2cBeKaZvzQnru4pU iwnA93fzS+xH4pfQ9HpdNsUOWPU88GkYtqav3IEAA7ap X-Google-Smtp-Source: AA6agR7W1z8EWt7S3BSTTYoJg0Umu4D+2BClJ14vWFQF5yOnpGPrSehgS68JnjNteJwapDprLaXtTsyb2n57YL0AkBs= X-Received: by 2002:a9d:f05:0:b0:637:1068:1081 with SMTP id 5-20020a9d0f05000000b0063710681081mr5979406ott.224.1662763041170; Fri, 09 Sep 2022 15:37:21 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 9 Sep 2022 18:37:20 -0400 In-Reply-To: <83czc4d7up.fsf@gnu.org> X-Hashcash: 1:20:220909:57691@debbugs.gnu.org::W0rBYKgeno4RVsiL:1ihF X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242045 Archived-At: Eli Zaretskii writes: > What does that test check? why does it want to see the delay? It used to just check that no metadata was returned for these images. Then Lars changed the GIF and WebP loading code to always add a `delay', so I adapted the tests to that. (More work is needed to make these tests check for more substantial things. See the TODO where I say that we could expand them to test using files that actually do contain metadata.) > The native APIs support animated GIFs better than with libgif, so > artificially making changes of the delay for the single benefit of > running this test is not the best idea, IMO. Gotcha. So it sounds like we should leave that alone, and adapt the test to Windows instead. Does the below workaround make sense? That way, at least we test something. diff --git a/test/manual/image-tests.el b/test/manual/image-tests.el index c66080cf02..4b1b122309 100644 --- a/test/manual/image-tests.el +++ b/test/manual/image-tests.el @@ -220,11 +220,13 @@ image-tests-image-mask-p/error-on-invalid-spec ;; TODO: These tests could be expanded with files that actually ;; contain metadata. +(defvar w32-use-native-image-API) (ert-deftest image-tests-image-metadata/gif () (image-skip-unless 'gif) - (should (memq 'delay - (image-metadata - (create-image (cdr (assq 'gif image-tests--images))))))) + (let ((w32-use-native-image-API nil)) + (should (memq 'delay + (image-metadata + (create-image (cdr (assq 'gif image-tests--images)))))))) (ert-deftest image-tests-image-metadata/jpeg () (image-skip-unless 'jpeg)