From: Stefan Kangas <stefankangas@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: Morgan Smith <Morgan.J.Smith@outlook.com>, 59158@debbugs.gnu.org
Subject: bug#59158: [PATCH] vc-git: Ensure git doesn't try to colorize stashes
Date: Sat, 12 Nov 2022 11:41:54 -0800 [thread overview]
Message-ID: <CADwFkmnDKTASBiD8RBnt-AZ8G-JHT=Z3TyZ+4240Bh-epkhdMQ@mail.gmail.com> (raw)
In-Reply-To: <868rkgnjib.fsf@mail.linkov.net>
close 59158 29.1
thanks
Juri Linkov <juri@linkov.net> writes:
>> However, as Emacs can't process those control characters in any case, I
>> think we might as well apply the patch you suggest. This will save
>> users from shooting themselves in the foot.
>>
>> Does anyone see any reason not to?
>
> Since --color=never doesn't look like a new option of git diff,
> it should be pretty safe to apply the patch.
OK, pushed to master (commit 4ccc385ab1).
prev parent reply other threads:[~2022-11-12 19:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 21:22 bug#59158: [PATCH] vc-git: Ensure git doesn't try to colorize stashes Morgan Smith
2022-11-11 12:44 ` Stefan Kangas
[not found] ` <DM5PR03MB3163A214577D525A6F90C9D7C5009@DM5PR03MB3163.namprd03.prod.outlook.com>
2022-11-12 5:00 ` Stefan Kangas
2022-11-12 17:57 ` Juri Linkov
2022-11-12 19:41 ` Stefan Kangas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmnDKTASBiD8RBnt-AZ8G-JHT=Z3TyZ+4240Bh-epkhdMQ@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=59158@debbugs.gnu.org \
--cc=Morgan.J.Smith@outlook.com \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).